From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ehl: Add support for DPLL4 (v4) Date: Wed, 17 Apr 2019 16:06:11 +0300 Message-ID: <20190417130611.GA1747@intel.com> References: <20190406004638.kphcrvaofpe4oqgp@ldmartin-desk.amr.corp.intel.com> <20190411233600.14891-1-vivek.kasireddy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B05089F69 for ; Wed, 17 Apr 2019 13:06:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190411233600.14891-1-vivek.kasireddy@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vivek Kasireddy Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMTEsIDIwMTkgYXQgMDQ6MzY6MDBQTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5 IHdyb3RlOgo+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBEUExMNCBvbiBFSEwgdGhhdCBp bmNsdWRlIHRoZQo+IGZvbGxvd2luZyByZXN0cmljdGlvbnM6Cj4gCj4gLSBEUExMNCBjYW5ub3Qg YmUgdXNlZCB3aXRoIERESUEgKGNvbWJvIHBvcnQgQSBpbnRlcm5hbCBlRFAgdXNhZ2UpLgo+ICAg RFBMTDQgY2FuIGJlIHVzZWQgd2l0aCBvdGhlciBERElzLCBpbmNsdWRpbmcgRERJRAo+ICAgKGNv bWJvIHBvcnQgQSBleHRlcm5hbCB1c2FnZSkuCj4gCj4gLSBEUExMNCBjYW5ub3QgYmUgZW5hYmxl ZCB3aGVuIERDNSBvciBEQzYgYXJlIGVuYWJsZWQuCj4gCj4gLSBUaGUgRFBMTDQgZW5hYmxlLCBs b2NrLCBwb3dlciBlbmFibGVkLCBhbmQgcG93ZXIgc3RhdGUgYXJlIGNvbm5lY3RlZAo+ICAgdG8g dGhlIE1HUExMMV9FTkFCTEUgcmVnaXN0ZXIuCj4gCj4gdjI6IChzdWdnZXN0aW9ucyBmcm9tIEJv YiBQYWF1d2UpCj4gLSBSZXdvcmsgZWhsX2dldF9kcGxsKCkgZnVuY3Rpb24gdG8gY2FsbCBpbnRl bF9maW5kX3NoYXJlZF9kcGxsKCkgYW5kCj4gICBpdGVyYXRlIHR3aWNlOiBvbmNlIGZvciBDb21i byBwbGxzIGFuZCBvbmNlIGZvciBNRyBwbGxzLgo+IAo+IC0gVXNlIE1HIHBsbCBmdW5jcyBmb3Ig RFBMTDQgaW5zdGVhZCBvZiBjcmVhdGluZyBuZXcgb25lcyBhbmQgbW9kaWZ5Cj4gICBtZ19wbGxf ZW5hYmxlIHRvIGluY2x1ZGUgdGhlIHJlc3RyaWN0aW9ucyBmb3IgRUhMLgo+IAo+IHYzOiBGaXgg Y29tcGlsYXRpb24gZXJyb3IKPiAKPiB2NDogKHN1Z2dlc3Rpb25zIGZyb20gTHVjYXMgYW5kIFZp bGxlKQo+IC0gVHJlYXQgRFBMTDQgYXMgYSBjb21ibyBwaHkgUExMIGFuZCBub3QgYXMgTUcgUExM Cj4gLSBEaXNhYmxlIERDIHN0YXRlcyB3aGVuIHRoaXMgRFBMTCBpcyBiZWluZyBlbmFibGVkCj4g LSBSZXVzZSBpY2xfZ2V0X2RwbGwgaW5zdGVhZCBvZiBjcmVhdGluZyBhIHNlcGFyYXRlIG9uZSBm b3IgRUhMCj4gCj4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29t Pgo+IENjOiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiBD YzogQm9iIFBhYXV3ZSA8Ym9iLmoucGFhdXdlQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBW aXZlayBLYXNpcmVkZHkgPHZpdmVrLmthc2lyZWRkeUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAzNSArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5o IHwgIDQgKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxf bWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggZTAx YzA1N2NlNTBiLi4yMDdhZjRhZjQ5NzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw bGxfbWdyLmMKPiBAQCAtMjgyNSw2ICsyODI1LDEyIEBAIGljbF9nZXRfZHBsbChzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCWlmIChpbnRlbF9wb3J0X2lzX2NvbWJvcGh5 KGRldl9wcml2LCBwb3J0KSkgewo+ICAJCW1pbiA9IERQTExfSURfSUNMX0RQTEwwOwo+ICAJCW1h eCA9IERQTExfSURfSUNMX0RQTEwxOwo+ICsKPiArCQlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3By aXYpKSB7Cj4gKwkJCWlmIChlbmNvZGVyLT50eXBlICE9IElOVEVMX09VVFBVVF9FRFApCj4gKwkJ CQltYXggPSBEUExMX0lEX0VITF9EUExMNDsKPiArCQl9Cj4gKwo+ICAJCXJldCA9IGljbF9jYWxj X2RwbGxfc3RhdGUoY3J0Y19zdGF0ZSwgZW5jb2Rlcik7Cj4gIAl9IGVsc2UgaWYgKGludGVsX3Bv cnRfaXNfdGMoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gIAkJaWYgKGVuY29kZXItPnR5cGUgPT0gSU5U RUxfT1VUUFVUX0RQX01TVCkgewo+IEBAIC0yOTY0LDggKzI5NzAsMTQgQEAgc3RhdGljIGJvb2wg Y29tYm9fcGxsX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gIAkJCQkgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCwKPiAgCQkJCSAgIHN0cnVj dCBpbnRlbF9kcGxsX2h3X3N0YXRlICpod19zdGF0ZSkKPiAgewo+IC0JcmV0dXJuIGljbF9wbGxf Z2V0X2h3X3N0YXRlKGRldl9wcml2LCBwbGwsIGh3X3N0YXRlLAo+IC0JCQkJICAgIENOTF9EUExM X0VOQUJMRShwbGwtPmluZm8tPmlkKSk7Cj4gKwlpOTE1X3JlZ190IGVuYWJsZV9yZWcgPSBDTkxf RFBMTF9FTkFCTEUocGxsLT5pbmZvLT5pZCk7Cj4gKwo+ICsJaWYgKElTX0VMS0hBUlRMQUtFKGRl dl9wcml2KSAmJgo+ICsJICAgIHBsbC0+aW5mby0+aWQgPT0gRFBMTF9JRF9FSExfRFBMTDQpIHsK PiArCQllbmFibGVfcmVnID0gTUdfUExMX0VOQUJMRSgwKTsKPiArCX0KPiArCj4gKwlyZXR1cm4g aWNsX3BsbF9nZXRfaHdfc3RhdGUoZGV2X3ByaXYsIHBsbCwgaHdfc3RhdGUsIGVuYWJsZV9yZWcp Owo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbCB0YnRfcGxsX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gQEAgLTMwNzYsNiArMzA4OCwxNCBAQCBzdGF0aWMg dm9pZCBjb21ib19wbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiAgewo+ICAJaTkxNV9yZWdfdCBlbmFibGVfcmVnID0gQ05MX0RQTExfRU5BQkxFKHBsbC0+aW5m by0+aWQpOwo+ICAKPiArCWlmIChJU19FTEtIQVJUTEFLRShkZXZfcHJpdikgJiYKPiArCSAgICBw bGwtPmluZm8tPmlkID09IERQTExfSURfRUhMX0RQTEw0KSB7Cj4gKwkJZW5hYmxlX3JlZyA9IE1H X1BMTF9FTkFCTEUoMCk7Cj4gKwo+ICsJCS8qIE5lZWQgdG8gZGlzYWJsZSBEQyBzdGF0ZXMgd2hl biB0aGlzIERQTEwgaXMgZW5hYmxlZC4gKi8KPiArCQlieHRfZGlzYWJsZV9kYzkoZGV2X3ByaXYp OwoKWW91IGNhbid0IHNpbXBseSBjYWxsIHRoYXQgZnJvbSByYW5kb20gcGxhY2VzLiBJdCBuZWVk cyB0byBiZSBoYW5kbGVkIGJ5CnRoZSBwb3dlciBkb21haW4gc3R1ZmYuCgo+ICsJfQo+ICsKPiAg CWljbF9wbGxfcG93ZXJfZW5hYmxlKGRldl9wcml2LCBwbGwsIGVuYWJsZV9yZWcpOwo+ICAKPiAg CWljbF9kcGxsX3dyaXRlKGRldl9wcml2LCBwbGwpOwo+IEBAIC0zMTcxLDcgKzMxOTEsMTUgQEAg c3RhdGljIHZvaWQgaWNsX3BsbF9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPiAgc3RhdGljIHZvaWQgY29tYm9fcGxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ICAJCQkgICAgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBs bCkKPiAgewo+IC0JaWNsX3BsbF9kaXNhYmxlKGRldl9wcml2LCBwbGwsIENOTF9EUExMX0VOQUJM RShwbGwtPmluZm8tPmlkKSk7Cj4gKwlpOTE1X3JlZ190IGVuYWJsZV9yZWcgPSBDTkxfRFBMTF9F TkFCTEUocGxsLT5pbmZvLT5pZCk7Cj4gKwo+ICsJaWYgKElTX0VMS0hBUlRMQUtFKGRldl9wcml2 KSAmJgo+ICsJICAgIHBsbC0+aW5mby0+aWQgPT0gRFBMTF9JRF9FSExfRFBMTDQpIHsKPiArCQll bmFibGVfcmVnID0gTUdfUExMX0VOQUJMRSgwKTsKPiArCQlieHRfZW5hYmxlX2RjOShkZXZfcHJp dik7Cj4gKwl9Cj4gKwo+ICsJaWNsX3BsbF9kaXNhYmxlKGRldl9wcml2LCBwbGwsIGVuYWJsZV9y ZWcpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCB0YnRfcGxsX2Rpc2FibGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IEBAIC0zMjQ5LDYgKzMyNzcsNyBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IGludGVsX2RwbGxfbWdyIGljbF9wbGxfbWdyID0gewo+ICBzdGF0aWMgY29uc3Qg c3RydWN0IGRwbGxfaW5mbyBlaGxfcGxsc1tdID0gewo+ICAJeyAiRFBMTCAwIiwgJmNvbWJvX3Bs bF9mdW5jcywgRFBMTF9JRF9JQ0xfRFBMTDAsIDAgfSwKPiAgCXsgIkRQTEwgMSIsICZjb21ib19w bGxfZnVuY3MsIERQTExfSURfSUNMX0RQTEwxLCAwIH0sCj4gKwl7ICJEUExMIDQiLCAmY29tYm9f cGxsX2Z1bmNzLCBEUExMX0lEX0VITF9EUExMNCwgMCB9LAo+ICAJeyB9LAo+ICB9Owo+ICAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiBpbmRleCBiZDgxMjRjYzgxZWQuLmYz Zjk5OTI5Y2VlOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxs X21nci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+IEBA IC0xMTMsNiArMTEzLDEwIEBAIGVudW0gaW50ZWxfZHBsbF9pZCB7Cj4gIAkgKiBARFBMTF9JRF9J Q0xfRFBMTDE6IElDTCBjb21ibyBQSFkgRFBMTDEKPiAgCSAqLwo+ICAJRFBMTF9JRF9JQ0xfRFBM TDEgPSAxLAo+ICsJLyoqCj4gKwkgKiBARFBMTF9JRF9FSExfRFBMTDQ6IEVITCBjb21ibyBQSFkg RFBMTDQKPiArCSAqLwo+ICsJRFBMTF9JRF9FSExfRFBMTDQgPSAyLAo+ICAJLyoqCj4gIAkgKiBA RFBMTF9JRF9JQ0xfVEJUUExMOiBJQ0wgVEJUIFBMTAo+ICAJICovCj4gLS0gCj4gMi4xNC41Cj4g Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA==