From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 04/12] dma-buf: add optional invalidate_mappings callback v5 Date: Wed, 17 Apr 2019 16:01:16 +0200 Message-ID: <20190417140116.GC13337@phenom.ffwll.local> References: <20190416183841.1577-1-christian.koenig@amd.com> <20190416183841.1577-5-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190416183841.1577-5-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, sumit.semwal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org T24gVHVlLCBBcHIgMTYsIDIwMTkgYXQgMDg6Mzg6MzNQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBFYWNoIGltcG9ydGVyIGNhbiBub3cgcHJvdmlkZSBhbiBpbnZhbGlkYXRlX21h cHBpbmdzIGNhbGxiYWNrLgo+IAo+IFRoaXMgYWxsb3dzIHRoZSBleHBvcnRlciB0byBwcm92aWRl IHRoZSBtYXBwaW5ncyB3aXRob3V0IHRoZSBuZWVkIHRvIHBpbgo+IHRoZSBiYWNraW5nIHN0b3Jl Lgo+IAo+IHYyOiBkb24ndCB0cnkgdG8gaW52YWxpZGF0ZSBtYXBwaW5ncyB3aGVuIHRoZSBjYWxs YmFjayBpcyBOVUxMLAo+ICAgICBsb2NrIHRoZSByZXNlcnZhdGlvbiBvYmogd2hpbGUgdXNpbmcg dGhlIGF0dGFjaG1lbnRzLAo+ICAgICBhZGQgaGVscGVyIHRvIHNldCB0aGUgY2FsbGJhY2sKPiB2 MzogbW92ZSBmbGFnIGZvciBpbnZhbGlkYXRpb24gc3VwcG9ydCBpbnRvIHRoZSBETUEtYnVmLAo+ ICAgICB1c2UgbmV3IGF0dGFjaF9pbmZvIHN0cnVjdHVyZSB0byBzZXQgdGhlIGNhbGxiYWNrCj4g djQ6IHVzZSBpbXBvcnRlcl9wcml2IGZpZWxkIGluc3RlYWQgb2YgbWFuZ2xpbmcgZXhwb3J0ZXIg cHJpdi4KPiB2NTogZHJvcCBpbnZhbGlkYXRpb25fc3VwcG9ydGVkIGZsYWcKPiAKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMgfCAzNyArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvZG1hLWJ1Zi5oICAgfCAzMyArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA2OCBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1idWYv ZG1hLWJ1Zi5jIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1idWYuYwo+IGluZGV4IDgzYzkyYmZkOTY0 Yy4uYTM3MzhmYWIzOTI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMK PiArKysgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWJ1Zi5jCj4gQEAgLTU2Myw2ICs1NjMsOCBAQCBz dHJ1Y3QgZG1hX2J1Zl9hdHRhY2htZW50ICpkbWFfYnVmX2F0dGFjaChjb25zdCBzdHJ1Y3QgZG1h X2J1Zl9hdHRhY2hfaW5mbyAqaW5mbwo+ICAKPiAgCWF0dGFjaC0+ZGV2ID0gaW5mby0+ZGV2Owo+ ICAJYXR0YWNoLT5kbWFidWYgPSBkbWFidWY7Cj4gKwlhdHRhY2gtPmltcG9ydGVyX3ByaXYgPSBp bmZvLT5pbXBvcnRlcl9wcml2Owo+ICsJYXR0YWNoLT5pbnZhbGlkYXRlID0gaW5mby0+aW52YWxp ZGF0ZTsKPiAgCj4gIAltdXRleF9sb2NrKCZkbWFidWYtPmxvY2spOwo+ICAKPiBAQCAtNTcxLDcg KzU3Myw5IEBAIHN0cnVjdCBkbWFfYnVmX2F0dGFjaG1lbnQgKmRtYV9idWZfYXR0YWNoKGNvbnN0 IHN0cnVjdCBkbWFfYnVmX2F0dGFjaF9pbmZvICppbmZvCj4gIAkJaWYgKHJldCkKPiAgCQkJZ290 byBlcnJfYXR0YWNoOwo+ICAJfQo+ICsJcmVzZXJ2YXRpb25fb2JqZWN0X2xvY2soZG1hYnVmLT5y ZXN2LCBOVUxMKTsKPiAgCWxpc3RfYWRkKCZhdHRhY2gtPm5vZGUsICZkbWFidWYtPmF0dGFjaG1l bnRzKTsKPiArCXJlc2VydmF0aW9uX29iamVjdF91bmxvY2soZG1hYnVmLT5yZXN2KTsKPiAgCj4g IAltdXRleF91bmxvY2soJmRtYWJ1Zi0+bG9jayk7Cj4gIAo+IEBAIC02MTUsNyArNjE5LDkgQEAg dm9pZCBkbWFfYnVmX2RldGFjaChzdHJ1Y3QgZG1hX2J1ZiAqZG1hYnVmLCBzdHJ1Y3QgZG1hX2J1 Zl9hdHRhY2htZW50ICphdHRhY2gpCj4gIAkJCQkJICAgRE1BX0JJRElSRUNUSU9OQUwpOwo+ICAK PiAgCW11dGV4X2xvY2soJmRtYWJ1Zi0+bG9jayk7Cj4gKwlyZXNlcnZhdGlvbl9vYmplY3RfbG9j ayhkbWFidWYtPnJlc3YsIE5VTEwpOwo+ICAJbGlzdF9kZWwoJmF0dGFjaC0+bm9kZSk7Cj4gKwly ZXNlcnZhdGlvbl9vYmplY3RfdW5sb2NrKGRtYWJ1Zi0+cmVzdik7Cj4gIAlpZiAoZG1hYnVmLT5v cHMtPmRldGFjaCkKPiAgCQlkbWFidWYtPm9wcy0+ZGV0YWNoKGRtYWJ1ZiwgYXR0YWNoKTsKPiAg Cj4gQEAgLTY1Myw3ICs2NTksMTYgQEAgZG1hX2J1Zl9tYXBfYXR0YWNobWVudF9sb2NrZWQoc3Ry dWN0IGRtYV9idWZfYXR0YWNobWVudCAqYXR0YWNoLAo+ICAJaWYgKGF0dGFjaC0+c2d0KQo+ICAJ CXJldHVybiBhdHRhY2gtPnNndDsKPiAgCj4gKwkvKgo+ICsJICogTWFwcGluZyBhIERNQS1idWYg Y2FuIHRyaWdnZXIgaXRzIGludmFsaWRhdGlvbiwgcHJldmVudCBzZW5kaW5nIHRoaXMKPiArCSAq IGV2ZW50IHRvIHRoZSBjYWxsZXIgYnkgdGVtcG9yYXJ5IHJlbW92aW5nIHRoaXMgYXR0YWNobWVu dCBmcm9tIHRoZQo+ICsJICogbGlzdC4KPiArCSAqLwo+ICsJaWYgKGF0dGFjaC0+aW52YWxpZGF0 ZSkKPiArCQlsaXN0X2RlbCgmYXR0YWNoLT5ub2RlKTsKPiAgCXNnX3RhYmxlID0gYXR0YWNoLT5k bWFidWYtPm9wcy0+bWFwX2RtYV9idWYoYXR0YWNoLCBkaXJlY3Rpb24pOwo+ICsJaWYgKGF0dGFj aC0+aW52YWxpZGF0ZSkKPiArCQlsaXN0X2FkZCgmYXR0YWNoLT5ub2RlLCAmYXR0YWNoLT5kbWFi dWYtPmF0dGFjaG1lbnRzKTsKPiAgCWlmICghc2dfdGFibGUpCj4gIAkJc2dfdGFibGUgPSBFUlJf UFRSKC1FTk9NRU0pOwo+ICAKPiBAQCAtNzUxLDYgKzc2NiwyNiBAQCB2b2lkIGRtYV9idWZfdW5t YXBfYXR0YWNobWVudChzdHJ1Y3QgZG1hX2J1Zl9hdHRhY2htZW50ICphdHRhY2gsCj4gIH0KPiAg RVhQT1JUX1NZTUJPTF9HUEwoZG1hX2J1Zl91bm1hcF9hdHRhY2htZW50KTsKPiAgCj4gKy8qKgo+ ICsgKiBkbWFfYnVmX2ludmFsaWRhdGVfbWFwcGluZ3MgLSBpbnZhbGlkYXRlIGFsbCBtYXBwaW5n cyBvZiB0aGlzIGRtYV9idWYKPiArICoKPiArICogQGRtYWJ1ZjoJW2luXQlidWZmZXIgd2hpY2gg bWFwcGluZ3Mgc2hvdWxkIGJlIGludmFsaWRhdGVkCj4gKyAqCj4gKyAqIEluZm9ybXMgYWxsIGF0 dGFjaG1lbnN0IHRoYXQgdGhleSBuZWVkIHRvIGRlc3Ryb3kgYW5kIHJlY3JlYXRlZCBhbGwgdGhl aXIKPiArICogbWFwcGluZ3MuCj4gKyAqLwo+ICt2b2lkIGRtYV9idWZfaW52YWxpZGF0ZV9tYXBw aW5ncyhzdHJ1Y3QgZG1hX2J1ZiAqZG1hYnVmKQo+ICt7Cj4gKwlzdHJ1Y3QgZG1hX2J1Zl9hdHRh Y2htZW50ICphdHRhY2g7Cj4gKwo+ICsJcmVzZXJ2YXRpb25fb2JqZWN0X2Fzc2VydF9oZWxkKGRt YWJ1Zi0+cmVzdik7Cj4gKwo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeShhdHRhY2gsICZkbWFidWYt PmF0dGFjaG1lbnRzLCBub2RlKQo+ICsJCWlmIChhdHRhY2gtPmludmFsaWRhdGUpCj4gKwkJCWF0 dGFjaC0+aW52YWxpZGF0ZShhdHRhY2gpOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0xfR1BMKGRtYV9i dWZfaW52YWxpZGF0ZV9tYXBwaW5ncyk7Cj4gKwo+ICAvKioKPiAgICogRE9DOiBjcHUgYWNjZXNz Cj4gICAqCj4gQEAgLTExNjMsMTAgKzExOTgsMTIgQEAgc3RhdGljIGludCBkbWFfYnVmX2RlYnVn X3Nob3coc3RydWN0IHNlcV9maWxlICpzLCB2b2lkICp1bnVzZWQpCj4gIAkJc2VxX3B1dHMocywg Ilx0QXR0YWNoZWQgRGV2aWNlczpcbiIpOwo+ICAJCWF0dGFjaF9jb3VudCA9IDA7Cj4gIAo+ICsJ CXJlc2VydmF0aW9uX29iamVjdF9sb2NrKGJ1Zl9vYmotPnJlc3YsIE5VTEwpOwo+ICAJCWxpc3Rf Zm9yX2VhY2hfZW50cnkoYXR0YWNoX29iaiwgJmJ1Zl9vYmotPmF0dGFjaG1lbnRzLCBub2RlKSB7 Cj4gIAkJCXNlcV9wcmludGYocywgIlx0JXNcbiIsIGRldl9uYW1lKGF0dGFjaF9vYmotPmRldikp Owo+ICAJCQlhdHRhY2hfY291bnQrKzsKPiAgCQl9Cj4gKwkJcmVzZXJ2YXRpb25fb2JqZWN0X3Vu bG9jayhidWZfb2JqLT5yZXN2KTsKPiAgCj4gIAkJc2VxX3ByaW50ZihzLCAiVG90YWwgJWQgZGV2 aWNlcyBhdHRhY2hlZFxuXG4iLAo+ICAJCQkJYXR0YWNoX2NvdW50KTsKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9saW51eC9kbWEtYnVmLmggYi9pbmNsdWRlL2xpbnV4L2RtYS1idWYuaAo+IGluZGV4 IDdlMjM3NThkYjNhNC4uZWNlNDYzODM1OWE4IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgv ZG1hLWJ1Zi5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9kbWEtYnVmLmgKPiBAQCAtMzI0LDYgKzMy NCw3IEBAIHN0cnVjdCBkbWFfYnVmIHsKPiAgICogQGRldjogZGV2aWNlIGF0dGFjaGVkIHRvIHRo ZSBidWZmZXIuCj4gICAqIEBub2RlOiBsaXN0IG9mIGRtYV9idWZfYXR0YWNobWVudC4KPiAgICog QHByaXY6IGV4cG9ydGVyIHNwZWNpZmljIGF0dGFjaG1lbnQgZGF0YS4KPiArICogQGltcG9ydGVy X3ByaXY6IGltcG9ydGVyIHNwZWNpZmljIGF0dGFjaG1lbnQgZGF0YS4KPiAgICoKPiAgICogVGhp cyBzdHJ1Y3R1cmUgaG9sZHMgdGhlIGF0dGFjaG1lbnQgaW5mb3JtYXRpb24gYmV0d2VlbiB0aGUg ZG1hX2J1ZiBidWZmZXIKPiAgICogYW5kIGl0cyB1c2VyIGRldmljZShzKS4gVGhlIGxpc3QgY29u dGFpbnMgb25lIGF0dGFjaG1lbnQgc3RydWN0IHBlciBkZXZpY2UKPiBAQCAtMzQwLDYgKzM0MSwy OSBAQCBzdHJ1Y3QgZG1hX2J1Zl9hdHRhY2htZW50IHsKPiAgCXN0cnVjdCBsaXN0X2hlYWQgbm9k ZTsKPiAgCXZvaWQgKnByaXY7Cj4gIAlzdHJ1Y3Qgc2dfdGFibGUgKnNndDsKPiArCXZvaWQgKmlt cG9ydGVyX3ByaXY7Cj4gKwo+ICsJLyoqCj4gKwkgKiBAaW52YWxpZGF0ZToKPiArCSAqCj4gKwkg KiBPcHRpb25hbCBjYWxsYmFjayBwcm92aWRlZCBieSB0aGUgaW1wb3J0ZXIgb2YgdGhlIGRtYS1i dWYuCj4gKwkgKgo+ICsJICogSWYgcHJvdmlkZWQgdGhlIGV4cG9ydGVyIGNhbiBhdm9pZCBwaW5u aW5nIHRoZSBiYWNraW5nIHN0b3JlIHdoaWxlCj4gKwkgKiBtYXBwaW5ncyBleGlzdHMuCj4gKwkg Kgo+ICsJICogVGhlIGZ1bmN0aW9uIGlzIGNhbGxlZCB3aXRoIHRoZSBsb2NrIG9mIHRoZSByZXNl cnZhdGlvbiBvYmplY3QKPiArCSAqIGFzc29jaWF0ZWQgd2l0aCB0aGUgZG1hX2J1ZiBoZWxkIGFu ZCB0aGUgbWFwcGluZyBmdW5jdGlvbiBtdXN0IGJlCj4gKwkgKiBjYWxsZWQgd2l0aCB0aGlzIGxv Y2sgaGVsZCBhcyB3ZWxsLiBUaGlzIG1ha2VzIHN1cmUgdGhhdCBubyBtYXBwaW5nCj4gKwkgKiBp cyBjcmVhdGVkIGNvbmN1cnJlbnRseSB3aXRoIGFuIG9uZ29pbmcgaW52YWxpZGF0aW9uLgo+ICsJ ICoKPiArCSAqIEFmdGVyIHRoZSBjYWxsYmFjayBhbGwgZXhpc3RpbmcgbWFwcGluZ3MgYXJlIHN0 aWxsIHZhbGlkIHVudGlsIGFsbAo+ICsJICogZmVuY2VzIGluIHRoZSBkbWFfYnVmcyByZXNlcnZh dGlvbiBvYmplY3QgYXJlIHNpZ25hbGVkLCBidXQgc2hvdWxkIGJlCj4gKwkgKiBkZXN0cm95ZWQg YnkgdGhlIGltcG9ydGVyIGFzIHNvb24gYXMgcG9zc2libGUuCj4gKwkgKgo+ICsJICogTmV3IG1h cHBpbmdzIGNhbiBiZSBjcmVhdGVkIGltbWVkaWF0ZWx5LCBidXQgY2FuJ3QgYmUgdXNlZCBiZWZv cmUgdGhlCj4gKwkgKiBleGNsdXNpdmUgZmVuY2UgaW4gdGhlIGRtYV9idWZzIHJlc2VydmF0aW9u IG9iamVjdCBpcyBzaWduYWxlZC4KPiArCSAqLwo+ICsJdm9pZCAoKmludmFsaWRhdGUpKHN0cnVj dCBkbWFfYnVmX2F0dGFjaG1lbnQgKmF0dGFjaCk7CgpJIHdvdWxkIHB1dCB0aGUgbG9uZyBrZXJu ZWxkb2MgaW50byBkbWFfYnVmX2F0dGFjaF9pbmZvIChhcyBhbiBpbmxpbmUKY29tbWVudCwgeW91 IGNhbiBtaXggdGhlIHN0eWxlcykuIEFuZCByZWZlcmVuY2UgaXQgZnJvbSBoZXJlIHdpdGgKc29t ZXRoaW5nIGxpa2UKCiJTZXQgZnJvbSAmZG1hX2J1Zl9hdHRhY2hfaW5mby5pbnZhbGlkYXRlIGlu IGRtYV9idWZfYXR0YWNoKCksIHNlZSB0aGVyZQpmb3IgbW9yZSBpbmZvcm1hdGlvbi4iCgpUaGlz IGhlcmUgZmVlbHMgYSBiaXQgdG9vIG11Y2ggaGlkZGVuLgotRGFuaWVsCgo+ICB9Owo+ICAKPiAg LyoqCj4gQEAgLTM3OCw4ICs0MDIsMTAgQEAgc3RydWN0IGRtYV9idWZfZXhwb3J0X2luZm8gewo+ ICAKPiAgLyoqCj4gICAqIHN0cnVjdCBkbWFfYnVmX2F0dGFjaF9pbmZvIC0gaG9sZHMgaW5mb3Jt YXRpb24gbmVlZGVkIHRvIGF0dGFjaCB0byBhIGRtYV9idWYKPiAtICogQGRtYWJ1ZjoJdGhlIGV4 cG9ydGVkIGRtYV9idWYKPiAtICogQGRldjoJdGhlIGRldmljZSB3aGljaCB3YW50cyB0byBpbXBv cnQgdGhlIGF0dGFjaG1lbnQKPiArICogQGRtYWJ1ZjoJCXRoZSBleHBvcnRlZCBkbWFfYnVmCj4g KyAqIEBkZXY6CQl0aGUgZGV2aWNlIHdoaWNoIHdhbnRzIHRvIGltcG9ydCB0aGUgYXR0YWNobWVu dAo+ICsgKiBAaW1wb3J0ZXJfcHJpdjoJcHJpdmF0ZSBkYXRhIG9mIGltcG9ydGVyIHRvIHRoaXMg YXR0YWNobWVudAo+ICsgKiBAaW52YWxpZGF0ZToJCWNhbGxiYWNrIHRvIHVzZSBmb3IgaW52YWxp ZGF0aW5nIG1hcHBpbmdzCj4gICAqCj4gICAqIFRoaXMgc3RydWN0dXJlIGhvbGRzIHRoZSBpbmZv cm1hdGlvbiByZXF1aXJlZCB0byBhdHRhY2ggdG8gYSBidWZmZXIuIFVzZWQKPiAgICogd2l0aCBk bWFfYnVmX2F0dGFjaCgpIG9ubHkuCj4gQEAgLTM4Nyw2ICs0MTMsOCBAQCBzdHJ1Y3QgZG1hX2J1 Zl9leHBvcnRfaW5mbyB7Cj4gIHN0cnVjdCBkbWFfYnVmX2F0dGFjaF9pbmZvIHsKPiAgCXN0cnVj dCBkbWFfYnVmICpkbWFidWY7Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gKwl2b2lkICppbXBv cnRlcl9wcml2Owo+ICsJdm9pZCAoKmludmFsaWRhdGUpKHN0cnVjdCBkbWFfYnVmX2F0dGFjaG1l bnQgKmF0dGFjaCk7Cj4gIH07Cj4gIAo+ICAvKioKPiBAQCAtNDIzLDYgKzQ1MSw3IEBAIHZvaWQg ZG1hX2J1Zl91bm1hcF9hdHRhY2htZW50X2xvY2tlZChzdHJ1Y3QgZG1hX2J1Zl9hdHRhY2htZW50 ICosCj4gIAkJCQkgICAgIGVudW0gZG1hX2RhdGFfZGlyZWN0aW9uKTsKPiAgdm9pZCBkbWFfYnVm X3VubWFwX2F0dGFjaG1lbnQoc3RydWN0IGRtYV9idWZfYXR0YWNobWVudCAqLCBzdHJ1Y3Qgc2df dGFibGUgKiwKPiAgCQkJCWVudW0gZG1hX2RhdGFfZGlyZWN0aW9uKTsKPiArdm9pZCBkbWFfYnVm X2ludmFsaWRhdGVfbWFwcGluZ3Moc3RydWN0IGRtYV9idWYgKmRtYV9idWYpOwo+ICBpbnQgZG1h X2J1Zl9iZWdpbl9jcHVfYWNjZXNzKHN0cnVjdCBkbWFfYnVmICpkbWFfYnVmLAo+ICAJCQkgICAg IGVudW0gZG1hX2RhdGFfZGlyZWN0aW9uIGRpcik7Cj4gIGludCBkbWFfYnVmX2VuZF9jcHVfYWNj ZXNzKHN0cnVjdCBkbWFfYnVmICpkbWFfYnVmLAo+IC0tIAo+IDIuMTcuMQo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFt ZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF63C282DC for ; Wed, 17 Apr 2019 14:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD68F206BA for ; Wed, 17 Apr 2019 14:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="gA0HxHD1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732233AbfDQOBW (ORCPT ); Wed, 17 Apr 2019 10:01:22 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:37199 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729453AbfDQOBW (ORCPT ); Wed, 17 Apr 2019 10:01:22 -0400 Received: by mail-ed1-f65.google.com with SMTP id f53so19512538ede.4 for ; Wed, 17 Apr 2019 07:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=/smunqBLQ0csGAXClwGfq8DJlpLhcvVohm+B2YKcrI0=; b=gA0HxHD1qS0oqf+zsC2W3LQukKoxPXH/xStVtjCTtF1VF7yZ+Y20r1SGJUyu4ZceB9 4Tu0J71uZhpO7JfYrLf4nHn+qGAyBfKPVC7j9JqRgJ0Qfa11wH5sfu0WoDtXGb/G1Eqt PBw/WtoYxZ4jwq7Bs2tUbEoGGrIbEgjSyWfQ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=/smunqBLQ0csGAXClwGfq8DJlpLhcvVohm+B2YKcrI0=; b=bmZwidQ8ycQ/2u5KVHWLnzue7P1qgFvvedh0ayabeTl8MCRGhzWDAQ7eqcU8+xwbVW 8/bxiuyeaJV3udEMkahkUJBB65HYu2nQYH4oYFweoEQ1EB2TzglrvBQ2pvBP5kAbcVQL Xc7p9OmXcEaw4lN19bzUf2OJErNcirswqs29lGwNd+MdhbeWB/d6oaMsgH9Bq6BMtDmN AP1XEjGU5NgSUGZjCgmgoepgQYT1p1766iSul69loszbyFZ990ppJba4zncyVpJ+9Qkl lb0XraX0vUfX6QbFSkqPzBtv46uZ9LLr6NJdSLb9P56RVK0Yez/kJK+3gmB1OhT/Yfa7 bfzQ== X-Gm-Message-State: APjAAAVB9ZdrTdJEcYdD6sZHgcOH6oCzsUD9zBIoo8gjuiIDGldLlNP1 /cJT0Q/cgU92mVuBcDiBmgDoYA== X-Google-Smtp-Source: APXvYqyUtxthgWZ2Ou0isBvItccPs8doGGmyutUvcJydStu1oQS1FiPx5j5Nf8QSTLsOJFQfVkfMjA== X-Received: by 2002:a17:906:b202:: with SMTP id p2mr47831080ejz.266.1555509679679; Wed, 17 Apr 2019 07:01:19 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id s44sm13626378edd.49.2019.04.17.07.01.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 07:01:18 -0700 (PDT) Date: Wed, 17 Apr 2019 16:01:16 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: sumit.semwal@linaro.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 04/12] dma-buf: add optional invalidate_mappings callback v5 Message-ID: <20190417140116.GC13337@phenom.ffwll.local> Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= , sumit.semwal@linaro.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org References: <20190416183841.1577-1-christian.koenig@amd.com> <20190416183841.1577-5-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190416183841.1577-5-christian.koenig@amd.com> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Apr 16, 2019 at 08:38:33PM +0200, Christian König wrote: > Each importer can now provide an invalidate_mappings callback. > > This allows the exporter to provide the mappings without the need to pin > the backing store. > > v2: don't try to invalidate mappings when the callback is NULL, > lock the reservation obj while using the attachments, > add helper to set the callback > v3: move flag for invalidation support into the DMA-buf, > use new attach_info structure to set the callback > v4: use importer_priv field instead of mangling exporter priv. > v5: drop invalidation_supported flag > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-buf.c | 37 +++++++++++++++++++++++++++++++++++++ > include/linux/dma-buf.h | 33 +++++++++++++++++++++++++++++++-- > 2 files changed, 68 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 83c92bfd964c..a3738fab3927 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -563,6 +563,8 @@ struct dma_buf_attachment *dma_buf_attach(const struct dma_buf_attach_info *info > > attach->dev = info->dev; > attach->dmabuf = dmabuf; > + attach->importer_priv = info->importer_priv; > + attach->invalidate = info->invalidate; > > mutex_lock(&dmabuf->lock); > > @@ -571,7 +573,9 @@ struct dma_buf_attachment *dma_buf_attach(const struct dma_buf_attach_info *info > if (ret) > goto err_attach; > } > + reservation_object_lock(dmabuf->resv, NULL); > list_add(&attach->node, &dmabuf->attachments); > + reservation_object_unlock(dmabuf->resv); > > mutex_unlock(&dmabuf->lock); > > @@ -615,7 +619,9 @@ void dma_buf_detach(struct dma_buf *dmabuf, struct dma_buf_attachment *attach) > DMA_BIDIRECTIONAL); > > mutex_lock(&dmabuf->lock); > + reservation_object_lock(dmabuf->resv, NULL); > list_del(&attach->node); > + reservation_object_unlock(dmabuf->resv); > if (dmabuf->ops->detach) > dmabuf->ops->detach(dmabuf, attach); > > @@ -653,7 +659,16 @@ dma_buf_map_attachment_locked(struct dma_buf_attachment *attach, > if (attach->sgt) > return attach->sgt; > > + /* > + * Mapping a DMA-buf can trigger its invalidation, prevent sending this > + * event to the caller by temporary removing this attachment from the > + * list. > + */ > + if (attach->invalidate) > + list_del(&attach->node); > sg_table = attach->dmabuf->ops->map_dma_buf(attach, direction); > + if (attach->invalidate) > + list_add(&attach->node, &attach->dmabuf->attachments); > if (!sg_table) > sg_table = ERR_PTR(-ENOMEM); > > @@ -751,6 +766,26 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment *attach, > } > EXPORT_SYMBOL_GPL(dma_buf_unmap_attachment); > > +/** > + * dma_buf_invalidate_mappings - invalidate all mappings of this dma_buf > + * > + * @dmabuf: [in] buffer which mappings should be invalidated > + * > + * Informs all attachmenst that they need to destroy and recreated all their > + * mappings. > + */ > +void dma_buf_invalidate_mappings(struct dma_buf *dmabuf) > +{ > + struct dma_buf_attachment *attach; > + > + reservation_object_assert_held(dmabuf->resv); > + > + list_for_each_entry(attach, &dmabuf->attachments, node) > + if (attach->invalidate) > + attach->invalidate(attach); > +} > +EXPORT_SYMBOL_GPL(dma_buf_invalidate_mappings); > + > /** > * DOC: cpu access > * > @@ -1163,10 +1198,12 @@ static int dma_buf_debug_show(struct seq_file *s, void *unused) > seq_puts(s, "\tAttached Devices:\n"); > attach_count = 0; > > + reservation_object_lock(buf_obj->resv, NULL); > list_for_each_entry(attach_obj, &buf_obj->attachments, node) { > seq_printf(s, "\t%s\n", dev_name(attach_obj->dev)); > attach_count++; > } > + reservation_object_unlock(buf_obj->resv); > > seq_printf(s, "Total %d devices attached\n\n", > attach_count); > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 7e23758db3a4..ece4638359a8 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -324,6 +324,7 @@ struct dma_buf { > * @dev: device attached to the buffer. > * @node: list of dma_buf_attachment. > * @priv: exporter specific attachment data. > + * @importer_priv: importer specific attachment data. > * > * This structure holds the attachment information between the dma_buf buffer > * and its user device(s). The list contains one attachment struct per device > @@ -340,6 +341,29 @@ struct dma_buf_attachment { > struct list_head node; > void *priv; > struct sg_table *sgt; > + void *importer_priv; > + > + /** > + * @invalidate: > + * > + * Optional callback provided by the importer of the dma-buf. > + * > + * If provided the exporter can avoid pinning the backing store while > + * mappings exists. > + * > + * The function is called with the lock of the reservation object > + * associated with the dma_buf held and the mapping function must be > + * called with this lock held as well. This makes sure that no mapping > + * is created concurrently with an ongoing invalidation. > + * > + * After the callback all existing mappings are still valid until all > + * fences in the dma_bufs reservation object are signaled, but should be > + * destroyed by the importer as soon as possible. > + * > + * New mappings can be created immediately, but can't be used before the > + * exclusive fence in the dma_bufs reservation object is signaled. > + */ > + void (*invalidate)(struct dma_buf_attachment *attach); I would put the long kerneldoc into dma_buf_attach_info (as an inline comment, you can mix the styles). And reference it from here with something like "Set from &dma_buf_attach_info.invalidate in dma_buf_attach(), see there for more information." This here feels a bit too much hidden. -Daniel > }; > > /** > @@ -378,8 +402,10 @@ struct dma_buf_export_info { > > /** > * struct dma_buf_attach_info - holds information needed to attach to a dma_buf > - * @dmabuf: the exported dma_buf > - * @dev: the device which wants to import the attachment > + * @dmabuf: the exported dma_buf > + * @dev: the device which wants to import the attachment > + * @importer_priv: private data of importer to this attachment > + * @invalidate: callback to use for invalidating mappings > * > * This structure holds the information required to attach to a buffer. Used > * with dma_buf_attach() only. > @@ -387,6 +413,8 @@ struct dma_buf_export_info { > struct dma_buf_attach_info { > struct dma_buf *dmabuf; > struct device *dev; > + void *importer_priv; > + void (*invalidate)(struct dma_buf_attachment *attach); > }; > > /** > @@ -423,6 +451,7 @@ void dma_buf_unmap_attachment_locked(struct dma_buf_attachment *, > enum dma_data_direction); > void dma_buf_unmap_attachment(struct dma_buf_attachment *, struct sg_table *, > enum dma_data_direction); > +void dma_buf_invalidate_mappings(struct dma_buf *dma_buf); > int dma_buf_begin_cpu_access(struct dma_buf *dma_buf, > enum dma_data_direction dir); > int dma_buf_end_cpu_access(struct dma_buf *dma_buf, > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch