From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
jannh@google.com, dhowells@redhat.com, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, serge@hallyn.com, luto@kernel.org,
arnd@arndb.de, ebiederm@xmission.com, keescook@chromium.org,
tglx@linutronix.de, mtk.manpages@gmail.com,
akpm@linux-foundation.org, cyphar@cyphar.com,
joel@joelfernandes.org, dancol@google.com
Subject: Re: [PATCH v1 2/4] clone: add CLONE_PIDFD
Date: Wed, 17 Apr 2019 16:22:54 +0200 [thread overview]
Message-ID: <20190417142253.GH32622@redhat.com> (raw)
In-Reply-To: <20190416170233.10208-3-christian@brauner.io>
On 04/16, Christian Brauner wrote:
>
> + if (clone_flags & CLONE_PIDFD) {
> + retval = pidfd_create(pid, &pidfdf);
> + if (retval < 0)
> + goto bad_fork_free_pid;
> + pidfd = retval;
> + }
...
> + if (clone_flags & CLONE_PIDFD) {
> + fd_install(pidfd, pidfdf);
> + put_user(pidfd, parent_tidptr);
put_user() can fail, I don't think this error should be silently ignored,
this can lead to the hard-to-trigger/debug problems.
Why can't we do put_user-with-check along with pidfd_create() above?
Oleg.
next prev parent reply other threads:[~2019-04-17 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 17:02 [PATCH v1 0/4] clone: add CLONE_PIDFD Christian Brauner
2019-04-16 17:02 ` [PATCH v1 1/4] Make anon_inodes unconditional Christian Brauner
2019-04-16 17:02 ` [PATCH v1 2/4] clone: add CLONE_PIDFD Christian Brauner
2019-04-17 14:22 ` Oleg Nesterov [this message]
2019-04-17 14:25 ` Christian Brauner
2019-04-17 14:28 ` Christian Brauner
2019-04-18 9:36 ` Christian Brauner
2019-04-16 17:02 ` [PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal Christian Brauner
2019-04-17 14:01 ` Oleg Nesterov
2019-04-17 14:11 ` Christian Brauner
2019-04-17 15:20 ` Oleg Nesterov
2019-04-17 15:36 ` Christian Brauner
2019-04-16 17:02 ` [PATCH v1 4/4] samples: show race-free pidfd metadata access Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417142253.GH32622@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dancol@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.