From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8960EC282DA for ; Wed, 17 Apr 2019 20:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4127A217D7 for ; Wed, 17 Apr 2019 20:14:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="P2xDDnQl"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="HuMrxM8g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729251AbfDQUOn (ORCPT ); Wed, 17 Apr 2019 16:14:43 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43039 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfDQUOn (ORCPT ); Wed, 17 Apr 2019 16:14:43 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2912B21B0E; Wed, 17 Apr 2019 16:14:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 17 Apr 2019 16:14:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=cCYhlHZYLvGV5L0EcMA0IYQQYc4 z1x1VTMQCHdErcEI=; b=P2xDDnQlbXS2H1JjRHzljOGC3yZ/dLaCG1fmGV72Bvp cO1GM1dM/wrwypbu5vu1isIcG3v7NrSerTLRuspgQY2FmTvM0gVubVX4gmkqC3ZY jFgUFIBVPPtOOWgJDfS2fpyZUZwZtropnmOwtSWAgVOnzNdzcInIiRAFqXkFghtF Itjn9EYYoH5MZd0Liq8Wt7mmgpTYzNo4As7YxHuDfToqss+6Zbe9tYHagd7hVcOU 9bs/1UXch29uWK7nRFSFh8jsu0es4wFdcN4m9kAZK94QmjqafYht9zdIRdYWbdLA DeUyvvYrce0fU6K+ulUTCSpLGdbV+O3/oWHrMBU+peQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=cCYhlH ZYLvGV5L0EcMA0IYQQYc4z1x1VTMQCHdErcEI=; b=HuMrxM8g1tr0h5umtWiqW6 3B+0mueNEHOU73nPj95PA9QUiSeoiRS01cLEaBm30W6LtfsV1WMa8cJ9prUCUyMO Ub3wvdFyKt/JiCuNu8I9+SjTMiJm0fMDzC+PKGlACUMhAcP7lI/aKZe1/NKocV0P 8nYdGGRcb8oaJYiH6hAzvelU9p8gpkqYmAOqIuGgal+ewhq9ZqNWJgZhz9bMtJAx IsJ2fKYdpIP/Gp1AC/7+CHc1yrN0us2WmwxngtAjzlfZ7bfpFuQCjvzuibGCFySj QaJVBH/21VKetsLaMRWj0Ds8/bZnkeIoGozMvXTOUvgS/eYJejUV+rOpKnZc9pyw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekledrud dtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 1990CE4561; Wed, 17 Apr 2019 16:14:40 -0400 (EDT) Date: Wed, 17 Apr 2019 22:14:38 +0200 From: Greg KH To: Lars Persson Cc: stable@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, Lars Persson Subject: Re: [PATCH stable 4.14] net: stmmac: Set dma ring length before enabling the DMA Message-ID: <20190417201438.GA13639@kroah.com> References: <20190415074947.6144-1-larper@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190415074947.6144-1-larper@axis.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 15, 2019 at 09:49:47AM +0200, Lars Persson wrote: > This was fixed in upstream by commit 7d9e6c5afab6 ("net: stmmac: Integrate > XGMAC into main driver flow") that is a new feature commit. > > We found a race condition in the DMA init sequence that hits if the > PHY already has link up during stmmac_hw_setup. Since the ring length > was programmed after enabling the RX path, we might receive a packet > before the correct ring length is programmed. When that happened we > could not get reliable interrupts for DMA RX and the MTL complained > about RX FIFO overrun. > > Signed-off-by: Lars Persson > Cc: stable@vger.kernel.org # 4.14.x > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Cc: Jose Abreu > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) This, and the 4.9 patch now queued up, thanks. greg k-h