From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Wed, 17 Apr 2019 21:27:00 +0000 Subject: Re: [PATCH v3 14/26] compat_ioctl: move ATYFB_CLK handling to atyfb driver Message-Id: <20190417212700.GZ2217@ZenIV.linux.org.uk> List-Id: References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202701.127745-1-arnd@arndb.de> <20190416202701.127745-3-arnd@arndb.de> In-Reply-To: <20190416202701.127745-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Mikulas Patocka , "David S. Miller" , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org On Tue, Apr 16, 2019 at 10:25:35PM +0200, Arnd Bergmann wrote: > +static int atyfb_compat_ioctl(struct fb_info *info, u_int cmd, u_long arg) > +{ > + return atyfb_ioctl(info, cmd, (u_long)compat_ptr(arg)); > +} > +#endif Huh? Why isn't that using compat_ioctl_ptr()? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v3 14/26] compat_ioctl: move ATYFB_CLK handling to atyfb driver Date: Wed, 17 Apr 2019 22:27:00 +0100 Message-ID: <20190417212700.GZ2217@ZenIV.linux.org.uk> References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202701.127745-1-arnd@arndb.de> <20190416202701.127745-3-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190416202701.127745-3-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Mikulas Patocka , "David S. Miller" , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, Apr 16, 2019 at 10:25:35PM +0200, Arnd Bergmann wrote: > +static int atyfb_compat_ioctl(struct fb_info *info, u_int cmd, u_long arg) > +{ > + return atyfb_ioctl(info, cmd, (u_long)compat_ptr(arg)); > +} > +#endif Huh? Why isn't that using compat_ioctl_ptr()?