From mboxrd@z Thu Jan 1 00:00:00 1970 From: Douglas Anderson Subject: [PATCH v2 5/5] ARM: dts: rockchip: Allow wakeup from rk3288-veyron's dwc2 USB ports Date: Wed, 17 Apr 2019 17:13:56 -0700 Message-ID: <20190418001356.124334-6-dianders@chromium.org> References: <20190418001356.124334-1-dianders@chromium.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190418001356.124334-1-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Minas Harutyunyan , Felipe Balbi , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org We want to be able to wake from USB if a device is plugged in that wants remote wakeup. Enable it on both dwc2 controllers. NOTE: this is added specifically to veyron and not to rk3288 in general since it's not known whether all rk3288 boards are designed to support USB wakeup. It is plausible that some boards could shut down important rails in S3. Also note that currently wakeup doesn't seem to happen unless you use the "deep" suspend mode (where SDRAM is turned off). Presumably the shallow suspend mode is gating some sort of clock that's important but I couldn't easily figure out how to get it working. Signed-off-by: Douglas Anderson --- Changes in v2: - rk3288-veyron dts patch new for v2. arch/arm/boot/dts/rk3288-veyron.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 1252522392c7..1d8bfed7830c 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -424,6 +424,7 @@ &usb_host1 { status = "okay"; + snps,need-phy-for-wake; }; &usb_otg { @@ -432,6 +433,7 @@ assigned-clocks = <&cru SCLK_USBPHY480M_SRC>; assigned-clock-parents = <&usbphy0>; dr_mode = "host"; + snps,need-phy-for-wake; }; &vopb { -- 2.21.0.593.g511ec345e18-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,5/5] ARM: dts: rockchip: Allow wakeup from rk3288-veyron's dwc2 USB ports From: Doug Anderson Message-Id: <20190418001356.124334-6-dianders@chromium.org> Date: Wed, 17 Apr 2019 17:13:56 -0700 To: Minas Harutyunyan , Felipe Balbi , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org List-ID: V2Ugd2FudCB0byBiZSBhYmxlIHRvIHdha2UgZnJvbSBVU0IgaWYgYSBkZXZpY2UgaXMgcGx1Z2dl ZCBpbiB0aGF0CndhbnRzIHJlbW90ZSB3YWtldXAuICBFbmFibGUgaXQgb24gYm90aCBkd2MyIGNv bnRyb2xsZXJzLgoKTk9URTogdGhpcyBpcyBhZGRlZCBzcGVjaWZpY2FsbHkgdG8gdmV5cm9uIGFu ZCBub3QgdG8gcmszMjg4IGluCmdlbmVyYWwgc2luY2UgaXQncyBub3Qga25vd24gd2hldGhlciBh bGwgcmszMjg4IGJvYXJkcyBhcmUgZGVzaWduZWQgdG8Kc3VwcG9ydCBVU0Igd2FrZXVwLiAgSXQg aXMgcGxhdXNpYmxlIHRoYXQgc29tZSBib2FyZHMgY291bGQgc2h1dCBkb3duCmltcG9ydGFudCBy YWlscyBpbiBTMy4KCkFsc28gbm90ZSB0aGF0IGN1cnJlbnRseSB3YWtldXAgZG9lc24ndCBzZWVt IHRvIGhhcHBlbiB1bmxlc3MgeW91IHVzZQp0aGUgImRlZXAiIHN1c3BlbmQgbW9kZSAod2hlcmUg U0RSQU0gaXMgdHVybmVkIG9mZikuICBQcmVzdW1hYmx5IHRoZQpzaGFsbG93IHN1c3BlbmQgbW9k ZSBpcyBnYXRpbmcgc29tZSBzb3J0IG9mIGNsb2NrIHRoYXQncyBpbXBvcnRhbnQgYnV0CkkgY291 bGRuJ3QgZWFzaWx5IGZpZ3VyZSBvdXQgaG93IHRvIGdldCBpdCB3b3JraW5nLgoKU2lnbmVkLW9m Zi1ieTogRG91Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgotLS0KCkNoYW5n ZXMgaW4gdjI6Ci0gcmszMjg4LXZleXJvbiBkdHMgcGF0Y2ggbmV3IGZvciB2Mi4KCiBhcmNoL2Fy bS9ib290L2R0cy9yazMyODgtdmV5cm9uLmR0c2kgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LXZleXJv bi5kdHNpIGIvYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LXZleXJvbi5kdHNpCmluZGV4IDEyNTI1 MjIzOTJjNy4uMWQ4YmZlZDc4MzBjIDEwMDY0NAotLS0gYS9hcmNoL2FybS9ib290L2R0cy9yazMy ODgtdmV5cm9uLmR0c2kKKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LXZleXJvbi5kdHNp CkBAIC00MjQsNiArNDI0LDcgQEAKIAogJnVzYl9ob3N0MSB7CiAJc3RhdHVzID0gIm9rYXkiOwor CXNucHMsbmVlZC1waHktZm9yLXdha2U7CiB9OwogCiAmdXNiX290ZyB7CkBAIC00MzIsNiArNDMz LDcgQEAKIAlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX1VTQlBIWTQ4ME1fU1JDPjsKIAlh c3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZ1c2JwaHkwPjsKIAlkcl9tb2RlID0gImhvc3QiOwor CXNucHMsbmVlZC1waHktZm9yLXdha2U7CiB9OwogCiAmdm9wYiB7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D768C282DA for ; Thu, 18 Apr 2019 00:15:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ED202184B for ; Thu, 18 Apr 2019 00:15:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ok08HtCa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g+JqrgM6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ED202184B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QyPq0Y+g7WoP4jj0OWpM8kxMau3vT8gjrXCpYk1SL2Y=; b=ok08HtCa3xr6b/ kHsab/+PTDc1w1qNcN+LzGyBgxtZmjrc3qphPQf7l/w+1s9oLXPuOxmtGkpYjGStz4fOsYrwDLapi CaV6wCqTSL4IUTO9ScYBFY71ju5fR3E7f7xDQSwy8LtIv/2azQFHez05/KbNN1WTYowF6YRNW/Bu0 U3oveHQtZjKGIsciBqRry9130B0vAXuHyFh6U50nv33JT1vxTDD2X3jpZHvafO4SQd2P9mfxlGJ6P F3cD73gi363Y8qESlmYziYqoa/5w2KJMnMVDNW6yKuoTbtgCdueqAezNl30n2OXTRcWt4S2Eq5GoP L3pPjf2RnC+PJ9+QTcDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGuiA-0000Su-GO; Thu, 18 Apr 2019 00:15:30 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGuhm-0007WJ-Fo for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 00:15:10 +0000 Received: by mail-pl1-x643.google.com with SMTP id d1so260570plj.8 for ; Wed, 17 Apr 2019 17:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9dHCbPnlI9BSQxis0+totmB/WamSdFGOvfhVYVfhROQ=; b=g+JqrgM6CtbjdujZ4bhx4uBddKF+4SRVyOciP5srObjxxh8KDMl19YmZbkZRq9D6ro /oQuSYOpqFTsQE5PzmeCMGPnnB5FLYBf00CWcGLWBi2Ml0xUlmRHTB/JAtskaKWlNo5g dQmAwOypdXgrccYfyYUTb/Z2JAOT2ZOBU3IHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9dHCbPnlI9BSQxis0+totmB/WamSdFGOvfhVYVfhROQ=; b=IH+dXRXPHdvIsrzO+FCNd6s1vvegYmwc85iT4oSBZVFsNJjYciz4PEElQ3xHDHGgY0 tiGLFTtC4CNf2AUlgEknF/UUAFTYv9B+iMo8kGtU6JFho1N0QG08JBKZvvJGVUJ+X58K plDJgIY7GextHecYe64qnRLY8Rys8lreexbcq7PA9Saq4HXQdlpdb1cxTiRXZc9qRqpZ uF1PRBo4TNppRrtJJAxgdJBwS69hAunOqrfmoz5H7rXxnOuGggBvNHNcpDJA1HAAuRa+ +uOCAj8ZevyrlIsZOjw33yjh7lbtYMGdk+976/crOQ07u0h/nJo6VGxema0xEOAncA7Y hDpQ== X-Gm-Message-State: APjAAAVlsfBNNdFV7KDEE2dqYGyCvE02AbmO64I15NZu+AgsPrIU3NYb Hda47cB7CecpG6OXtquMeoB+TA== X-Google-Smtp-Source: APXvYqxWk5e1kbmfttQMLubOoAO7jJexKAOokKqYIE8CqxPpp93l2fjdF31N53x3ArHo1fS2mksl/Q== X-Received: by 2002:a17:902:2aeb:: with SMTP id j98mr25482240plb.38.1555546503259; Wed, 17 Apr 2019 17:15:03 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id q5sm447668pff.97.2019.04.17.17.15.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 17:15:02 -0700 (PDT) From: Douglas Anderson To: Minas Harutyunyan , Felipe Balbi , heiko@sntech.de Subject: [PATCH v2 5/5] ARM: dts: rockchip: Allow wakeup from rk3288-veyron's dwc2 USB ports Date: Wed, 17 Apr 2019 17:13:56 -0700 Message-Id: <20190418001356.124334-6-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.593.g511ec345e18-goog In-Reply-To: <20190418001356.124334-1-dianders@chromium.org> References: <20190418001356.124334-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_171506_650603_65E86998 X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Artur Petrosyan , Amelie Delaunay , Randy Li , amstan@chromium.org, devicetree@vger.kernel.org, zyw@rock-chips.com, linux-usb@vger.kernel.org, Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, Alan Stern , Mark Rutland , Elaine Zhang , jwerner@chromium.org, William Wu , ryandcase@chromium.org, dinguyen@opensource.altera.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org We want to be able to wake from USB if a device is plugged in that wants remote wakeup. Enable it on both dwc2 controllers. NOTE: this is added specifically to veyron and not to rk3288 in general since it's not known whether all rk3288 boards are designed to support USB wakeup. It is plausible that some boards could shut down important rails in S3. Also note that currently wakeup doesn't seem to happen unless you use the "deep" suspend mode (where SDRAM is turned off). Presumably the shallow suspend mode is gating some sort of clock that's important but I couldn't easily figure out how to get it working. Signed-off-by: Douglas Anderson --- Changes in v2: - rk3288-veyron dts patch new for v2. arch/arm/boot/dts/rk3288-veyron.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 1252522392c7..1d8bfed7830c 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -424,6 +424,7 @@ &usb_host1 { status = "okay"; + snps,need-phy-for-wake; }; &usb_otg { @@ -432,6 +433,7 @@ assigned-clocks = <&cru SCLK_USBPHY480M_SRC>; assigned-clock-parents = <&usbphy0>; dr_mode = "host"; + snps,need-phy-for-wake; }; &vopb { -- 2.21.0.593.g511ec345e18-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel