From: Mark Brown <broonie@kernel.org>
To: Eric Jeong <eric.jeong.opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
DEVICETREE <devicetree@vger.kernel.org>,
LINUX-KERNEL <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH V2 3/3] regulator: slg51000: add slg51000 regulator driver
Date: Thu, 18 Apr 2019 11:16:06 +0100 [thread overview]
Message-ID: <20190418101606.GC6702@sirena.org.uk> (raw)
In-Reply-To: <2e7559c6ad3fdc3c3b99690ebd7dbb4e35c0d184.1555567784.git.eric.jeong.opensource@diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
On Thu, Apr 18, 2019 at 03:09:44PM +0900, Eric Jeong wrote:
> I updated regulator_ops structure to use use the helper function
> which is regulator_is_enabled_regmap() instead reading status bits
> for is_enabled() operation.
> v2: use regulator helper function for is_enabled()
There's also the get_status() operation which you should be able to
implement using the status bits you were reading before - that lets
the framework know if the regualtor is actually working which can help
with error handling so it's good to do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-18 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 6:09 [PATCH V2 0/3] slg51000: regulator driver submission Eric Jeong
2019-04-18 6:09 ` [PATCH V2 1/3] MAINTAINERS: slg51000 updates to the Dialog Semiconductor search terms Eric Jeong
2019-04-18 10:26 ` Applied "MAINTAINERS: slg51000 updates to the Dialog Semiconductor search terms" to the regulator tree Mark Brown
2019-04-18 10:26 ` Mark Brown
2019-04-18 6:09 ` [PATCH V2 2/3] dt-bindings: regulator: add document bindings for slg51000 Eric Jeong
2019-04-18 10:26 ` Applied "dt-bindings: regulator: add document bindings for slg51000" to the regulator tree Mark Brown
2019-04-18 10:26 ` Mark Brown
2019-04-18 6:09 ` [PATCH V2 3/3] regulator: slg51000: add slg51000 regulator driver Eric Jeong
2019-04-18 10:16 ` Mark Brown [this message]
2019-04-18 10:26 ` Applied "regulator: slg51000: add slg51000 regulator driver" to the regulator tree Mark Brown
2019-04-18 10:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418101606.GC6702@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric.jeong.opensource@diasemi.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.