From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 1/4] drm/i915/bdw+: Move misc display IRQ handling to it own function Date: Thu, 18 Apr 2019 15:16:39 +0300 Message-ID: <20190418121639.GM1747@intel.com> References: <20190417223742.28246-1-jose.souza@intel.com> <977ec8cb3b7ce47013331a0ebcc211116987cb18.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id F22876E116 for ; Thu, 18 Apr 2019 12:16:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <977ec8cb3b7ce47013331a0ebcc211116987cb18.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMTcsIDIwMTkgYXQgMDg6NTA6NThQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBXZWQsIDIwMTktMDQtMTcgYXQgMTU6MzcgLTA3MDAsIEpvc8OpIFJv YmVydG8gZGUgU291emEgd3JvdGU6Cj4gPiBKdXN0IG1vdmluZyBpdCB0byByZWR1Y2UgdGhlIHRh YnMgYW5kIGF2b2lkIGJyZWFrIGNvZGUgbGluZXMuCj4gPiBObyBiZWhhdmlvciBjaGFuZ2VzIGlu dGVuZGVkIGhlcmUuCj4gPiAKPiA+IHYyOgo+ID4gLSBSZWFkaW5nIG1pc2MgZGlzcGxheSBJUlEg b3V0c2lkZSBvZiBnZW44X2RlX21pc2NfaXJxX2hhbmRsZXIoKSBhcwo+ID4gb3RoZXIgaXJxIGhh bmRsZXJzIChEaGluYWthcmFuKQo+ID4gCj4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhp bmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZp IDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0 byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgNDUgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+IGluZGV4IGI5MmNmZDY5MTM0Yi4u YTEyOTlmMTBlZDQ5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9p cnEuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gQEAgLTI3 NjgsNiArMjc2OCwyOCBAQCBzdGF0aWMgdTMyIGdlbjhfZGVfcG9ydF9hdXhfbWFzayhzdHJ1Y3QK PiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAlyZXR1cm4gbWFzazsKPiA+ICB9 Cj4gPiAgCj4gPiArc3RhdGljIHZvaWQKPiA+ICtnZW44X2RlX21pc2NfaXJxX2hhbmRsZXIoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgaWlyKQo+ID4gK3sKPiA+ICsJYm9v bCBmb3VuZCA9IGZhbHNlOwo+ID4gKwo+ID4gKwlpZiAoaWlyICYgR0VOOF9ERV9NSVNDX0dTRSkg ewo+ID4gKwkJaW50ZWxfb3ByZWdpb25fYXNsZV9pbnRyKGRldl9wcml2KTsKPiA+ICsJCWZvdW5k ID0gdHJ1ZTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoaWlyICYgR0VOOF9ERV9FRFBfUFNSKSB7 Cj4gPiArCQl1MzIgcHNyX2lpciA9IEk5MTVfUkVBRChFRFBfUFNSX0lJUik7Cj4gPiArCj4gPiAr CQlpbnRlbF9wc3JfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIHBzcl9paXIpOwo+ID4gKwkJSTkxNV9X UklURShFRFBfUFNSX0lJUiwgcHNyX2lpcik7Cj4gCj4gVHdvIHRoaW5ncyB1bnJlbGF0ZWQgdG8g eW91ciByZWZhY3RvcmluZywgCj4gCj4gMSkgd2UgY2FuIGFjayB0aGUgaXJxIHJpZ2h0IGFmdGVy IHJlYWRpbmcgdGhlIGlpciBiaXRzLiBJIGhhZCBub3RpY2VkIHRoaXMgYQo+IHdoaWxlIGJhY2sg YnV0IG5ldmVyIGdvdCB0byBjaGFuZ2luZyBpdC4KClNlZSBodHRwczovL3BhdGNod29yay5mcmVl ZGVza3RvcC5vcmcvc2VyaWVzLzU5NTEyLwoKPiAKPiAyKSB3ZSBkb24ndCBEUk1fRVJST1IoKSBm b3IgdW5leHBlY3RlZCBQU1IgaW50ZXJydXB0cyBsaWtlIGhvdyBvdGhlciBoYW5kbGVycwo+IGRv LiBOb3Qgc3VyZSB3aGF0J3MgdGhlIHBvaW50IHRob3VnaCwgb3RoZXIgdGhhbiBnZXR0aW5nIHRv IGtub3cgdGhhdCB0aGUKPiBoYXJkd2FyZSBpcyBicm9rZW4uIAo+IAo+IFZpbGxlLCBhbnkgaWRl YSB3aHkgdW5leHBlY3RlZCBpbnRlcnJ1cHRzIHdhcnJhbnQgRFJNX0VSUk9SKCkuCgpJIHN1cHBv c2UgcGVvcGxlIHdhbnRlZCBzb21lIGNvbmZpcm1hdGlvbiB0aGF0IHRoZSBjb2RlIGFuZCBoYXJk d2FyZQphcmUgZG9pbmcgdGhlIHJpZ2h0IHRoaW5nLgoKPiAKPiAKPiBUaGlzIHBhdGNoIGlzIAo+ IFJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGlu dGVsLmNvbT4KPiAKPiAKPiA+ICsJCWZvdW5kID0gdHJ1ZTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlp ZiAoIWZvdW5kKQo+ID4gKwkJRFJNX0VSUk9SKCJVbmV4cGVjdGVkIERFIE1pc2MgaW50ZXJydXB0 XG4iKTsKPiA+ICt9Cj4gPiArCj4gPiAgc3RhdGljIGlycXJldHVybl90Cj4gPiAgZ2VuOF9kZV9p cnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBtYXN0ZXJf Y3RsKQo+ID4gIHsKPiA+IEBAIC0yNzc4LDI5ICsyODAwLDEyIEBAIGdlbjhfZGVfaXJxX2hhbmRs ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gdTMyIG1hc3Rlcl9jdGwp Cj4gPiAgCWlmIChtYXN0ZXJfY3RsICYgR0VOOF9ERV9NSVNDX0lSUSkgewo+ID4gIAkJaWlyID0g STkxNV9SRUFEKEdFTjhfREVfTUlTQ19JSVIpOwo+ID4gIAkJaWYgKGlpcikgewo+ID4gLQkJCWJv b2wgZm91bmQgPSBmYWxzZTsKPiA+IC0KPiA+ICAJCQlJOTE1X1dSSVRFKEdFTjhfREVfTUlTQ19J SVIsIGlpcik7Cj4gPiAgCQkJcmV0ID0gSVJRX0hBTkRMRUQ7Cj4gPiAtCj4gPiAtCQkJaWYgKGlp ciAmIEdFTjhfREVfTUlTQ19HU0UpIHsKPiA+IC0JCQkJaW50ZWxfb3ByZWdpb25fYXNsZV9pbnRy KGRldl9wcml2KTsKPiA+IC0JCQkJZm91bmQgPSB0cnVlOwo+ID4gLQkJCX0KPiA+IC0KPiA+IC0J CQlpZiAoaWlyICYgR0VOOF9ERV9FRFBfUFNSKSB7Cj4gPiAtCQkJCXUzMiBwc3JfaWlyID0gSTkx NV9SRUFEKEVEUF9QU1JfSUlSKTsKPiA+IC0KPiA+IC0JCQkJaW50ZWxfcHNyX2lycV9oYW5kbGVy KGRldl9wcml2LCBwc3JfaWlyKTsKPiA+IC0JCQkJSTkxNV9XUklURShFRFBfUFNSX0lJUiwgcHNy X2lpcik7Cj4gPiAtCQkJCWZvdW5kID0gdHJ1ZTsKPiA+IC0JCQl9Cj4gPiAtCj4gPiAtCQkJaWYg KCFmb3VuZCkKPiA+IC0JCQkJRFJNX0VSUk9SKCJVbmV4cGVjdGVkIERFIE1pc2MgaW50ZXJydXB0 XG4iKTsKPiA+IC0JCX0KPiA+IC0JCWVsc2UKPiA+ICsJCQlnZW44X2RlX21pc2NfaXJxX2hhbmRs ZXIoZGV2X3ByaXYsIGlpcik7Cj4gPiArCQl9IGVsc2Ugewo+ID4gIAkJCURSTV9FUlJPUigiVGhl IG1hc3RlciBjb250cm9sIGludGVycnVwdCBsaWVkIChERQo+ID4gTUlTQykhXG4iKTsKPiA+ICsJ CX0KPiA+ICAJfQo+ID4gIAo+ID4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSAmJiAo bWFzdGVyX2N0bCAmIEdFTjExX0RFX0hQRF9JUlEpKSB7CgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==