From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
jannh@google.com, dhowells@redhat.com, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, serge@hallyn.com, luto@kernel.org,
arnd@arndb.de, ebiederm@xmission.com, keescook@chromium.org,
tglx@linutronix.de, mtk.manpages@gmail.com,
akpm@linux-foundation.org, cyphar@cyphar.com,
joel@joelfernandes.org, dancol@google.com,
Jann Horn <jann@thejh.net>
Subject: Re: [PATCH v2 3/5] signal: use fdget() since we don't allow O_PATH
Date: Thu, 18 Apr 2019 15:17:23 +0200 [thread overview]
Message-ID: <20190418131722.GC13701@redhat.com> (raw)
In-Reply-To: <20190418101841.4476-4-christian@brauner.io>
On 04/18, Christian Brauner wrote:
>
> It's just semantically correct to use fdget()
> and return an error right from there instead of taking a reference and
> returning an error later.
agreed, and thanks for your explanations
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2019-04-18 13:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 10:18 [PATCH v2 0/5] clone: add CLONE_PIDFD Christian Brauner
2019-04-18 10:18 ` [PATCH v2 1/5] Make anon_inodes unconditional Christian Brauner
2019-04-18 10:18 ` [PATCH v2 2/5] clone: add CLONE_PIDFD Christian Brauner
2019-04-18 13:12 ` Oleg Nesterov
2019-04-18 13:28 ` Christian Brauner
2019-04-18 14:10 ` Oleg Nesterov
2019-04-18 14:15 ` Christian Brauner
2019-04-19 13:39 ` Aleksa Sarai
2019-04-18 10:18 ` [PATCH v2 3/5] signal: use fdget() since we don't allow O_PATH Christian Brauner
2019-04-18 13:17 ` Oleg Nesterov [this message]
2019-04-18 15:37 ` Linus Torvalds
2019-04-18 15:53 ` Christian Brauner
2019-04-18 10:18 ` [PATCH v2 4/5] signal: support CLONE_PIDFD with pidfd_send_signal Christian Brauner
2019-04-18 14:26 ` Oleg Nesterov
2019-04-18 15:01 ` Christian Brauner
2019-04-18 10:18 ` [PATCH v2 5/5] samples: show race-free pidfd metadata access Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418131722.GC13701@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dancol@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jann@thejh.net \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.