From: Greg KH <gregkh@linuxfoundation.org>
To: Taras Kondratiuk <takondra@cisco.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Miklos Szeredi <mszeredi@redhat.com>,
Amir Goldstein <amir73il@gmail.com>,
xe-linux-external@cisco.com
Subject: Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")
Date: Thu, 18 Apr 2019 21:18:32 +0200 [thread overview]
Message-ID: <20190418191832.GA19119@kroah.com> (raw)
In-Reply-To: <155561157203.5780.9658522761344748705@takondra-t460s>
On Thu, Apr 18, 2019 at 11:19:32AM -0700, Taras Kondratiuk wrote:
> Quoting Sasha Levin (2019-04-18 06:46:12)
> > On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
> > >Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
> > >the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
> > >patch has a few follow up fixes in upstream that also have to be applied
> > >to 4.4:
> > >d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
> > >8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
> >
> > The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
> > and 51f8f3c4e225.
>
> The context is slightly modified by 51f8f3c4e225, but it looks
> irrelevant. The fix should be still valid, because err value can be set
> to PTR_ERR(mnt) above and when prepare_creds() fails ovl_fill_super()
> will return a random value of mnt pointer instead of a proper error
> code.
Can you provide a working backport please, so that it can be applied?
thanks,
greg k-h
prev parent reply other threads:[~2019-04-19 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 22:16 [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter") Taras Kondratiuk
2019-04-18 13:46 ` Sasha Levin
2019-04-18 18:19 ` Taras Kondratiuk
2019-04-18 19:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418191832.GA19119@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amir73il@gmail.com \
--cc=mszeredi@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=takondra@cisco.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.