From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL for-4.1 2/9] Use #include "..." for our own headers, <...> for others
Date: Thu, 18 Apr 2019 22:38:33 +0200 [thread overview]
Message-ID: <20190418203840.10528-3-armbru@redhat.com> (raw)
In-Reply-To: <20190418203840.10528-1-armbru@redhat.com>
Also delete a few redundant #include.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190315145123.28030-2-armbru@redhat.com>
---
contrib/rdmacm-mux/main.c | 18 +++++++++---------
contrib/rdmacm-mux/rdmacm-mux.h | 6 +++---
hw/rdma/rdma_utils.h | 1 -
target/i386/whp-dispatch.h | 2 +-
target/i386/whpx-all.c | 1 -
5 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c
index 21cc804367..30c7052651 100644
--- a/contrib/rdmacm-mux/main.c
+++ b/contrib/rdmacm-mux/main.c
@@ -14,16 +14,16 @@
*/
#include "qemu/osdep.h"
-#include "sys/poll.h"
-#include "sys/ioctl.h"
-#include "pthread.h"
-#include "syslog.h"
+#include <sys/poll.h>
+#include <sys/ioctl.h>
+#include <pthread.h>
+#include <syslog.h>
-#include "infiniband/verbs.h"
-#include "infiniband/umad.h"
-#include "infiniband/umad_types.h"
-#include "infiniband/umad_sa.h"
-#include "infiniband/umad_cm.h"
+#include <infiniband/verbs.h>
+#include <infiniband/umad.h>
+#include <infiniband/umad_types.h>
+#include <infiniband/umad_sa.h>
+#include <infiniband/umad_cm.h>
#include "rdmacm-mux.h"
diff --git a/contrib/rdmacm-mux/rdmacm-mux.h b/contrib/rdmacm-mux/rdmacm-mux.h
index 942a802c47..07a4722913 100644
--- a/contrib/rdmacm-mux/rdmacm-mux.h
+++ b/contrib/rdmacm-mux/rdmacm-mux.h
@@ -17,9 +17,9 @@
#define RDMACM_MUX_H
#include "linux/if.h"
-#include "infiniband/verbs.h"
-#include "infiniband/umad.h"
-#include "rdma/rdma_user_cm.h"
+#include <infiniband/verbs.h>
+#include <infiniband/umad.h>
+#include <rdma/rdma_user_cm.h>
typedef enum RdmaCmMuxMsgType {
RDMACM_MUX_MSG_TYPE_REQ = 0,
diff --git a/hw/rdma/rdma_utils.h b/hw/rdma/rdma_utils.h
index 2d42249691..e7babe96cb 100644
--- a/hw/rdma/rdma_utils.h
+++ b/hw/rdma/rdma_utils.h
@@ -20,7 +20,6 @@
#include "qemu/error-report.h"
#include "hw/pci/pci.h"
#include "sysemu/dma.h"
-#include "stdio.h"
#define rdma_error_report(fmt, ...) \
error_report("%s: " fmt, "rdma", ## __VA_ARGS__)
diff --git a/target/i386/whp-dispatch.h b/target/i386/whp-dispatch.h
index 4ae3cc8fa5..a23fb33a29 100644
--- a/target/i386/whp-dispatch.h
+++ b/target/i386/whp-dispatch.h
@@ -1,4 +1,4 @@
-#include "windows.h"
+#include <windows.h>
#include <WinHvPlatform.h>
#include <WinHvEmulation.h>
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index 57e53e1f1f..31d47320e4 100644
--- a/target/i386/whpx-all.c
+++ b/target/i386/whpx-all.c
@@ -13,7 +13,6 @@
#include "exec/address-spaces.h"
#include "exec/ioport.h"
#include "qemu-common.h"
-#include "strings.h"
#include "sysemu/accel.h"
#include "sysemu/whpx.h"
#include "sysemu/sysemu.h"
--
2.17.2
next prev parent reply other threads:[~2019-04-18 20:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 20:38 [Qemu-devel] [PULL for-4.1 0/9] Miscellaneous patches for 2019-04-18 Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 1/9] Clean up includes Markus Armbruster
2019-04-18 20:38 ` Markus Armbruster [this message]
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 3/9] authz: Normalize #include "authz/trace.h" to "trace.h" Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 4/9] linux-user/nios2 linux-user/riscv: Clean up header guards Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 5/9] target/xtensa: Clean up core-isa.h " Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 6/9] Clean up header guards that don't match their file name Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 7/9] Clean up ill-advised or unusual header guards Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 8/9] Normalize header guard symbol definition Markus Armbruster
2019-04-18 20:38 ` [Qemu-devel] [PULL for-4.1 9/9] Clean up decorations and whitespace around header guards Markus Armbruster
2019-04-24 10:55 ` [Qemu-devel] [PULL for-4.1 0/9] Miscellaneous patches for 2019-04-18 Peter Maydell
2019-05-06 11:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418203840.10528-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.