From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6000:88:0:0:0:0 with SMTP id m8csp1265860wrx; Thu, 18 Apr 2019 17:48:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3UtxZt4kx6xk3lkSKpp31cx8gxP1yDiOlUhmjVQS/SKyMPAIb/FwWGnGwggFAzWZCRSo4 X-Received: by 2002:a1c:20cf:: with SMTP id g198mr739084wmg.42.1555634931927; Thu, 18 Apr 2019 17:48:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555634931; cv=none; d=google.com; s=arc-20160816; b=heon66FVxN1uHGUH+WAFcjNeRzzPOPgp7cIwwisCMKauo4jeVizxkR0bBLk4II7rTi XM3FQrnY95k1bpvU8m8z1db9V53QvPB4nppvQWUzaXVslqQIoUs/ETvEEHy6y8I2bKG/ 55Ry6ixiulSyfOJNn5nNABSksLA/dxpVIe6KWCsHXxcmtmO3CGPepOq6QBLnXYWDxYys JIGDRd+FAuUNAEuWvM3RrwUzxYOywZOs4JSmlQXdODD4BorIA8W6svZIH4dB5JaiKqwN KFqr6cv8Op0TrQpO6ladFPgzYsvMTdCMV3VVwxcDnc522GhJeD/o5uMEW1IbfNot7krm PJFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=eJ6t9G3eZlWLik/iCt7LMGSzyS4JGJWMYhSFJEHxV94=; b=ikzJOhJCShh9RftK6mpJxQfUnMM1jJ2Nmxf4KGioRMnf7tv6cjIY33OrieA2TpfyVe msvRUqghkO61XGRkErg+UEBIkLGatK7/gW7wRDUm+1MqpR8qDW8BfMGJFXe+bUKsrbgQ TBIF0LaQYcLlCERS9ZwqAsnXB9ZJqBUmNYKh+0+6Py3VDS77lyw8AJbAXD2cj8F7Fywr XXiw6JCo/Zwf4H4DtdGAbmMS+N1MoYyfdnXMSbiO1zjC87VYSWbiUhrbIEPyXFiohkfP inwbMRNLIKgYmDKTFEsCp5rWHIp0dzpMmp0brVUih932vqC3sJCgD9b7QzfDBSBIoZZV JR2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u17si2735227wrt.146.2019.04.18.17.48.51 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 18 Apr 2019 17:48:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from localhost ([127.0.0.1]:49301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHHhz-0003Ie-3T for alex.bennee@linaro.org; Thu, 18 Apr 2019 20:48:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHHc8-0007cN-FG for qemu-devel@nongnu.org; Thu, 18 Apr 2019 20:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHHRC-0005oA-CX for qemu-devel@nongnu.org; Thu, 18 Apr 2019 20:31:31 -0400 Received: from mga18.intel.com ([134.134.136.126]:3679) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHHRA-0005kx-VX; Thu, 18 Apr 2019 20:31:29 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 17:31:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,367,1549958400"; d="scan'208";a="163163316" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 18 Apr 2019 17:31:26 -0700 From: Wei Yang To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Date: Fri, 19 Apr 2019 08:30:49 +0800 Message-Id: <20190419003053.8260-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190419003053.8260-1-richardw.yang@linux.intel.com> References: <20190419003053.8260-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.126 Subject: [Qemu-devel] [PATCH v4 2/6] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, peter.maydell@linaro.org, mst@redhat.com, shannon.zhaosl@gmail.com, Wei Yang , imammedo@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: b28ayJ89iseB mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 857989362a..e09e7eff8d 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:c793:0:0:0:0:0 with SMTP id l19csp576657wrg; Thu, 16 May 2019 05:31:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxreInNDdQfs58ppgvuAChz1HQxABMHeL6ZyNN3dLss8+VrrOeZMSqR4WUQxZo04iGuIbSa X-Received: by 2002:a17:906:4dc7:: with SMTP id f7mr31510141ejw.207.1558009910089; Thu, 16 May 2019 05:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558009910; cv=none; d=google.com; s=arc-20160816; b=0yKQa+RpdHa79Of32uiy0+lM4f7WfCCiC3NPqw72+8AMwLDicwFOwoqGvCsoymeoVs Zh1NAKJxqp5KDo0dDcX96sNjwRn2qaZ5z9A3qV/iWhMyJKIUVDT3YJPvR50JDuWYcRKr YzekiBQHBZZ1JBaE6rU4jPlEiz+Z3x6dfymVKH2jP8+fA04pYunAD/Sd57uCiiijy0fT WqxjVc2tr2o6o1Pf898k3ie3JPBnzP/8J2VDzJ52Hb5YZRDxoAV7BRzkzcoowvgmgnjj h7fYn6EOgU9JfFkxWeYpdmjB77/K9o5sbvZqlDpzZ575GaE3AL/jxj6uRPLa4aJFXVAL /4lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:to:from:date; bh=/K1CzhcIoF7fjAc30rHRUsge+GK+glXAnsnZpkxETzA=; b=0gy1Wb9HpN7Ls7nkZEASs5yftmBsvTBysJPYc7+Y0mkLhU77xof8hILP+zuyAWUPxv H7m4rdQZRKT5NsyBFtpQ6/9YQSFW9X5YDlnNpOkPpSPWRqYkpzTor8B6KHVEdBpdZW/q fmwgFIyAUysNIMfMX1BlKgrjGOObvct0jBrvW8jkek2CtwN3ch5w39fJJPpBlJNpD5jT xpHaqx254eN02U2dmfhEfCoeKNKudkLrw2uQ1LhJhjq0F5FmZzCQ1QDn/wOirl2T/4Oh E+szNDtqczOIzQ03pqI1ALUJf1H4rtqRsJwnGMvBWbb4KsRwuSlrjce2Qy5cc+gohvb8 HKbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x39si3827175edm.112.2019.05.16.05.31.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 16 May 2019 05:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:53938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRFY5-0002ae-2q for alex.bennee@linaro.org; Thu, 16 May 2019 08:31:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRFMC-0000a6-2f for qemu-devel@nongnu.org; Thu, 16 May 2019 08:19:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRFM8-0001xs-1U for qemu-devel@nongnu.org; Thu, 16 May 2019 08:19:31 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRFM6-0001wn-4p for qemu-devel@nongnu.org; Thu, 16 May 2019 08:19:27 -0400 Received: by mail-qt1-f193.google.com with SMTP id j53so3532445qta.9 for ; Thu, 16 May 2019 05:19:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/K1CzhcIoF7fjAc30rHRUsge+GK+glXAnsnZpkxETzA=; b=Mrs3Pcx0AhcTjejGHY9HmZyURRAnKmvxWMyuAeTN7lXR1mtvsKTmy/s+GiY+ghn5Jh 4F6BLzlkz5Qz8k/emthpcDxLSNTI95cGC4j1bwxKgJG1FZbZeXDkHJKbOejyiq43a5lc DAY9Hx5iTbGUx6E/aBQeRPeWP1GsoOtHoUKk2xS0VN16T537iiFeNxillkHfwNC3ONHw 8YwpmrwJ1Xllar8B3bAJ7PCUlJoQYjsZI/u9wh6zKgzmhCjUONIsBrABcsPKRkg/kfkQ QdLi2BaVwyV7JgzMWsvl9Tq3Czen+3KuPxIljPGl6cD7+yM+tKw3Dzwscexjs5cGnzqO 2v0Q== X-Gm-Message-State: APjAAAUV9SZ390cEMXqU85MPHqbtFifQeeG519oHxN9DsK6jWFLHObwz aXCOqk5DhMF2sRhjlqbs3AMD26o/yMQ= X-Received: by 2002:ac8:3702:: with SMTP id o2mr41500281qtb.119.1558009165340; Thu, 16 May 2019 05:19:25 -0700 (PDT) Received: from redhat.com ([185.54.206.10]) by smtp.gmail.com with ESMTPSA id g55sm3308171qtk.76.2019.05.16.05.19.23 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 16 May 2019 05:19:24 -0700 (PDT) Date: Thu, 16 May 2019 08:19:21 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190419003053.8260-3-richardw.yang@linux.intel.com> References: <20190515121146.7248-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190515121146.7248-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: [Qemu-devel] [PULL 16/37] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Shannon Zhao , qemu-arm@nongnu.org, Wei Yang , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: nY786kQyMuOs Message-ID: <20190516121921.GoNDH7oEhUBaDZnSFESwkbIzbhRYboHSGwIX4NFnEOM@z> From: Wei Yang mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190419003053.8260-3-richardw.yang@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index bf9c0bc2f4..12dbaf3846 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:c793:0:0:0:0:0 with SMTP id l19csp743034wrg; Mon, 20 May 2019 16:22:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJ0TyCnpVSDfL0N9z1i0sHB/tPjQmcMpwoJ8H84r2j5Hn1dLOvJfoMdooS+CQ7ExHS1noZ X-Received: by 2002:a17:906:7d16:: with SMTP id u22mr42245700ejo.85.1558394535117; Mon, 20 May 2019 16:22:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558394535; cv=none; d=google.com; s=arc-20160816; b=rMTX8329Sf05X/2mWOQmu/CJbxCguaM5yVrAfrWEinLLVQfftO3OI8t4ILZu/4q9tt TsRrSd+rYIC3A+KNMlEjj9Rq3UYUfwWFXEEH7Y4mQHNVMBiq6V3Wa7gAreCUXMbqDppK EG01Pi9GYAvHD4X3ih3Of855lEx+agC6z//2tpte9BzZ5CzqX3f2ebjJCWsVsrlQa36d HiQONGOMPjYy/Ri/sIm+BPArxJDn+IeGTqDBW4BQrgxm8o/tsY7tbEWHXTxwf7/W4CMb 0+oN0ChounXPFN2ZJw/Jt3QxGy9XEYMI5asNKp48kYNaKBeWbCMq/u1LBRonO920UQ+f Ecgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:to:from:date; bh=/K1CzhcIoF7fjAc30rHRUsge+GK+glXAnsnZpkxETzA=; b=laDcDv6xamLOZN7kA+qpNeHAxXC4DnywnsXviLu45ZbLq9AfmfLITaEB6oYVQnBuJ6 BykAVpyDemyPCtVX2fHaqVxCqbZAIcJVhfrZ9Juc13quZzEB6mYsYdHGiIaKG/Ihy5Qb p+3Zr9natR6S48EDJ9yCGVv7EUgTXFSMZ4uTBLEjIs8NizUn7zdG6QlsizdT7dmbILvS Wk6G0ad6EjfvGXmkxuk9m19tNZTj/xEs4T9FTstHrCLOnPDbTGnwmPrcdwiliY6Ff0Du tv9US0ZxEUYQMpoJ+zi5BJ4AZZd2RwDNXbsxbnzZJ6VLHG+6UElp7aQ3H376PJtclBc2 TmVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i42si2593213ede.114.2019.05.20.16.22.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 20 May 2019 16:22:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:43482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrbi-0008GX-45 for alex.bennee@linaro.org; Mon, 20 May 2019 19:22:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrQs-0007SK-7g for qemu-arm@nongnu.org; Mon, 20 May 2019 19:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSrQr-00087H-BK for qemu-arm@nongnu.org; Mon, 20 May 2019 19:11:02 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSrQr-000879-7g for qemu-arm@nongnu.org; Mon, 20 May 2019 19:11:01 -0400 Received: by mail-qt1-f194.google.com with SMTP id j53so18342654qta.9 for ; Mon, 20 May 2019 16:11:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/K1CzhcIoF7fjAc30rHRUsge+GK+glXAnsnZpkxETzA=; b=NlpPW2GzZfYc1Tapq3rD0srEqjFaI1W7v4atqg3rl6HpF1dlY9GRD2W1Gf+HJNpHYI 12hMiIFsSH77pJKVCNcoqHRitiwzSJzzGYvI58a8dEElYLDaokxN9qqhJAm5ksMiNXLU ExbNjk5Izn1OJnFpAcCuAOvindJImbIsDqlzE9Q30o+y5bqqsKxZAnX1m0VCqqEELwDi vOww08lDm64Fbw/DzRXhLPcNIPvpG1LJkPDO0klrKL7WuyPROnwyY2wvkRj9JHbPflyf UluEYrw/M1ORXBkWNH14zOFZYPoRtVrteHTTGE3ck15Eqhb4AKuk5eLmck6/YlZfN7PF a1jA== X-Gm-Message-State: APjAAAVFkmT9wwa3Mag8Ly9fdyGkWTDa6bmz0HXVKYzy5ZKP2Y6mzINF GuwDVVDXJ1MgZNKJNslXdKM1XQ== X-Received: by 2002:a0c:d909:: with SMTP id p9mr49615208qvj.42.1558393860861; Mon, 20 May 2019 16:11:00 -0700 (PDT) Received: from redhat.com (pool-173-76-105-71.bstnma.fios.verizon.net. [173.76.105.71]) by smtp.gmail.com with ESMTPSA id e54sm11315139qtc.26.2019.05.20.16.10.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 16:11:00 -0700 (PDT) Date: Mon, 20 May 2019 19:10:59 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190419003053.8260-3-richardw.yang@linux.intel.com> References: <20190520231008.20140-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190520231008.20140-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.194 Subject: [Qemu-arm] [PULL v2 16/36] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Shannon Zhao , qemu-arm@nongnu.org, Wei Yang , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: GxpbfE4asJbI Message-ID: <20190520231059.QcNqXpVZY4KIEaCmIC_VrxSe6dnVS9SOgVqoUbVHG6E@z> From: Wei Yang mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190419003053.8260-3-richardw.yang@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index bf9c0bc2f4..12dbaf3846 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHHc8-0007cN-FG for qemu-devel@nongnu.org; Thu, 18 Apr 2019 20:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHHRC-0005oA-CX for qemu-devel@nongnu.org; Thu, 18 Apr 2019 20:31:31 -0400 From: Wei Yang Date: Fri, 19 Apr 2019 08:30:49 +0800 Message-Id: <20190419003053.8260-3-richardw.yang@linux.intel.com> In-Reply-To: <20190419003053.8260-1-richardw.yang@linux.intel.com> References: <20190419003053.8260-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v4 2/6] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: mst@redhat.com, imammedo@redhat.com, shannon.zhaosl@gmail.com, peter.maydell@linaro.org, marcel.apfelbaum@gmail.com, yang.zhong@intel.com, philmd@redhat.com, Wei Yang mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 857989362a..e09e7eff8d 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD81AC04AAC for ; Mon, 20 May 2019 23:36:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 936BD20863 for ; Mon, 20 May 2019 23:36:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 936BD20863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrpV-0003SO-PU for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 19:36:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrQs-0007Sg-Nn for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSrQr-00087a-SV for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:02 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSrQr-00087N-OG for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:01 -0400 Received: by mail-qt1-f193.google.com with SMTP id j53so18342669qta.9 for ; Mon, 20 May 2019 16:11:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/K1CzhcIoF7fjAc30rHRUsge+GK+glXAnsnZpkxETzA=; b=XXkQ3zx+wyYXU45f2+jQaZF2dlcXIU3xznFn+fN9JP8ctDfkfJLgnr0KNLMc+B4hwT +NTwTUixKeO9bLr0RoVBeyJVkrsbZhmtKKwT7oJv73sJlMQP1oFWQdqgc2PshzGh79FP Z2AprlMlopNZmXwaBMrgdr/XVCGjECShcKh1ZLcOXSUIWUE4TFUtWyoC7vOWWO97Qf3Y 3cmoAHt15EIpO8TlmYIbI49tLhqvXslW21Yk3yajiH3Ymnjr3Cjk5dPUybEJs4lZPZ8+ Ww/6L09Zj233+Ulm3I3iEVwhd52LkebHggWuc4TGXrbevAKxeX7Q5HlyRQPLIzlQA6F6 uGRQ== X-Gm-Message-State: APjAAAUc2xbd+XZrri5re5ZJQqujavwhlD4hFoLvmyXhjicp7fVxJKPB sUYY05Uq+TgtRMzTaZhdhGeTPKfXM3Y= X-Google-Smtp-Source: APXvYqxoONLWRzCQrgT6CBbhquNH0TPoP8OWzvFrI+zQvC2n593uu+BgpCbFzH1EZYfcaR6XDZHfaA== X-Received: by 2002:a0c:d909:: with SMTP id p9mr49615208qvj.42.1558393860861; Mon, 20 May 2019 16:11:00 -0700 (PDT) Received: from redhat.com (pool-173-76-105-71.bstnma.fios.verizon.net. [173.76.105.71]) by smtp.gmail.com with ESMTPSA id e54sm11315139qtc.26.2019.05.20.16.10.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 16:11:00 -0700 (PDT) Date: Mon, 20 May 2019 19:10:59 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190419003053.8260-3-richardw.yang@linux.intel.com> References: <20190520231008.20140-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190520231008.20140-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: [Qemu-devel] [PULL v2 16/36] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Shannon Zhao , qemu-arm@nongnu.org, Wei Yang , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190520231059.uq8wlctxn1swGFWKw_IUpRtEZKj9XXnY53zz5Wk_5jE@z> From: Wei Yang mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190419003053.8260-3-richardw.yang@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index bf9c0bc2f4..12dbaf3846 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- MST