All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Li Wang <liwang@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	Minchan Kim <minchan@kernel.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: v5.1-rc5 s390x WARNING
Date: Fri, 19 Apr 2019 09:52:56 +0100	[thread overview]
Message-ID: <20190419085256.GI18914@techsingularity.net> (raw)
In-Reply-To: <CAEemH2eN55Nuvqngvpr1=1LU16KTbPAKo0-ZZW3Da6YX1S3kZw@mail.gmail.com>

On Fri, Apr 19, 2019 at 04:41:24PM +0800, Li Wang wrote:
> > Avoiding the scenario is pointless because it's not wrong. The check was
> > initially meant to catch serious programming errors such as using a
> > stale page pointer so I think the right patch is below. Li Wang, how
> > reproducible is this and would you be willing to test it?
> >
> 
> It's not easy to reproduce that again. I just saw only once during the OOM
> phase that occurred on my s390x platform.
> 
> Sure, I run the stress test against a new kernel(build with this patch
> applied) for many rounds, so far so good.
> 

I think the patch is safe enough and have sent it on to Andrew. Thanks
for reporting and testing this, it's appreciated.

-- 
Mel Gorman
SUSE Labs


  reply	other threads:[~2019-04-19  8:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  8:35 v5.1-rc5 s390x WARNING Li Wang
2019-04-17  8:54 ` Vlastimil Babka
2019-04-18 13:54   ` Mel Gorman
2019-04-18 14:37     ` Matthew Wilcox
2019-04-18 15:25       ` Mel Gorman
2019-04-19 12:53         ` Vlastimil Babka
2019-04-19  8:41     ` Li Wang
2019-04-19  8:52       ` Mel Gorman [this message]
2019-04-19 12:51     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419085256.GI18914@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=linux-mm@kvack.org \
    --cc=liwang@redhat.com \
    --cc=minchan@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.