From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix colliding function names
Date: Fri, 19 Apr 2019 17:33:20 +0530 [thread overview]
Message-ID: <20190419120319.GA12160@chelsio.com> (raw)
In-Reply-To: <20190419114425.46299-1-ferruh.yigit@intel.com>
On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in application.
>
> This patch prefixes all functions defined in cxgbe.h with cxgbe_
> to avoid these kind of conflicts.
>
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
next prev parent reply other threads:[~2019-04-19 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 23:37 [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names Stephen Hemminger
2019-04-19 8:15 ` Ferruh Yigit
2019-04-19 10:05 ` Rahul Lakkireddy
2019-04-19 10:04 ` Rahul Lakkireddy
2019-04-19 11:38 ` Ferruh Yigit
2019-04-19 11:44 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-04-19 12:03 ` Rahul Lakkireddy [this message]
2019-04-19 12:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419120319.GA12160@chelsio.com \
--to=rahul.lakkireddy@chelsio.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.