From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module autoloading Date: Mon, 22 Apr 2019 11:54:12 +0100 Message-ID: <20190422115412.4e2f717a@archlinux> References: <20190416234927.8888-1-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190416234927.8888-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Tue, 16 Apr 2019 16:49:27 -0700 Bjorn Andersson wrote: > The of_device_id table needs to be registered as module alias in order > for automatic module loading to pick the kernel module based on the > DeviceTree compatible. So add MODULE_DEVICE_TABLE() to make this happen. > > Fixes: e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver") > Cc: stable@vger.kernel.org > Signed-off-by: Bjorn Andersson I'll take this via the next merge window because it's been there a little while and in isn't a regression. Obviously we are very late in this cycle so I'd rather not do another fixes pull request. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/qcom-spmi-adc5.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c > index 6a866cc187f7..21fdcde77883 100644 > --- a/drivers/iio/adc/qcom-spmi-adc5.c > +++ b/drivers/iio/adc/qcom-spmi-adc5.c > @@ -664,6 +664,7 @@ static const struct of_device_id adc5_match_table[] = { > }, > { } > }; > +MODULE_DEVICE_TABLE(of, adc5_match_table); > > static int adc5_get_dt_data(struct adc5_chip *adc, struct device_node *node) > {