From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A647C10F11 for ; Mon, 22 Apr 2019 19:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D94D218DA for ; Mon, 22 Apr 2019 19:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962219; bh=7j3E1e+lrmReu26Do7xLFUPEL1t3n89IHvS62UC5CGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oB4vrObBwUNmmea0dEqhjhRiQ5Lwqt8R7fylEs4mYV8yVNK3u+KZAIHuzByJbyrtY mSYDKdxw6vFiW/DHBTYXlTR4tx9+dSs89ek2yMYuC4/SCt/MHjPyNEJLa8qMQVxUZ0 hy5YNBlOUpSbZrVshgUruMwZ4HqYlemRopT5iWK4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729208AbfDVTni (ORCPT ); Mon, 22 Apr 2019 15:43:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:44146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729198AbfDVTnf (ORCPT ); Mon, 22 Apr 2019 15:43:35 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6EFF218B0; Mon, 22 Apr 2019 19:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962214; bh=7j3E1e+lrmReu26Do7xLFUPEL1t3n89IHvS62UC5CGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r6SvD06x6LxN8yA0vkPAi0sxce62gzTK4y4xN1VpNFzXQKQenn9QVtM1Qu5/l1HE3 Nh4mqtYoOLoZz4FZZBQymXdP2MtxleqroQCP8YKxPrxTccj2yY1TRNZmos8LnPP7bz PmLG4gWmjYGIb6SKqKKBxk8nSa5lFU1LAO7V5fMQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , Greg Kroah-Hartman , Sasha Levin , devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 5.0 42/98] staging: rtlwifi: rtl8822b: fix to avoid potential NULL pointer dereference Date: Mon, 22 Apr 2019 15:41:09 -0400 Message-Id: <20190422194205.10404-42-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190422194205.10404-1-sashal@kernel.org> References: <20190422194205.10404-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki [ Upstream commit d70d70aec9632679dd00dcc1b1e8b2517e2c7da0 ] skb allocated via dev_alloc_skb can fail and return a NULL pointer. This patch avoids such a scenario and returns, consistent with other invocations. Signed-off-by: Aditya Pakki Reviewed-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (Microsoft) --- drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c index a40396614814..c1ed52df05f0 100644 --- a/drivers/staging/rtlwifi/rtl8822be/fw.c +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c @@ -741,6 +741,8 @@ void rtl8822be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) u1_rsvd_page_loc, 3); skb = dev_alloc_skb(totalpacketlen); + if (!skb) + return; memcpy((u8 *)skb_put(skb, totalpacketlen), &reserved_page_packet, totalpacketlen); -- 2.19.1