From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A1FC10F11 for ; Tue, 23 Apr 2019 02:46:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C953206BA for ; Tue, 23 Apr 2019 02:46:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="x2AC0Q1c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731150AbfDWCqx (ORCPT ); Mon, 22 Apr 2019 22:46:53 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:43006 "EHLO mail-qt1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729451AbfDWCqw (ORCPT ); Mon, 22 Apr 2019 22:46:52 -0400 Received: by mail-qt1-f174.google.com with SMTP id p20so14468543qtc.9 for ; Mon, 22 Apr 2019 19:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=c4wotXorFgf9Au5qGASFV5V5jYgduSaqvzAZwZlG1gU=; b=x2AC0Q1cuGuUD9XFYaG49X4/6PXaoPX+XGmyrxcyIEw3joD4Uf5GulFFOtIKF+GAjM nF8oYjzkmVuOb9SHPxiSvdHWDDUzdVFhHPC9ZXTTkvD4wYvNnimmUGLJPNKdPd8L3xJp ItYquwlqSBUFo31AgI4nhZ4DHZ+yV86lXeOFW2gfRJGSMDqtulylW2FbdknmluPHnEKH g2AVVjDEEbYBhFjlL3utzJ8z3g0Z5m1ihZpbMfJkeqXfx1Gdor+zbz1HIohg7RUsJRd3 +b86IiMOZIMehx372f67u/ZbtQsQMVcN/OQNwQRhqQBfBKghUs/IpfhC8EGK6qVMU/Es 7DIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=c4wotXorFgf9Au5qGASFV5V5jYgduSaqvzAZwZlG1gU=; b=UBXj2nxT0T1lYUrR9RrGX238idQoMjemuv7ji9yAfUa/YwhLiGtS8PxJFqslcOmxFG yyzbJQnKjd/voENFxX0MJzwZE+hNYe7dqiX8vyQEZa9MiksuBqi6FWfXawUoYb72+syJ ScYUoopFBwUUO0qZDXSpZ0qLgHS02k7TshW8kavirU5VrPLFzBE7H9PH3HUSBNCQQ84e Y4deoh3QN6nS7TmFozhr4xsuVXz3APqRV8TTX+uhBYdiA0X1xGjq5zPBfcsxPkvbOl1b E98aJA1yg4YKlZJvHCvhgx7evGerkPxlI0cspIaL0XKiw5+wCGP0tV/AnuwtMmmwhFD7 eBzQ== X-Gm-Message-State: APjAAAVDnfITiUWc9ztu0loPBn3HOq/izSOfX2y1pCTdF2CYr4V/qm1m n+gDAIMfRMgIQCwOQC1iiPqpb3T4C70= X-Google-Smtp-Source: APXvYqzBEnabU6hVSbZX0vqXcDff6kgCkAVubmUYARS/N0L37Ayn8XDnu3RvY3ZoMIIeJNAD7Ilqog== X-Received: by 2002:aed:2121:: with SMTP id 30mr10346796qtc.47.1555987611786; Mon, 22 Apr 2019 19:46:51 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id 6sm9801587qtt.8.2019.04.22.19.46.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 19:46:51 -0700 (PDT) Date: Mon, 22 Apr 2019 19:46:47 -0700 From: Jakub Kicinski To: Saeed Mahameed , Tariq Toukan Cc: "David S. Miller" , netdev@vger.kernel.org, Jesper Dangaard Brouer , Jonathan Lemon Subject: Re: [net-next 01/14] net/mlx5e: RX, Add a prefetch command for small L1_CACHE_BYTES Message-ID: <20190422194647.372fd817@cakuba.netronome.com> In-Reply-To: <20190422223306.31568-2-saeedm@mellanox.com> References: <20190422223306.31568-1-saeedm@mellanox.com> <20190422223306.31568-2-saeedm@mellanox.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 22 Apr 2019 15:32:53 -0700, Saeed Mahameed wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h > index 51e109fdeec1..6147be23a9b9 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h > @@ -50,6 +50,7 @@ > #include > #include > #include > +#include > #include "wq.h" > #include "mlx5_core.h" > #include "en_stats.h" > @@ -986,6 +987,22 @@ static inline void mlx5e_cq_arm(struct mlx5e_cq *cq) > mlx5_cq_arm(mcq, MLX5_CQ_DB_REQ_NOT, mcq->uar->map, cq->wq.cc); > } > > +static inline void mlx5e_prefetch(void *p) > +{ > + prefetch(p); > +#if L1_CACHE_BYTES < 128 > + prefetch(p + L1_CACHE_BYTES); > +#endif > +} > + > +static inline void mlx5e_prefetchw(void *p) > +{ > + prefetchw(p); > +#if L1_CACHE_BYTES < 128 > + prefetchw(p + L1_CACHE_BYTES); > +#endif > +} All Intel drivers do the exact same thing, perhaps it's time to add a helper fot this? net_prefetch_headers() or some such?