From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E515C10F14 for ; Tue, 23 Apr 2019 03:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C5F020B1F for ; Tue, 23 Apr 2019 03:24:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ph0AuCxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731581AbfDWDYL (ORCPT ); Mon, 22 Apr 2019 23:24:11 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38066 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727407AbfDWDYK (ORCPT ); Mon, 22 Apr 2019 23:24:10 -0400 Received: by mail-pg1-f196.google.com with SMTP id j26so6825019pgl.5 for ; Mon, 22 Apr 2019 20:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=doukx/jyKeqiylSQc1qIQ+6rgkMeX7AZttPvY7Xxq/k=; b=Ph0AuCxngdj1xOHfaNuQ3h4gj9SX34ga51yEpC8n0UYe0vXyWg8PRuX3dgWxLttkQX 1NjyNOLj1gSjg9GDBeiatRwIHSdKEcCM3k7IWZFdf3MN6iWa4KwhjcA1Hx8aN0/ajM2H sa6FrlPoUGfDaF0pA7abiZGi8zLpcXskCZAXYvXE6+8+7jDHgrECM/RphBIM/lzZVFXi fgdiGu0rMInUov/TBTpPr7lbMc4fG/CdZHTrFDhXSkysLb5cgG6lpTMl1HLd0noeWamK ToF6pnEQXUp7LZPC8Z/HNwZi23OCp+r8XcWE3Gb8LRuEaEy6kjASOCBZw5zuZMqTJIxx JJgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=doukx/jyKeqiylSQc1qIQ+6rgkMeX7AZttPvY7Xxq/k=; b=Qvu4SWOUFF8VFZDxXtfNpCf1CioYXK6MWfQfRoe0p+ojdOZhqrnzDTGEpqoWzaqqrq HRrIpYyc+YXxnC+rwyOw3C314WMCwB1wyiEclTYxFv4fsKbYn5uz0nrNfGN8uITmQ+KO IQpPA7eqG1DqUbC75+xrIIxycGYGBoGozWwc4Aqi5wRXEfUnurfY91aQ4ZaU9ihqxrST zsi8ROpWk13EW0aC28a0lQjXNuvBXEmdgEZYr4xPzsKIV9cE4CYwpEs5/MwYSyoLz9VD I2SsVVZBwGZT5Eryh4hV6h80iHGn2RwimPXW8TchAoGGllD6uW8gh9lqQuoU6XAxtbxn qEyg== X-Gm-Message-State: APjAAAVONqmbIFPsl9XbKYmYd1qwLnN3LXeXIFZhYAMx3SdSbARk61JO CaHrGi833tTudpFGdGieZAE= X-Google-Smtp-Source: APXvYqwAFYQo02EwOIWWXP0rbukvhJ/Okj3OPRbo1BQBv6tthkpmm+rCWif+M9VBMadlx9W1yHOsPA== X-Received: by 2002:a63:4644:: with SMTP id v4mr22527134pgk.422.1555989849584; Mon, 22 Apr 2019 20:24:09 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k186sm25096865pfc.137.2019.04.22.20.24.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 20:24:09 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger Date: Mon, 22 Apr 2019 20:24:01 -0700 To: Fuqian Huang Cc: Karsten Keil , netdev@vger.kernel.org Subject: Re: [PATCH] isdn: hisax: Fix misuse of %x in config.c Message-ID: <20190422202327.77a97643@hermes.lan> In-Reply-To: <20190423022528.3595-1-huangfq.daxian@gmail.com> References: <20190423022528.3595-1-huangfq.daxian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 23 Apr 2019 10:25:28 +0800 Fuqian Huang wrote: > Pointers should be printed with %p or %px rather than > cast to (u_long) type and printed with %lX. > As the function seems to be for debug purpose. > Change %lX to %px to print the pointer value. > > Signed-off-by: Fuqian Huang > --- > drivers/isdn/hisax/config.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c > index b12e6ca..de96511 100644 > --- a/drivers/isdn/hisax/config.c > +++ b/drivers/isdn/hisax/config.c > @@ -1294,9 +1294,9 @@ void HiSax_reportcard(int cardnr, int sel) > printk(KERN_DEBUG "HiSax: reportcard No %d\n", cardnr + 1); > printk(KERN_DEBUG "HiSax: Type %s\n", CardType[cs->typ]); > printk(KERN_DEBUG "HiSax: debuglevel %x\n", cs->debug); > - printk(KERN_DEBUG "HiSax: HiSax_reportcard address 0x%lX\n", > - (ulong) & HiSax_reportcard); > - printk(KERN_DEBUG "HiSax: cs 0x%lX\n", (ulong) cs); > + printk(KERN_DEBUG "HiSax: HiSax_reportcard address 0x%px\n", > + HiSax_reportcard); > + printk(KERN_DEBUG "HiSax: cs 0x%px\n", cs); > printk(KERN_DEBUG "HiSax: HW_Flags %lx bc0 flg %lx bc1 flg %lx\n", > cs->HW_Flags, cs->bcs[0].Flag, cs->bcs[1].Flag); > printk(KERN_DEBUG "HiSax: bcs 0 mode %d ch%d\n", Why not just remove the useless prints. There is no context where a pointer has any meaning in userspace. Then again most of ISDN should probably go to staging anyway....