From: Bjorn Helgaas <helgaas@kernel.org>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: austin_bolen@dell.com, alex_gagniuc@dellteam.com,
keith.busch@intel.com, Shyam_Iyer@Dell.com, lukas@wunner.de,
okaya@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] PCI / ACPI: Do not export pci_get_hp_params()
Date: Mon, 22 Apr 2019 15:58:46 -0500 [thread overview]
Message-ID: <20190422205845.GM173520@google.com> (raw)
In-Reply-To: <20190208162414.3996-2-mr.nuke.me@gmail.com>
On Fri, Feb 08, 2019 at 10:24:11AM -0600, Alexandru Gagniuc wrote:
> This is only used within drivers/pci, and there is no reason to make
> it available outside of the PCI core.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Applied the whole series to pci/hotplug for v5.2, thanks!
I dropped the "list" member from struct hpx_type3 because it didn't
seem to be used.
> ---
> drivers/pci/pci-acpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index e1949f7efd9c..b25e5fa9d1c9 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -366,7 +366,6 @@ int pci_get_hp_params(struct pci_dev *dev, struct hotplug_params *hpp)
> }
> return -ENODEV;
> }
> -EXPORT_SYMBOL_GPL(pci_get_hp_params);
>
> /**
> * pciehp_is_native - Check whether a hotplug port is handled by the OS
> --
> 2.19.2
>
next prev parent reply other threads:[~2019-04-22 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190208162414.3996-1-mr.nuke.me@gmail.com>
2019-02-08 16:24 ` [PATCH v1 1/3] PCI / ACPI: Do not export pci_get_hp_params() Alexandru Gagniuc
2019-04-22 20:58 ` Bjorn Helgaas [this message]
2019-04-22 23:45 ` Alex G
2019-02-08 16:24 ` [PATCH v1 2/3] PCI / ACPI: Remove the need for 'struct hotplug_params' Alexandru Gagniuc
2019-04-19 20:07 ` Bjorn Helgaas
2019-04-19 22:02 ` Bjorn Helgaas
2019-02-08 16:24 ` [PATCH v1 3/3] PCI / ACPI: Implement Type 3 _HPX record Alexandru Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422205845.GM173520@google.com \
--to=helgaas@kernel.org \
--cc=Shyam_Iyer@Dell.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.