All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <natechancellor@gmail.com>
To: Paul Moore <paul@paul-moore.com>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	Eric Paris <eparis@parisplace.org>
Cc: selinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Nicolas Iooss <nicolas.iooss@m4x.org>
Subject: scripts/selinux build error in 4.14 after glibc update
Date: Mon, 22 Apr 2019 14:00:41 -0700	[thread overview]
Message-ID: <20190422210041.GA21711@archlinux-i9> (raw)

Hi all,

After a glibc update to 2.29, my 4.14 builds started failing like so:

$ make -j$(nproc) defconfig bzImage
HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
*** Default configuration is based on 'x86_64_defconfig'
#
# configuration written to .config
#
scripts/kconfig/conf  --silentoldconfig Kconfig
  SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
  SYSHDR  arch/x86/include/generated/asm/unistd_32_ia32.h
  SYSHDR  arch/x86/include/generated/asm/unistd_64_x32.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h
  SYSTBL  arch/x86/include/generated/asm/syscalls_64.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_x32.h
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  UPD     include/generated/uapi/linux/version.h
  DESCEND  objtool
  HOSTCC   /home/nathan/cbl/linux-stable/tools/objtool/fixdep.o
  HOSTLD   /home/nathan/cbl/linux-stable/tools/objtool/fixdep-in.o
  LINK     /home/nathan/cbl/linux-stable/tools/objtool/fixdep
  CC       /home/nathan/cbl/linux-stable/tools/objtool/builtin-check.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/builtin-orc.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/check.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/orc_gen.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/orc_dump.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/elf.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/special.o
  GEN      /home/nathan/cbl/linux-stable/tools/objtool/arch/x86/lib/inat-tables.c
  CC       /home/nathan/cbl/linux-stable/tools/objtool/objtool.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/libstring.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/str_error_r.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/exec-cmd.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/pager.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/help.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/parse-options.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/run-command.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/sigchain.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/subcmd-config.o
  CC       /home/nathan/cbl/linux-stable/tools/objtool/arch/x86/decode.o
  LD       /home/nathan/cbl/linux-stable/tools/objtool/libsubcmd-in.o
  LD       /home/nathan/cbl/linux-stable/tools/objtool/arch/x86/objtool-in.o
  LD       /home/nathan/cbl/linux-stable/tools/objtool/objtool-in.o
  AR       /home/nathan/cbl/linux-stable/tools/objtool/libsubcmd.a
  LINK     /home/nathan/cbl/linux-stable/tools/objtool/objtool
  UPD     include/config/kernel.release
  HOSTCC  arch/x86/tools/relocs_32.o
  HOSTCC  arch/x86/tools/relocs_common.o
  HOSTCC  arch/x86/tools/relocs_64.o
  WRAP    arch/x86/include/generated/asm/dma-contiguous.h
  WRAP    arch/x86/include/generated/asm/mcs_spinlock.h
  WRAP    arch/x86/include/generated/asm/clkdev.h
  WRAP    arch/x86/include/generated/asm/mm-arch-hooks.h
  WRAP    arch/x86/include/generated/asm/early_ioremap.h
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
  HOSTCC  scripts/kallsyms
  HOSTCC  scripts/pnmtologo
  HOSTCC  scripts/conmakehash
  HOSTCC  scripts/sortextable
  CC      scripts/mod/empty.o
  CC      scripts/mod/devicetable-offsets.s
  HOSTCC  scripts/mod/mk_elfconfig
  HOSTCC  scripts/selinux/mdp/mdp
  HOSTCC  scripts/selinux/genheaders/genheaders
In file included from scripts/selinux/genheaders/genheaders.c:19:
./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map.
 #error New address family defined, please update secclass_map.
  ^~~~~
make[4]: *** [scripts/Makefile.host:102: scripts/selinux/genheaders/genheaders] Error 1
make[3]: *** [scripts/Makefile.build:585: scripts/selinux/genheaders] Error 2
make[3]: *** Waiting for unfinished jobs....
In file included from scripts/selinux/mdp/mdp.c:49:
./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map.
 #error New address family defined, please update secclass_map.
  ^~~~~
make[4]: *** [scripts/Makefile.host:102: scripts/selinux/mdp/mdp] Error 1
make[3]: *** [scripts/Makefile.build:585: scripts/selinux/mdp] Error 2
make[2]: *** [scripts/Makefile.build:585: scripts/selinux] Error 2
make[2]: *** Waiting for unfinished jobs....
  HOSTLD  arch/x86/tools/relocs
  CHK     scripts/mod/devicetable-offsets.h
  UPD     scripts/mod/devicetable-offsets.h
  MKELF   scripts/mod/elfconfig.h
  HOSTCC  scripts/mod/modpost.o
  HOSTCC  scripts/mod/file2alias.o
  HOSTCC  scripts/mod/sumversion.o
  CHK     include/generated/timeconst.h
  CC      kernel/bounds.s
  UPD     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  UPD     include/generated/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
  HOSTLD  scripts/mod/modpost
make[1]: *** [Makefile:572: scripts] Error 2
make[1]: *** Waiting for unfinished jobs....
  CHK     include/generated/asm-offsets.h
  UPD     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
make: *** [Makefile:264: __build_one_by_one] Error 2

This is due to commit c017c71ce09f ("selinux: include sys/socket.h in
host programs to have PF_MAX") [1] in the kernel interacting poorly
with glibc's commit 38b0593e9a ("Add PF_XDP, AF_XDP and SOL_XDP from
Linux 4.18 to bits/socket.h.") [2]

I am not really sure how this should be fixed or who is at fault but I
didn't see it reported anywhere yet (I assume the kernel) and I feel
more comfortable on the kernel mailing list than other bug trackers so
here we are.

[1]: https://git.kernel.org/linus/c017c71ce09f4c7a5378fccbec6a3d7e96b0c5c2
[2]: https://sourceware.org/git/?p=glibc.git;a=commit;h=38b0593e9a862c3b35392a0f5b202696b8116aa3

Thanks,
Nathan

             reply	other threads:[~2019-04-22 21:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 21:00 Nathan Chancellor [this message]
2019-04-23  1:59 ` scripts/selinux build error in 4.14 after glibc update Paul Moore
2019-04-23  2:26   ` Nathan Chancellor
2019-04-23 13:29   ` Sasha Levin
2019-04-23 13:43     ` Paul Moore
2019-04-29 12:40       ` Greg KH
2019-04-29 14:02         ` Paul Moore
2019-04-29 14:09           ` Greg KH
2019-04-29 14:47             ` Paul Moore
2019-04-29 14:52               ` Greg KH
2019-04-29 22:37                 ` Paul Moore
2019-04-30  8:49                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190422210041.GA21711@archlinux-i9 \
    --to=natechancellor@gmail.com \
    --cc=eparis@parisplace.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.iooss@m4x.org \
    --cc=paul@paul-moore.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.