All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/dhcp: always disable zlib in bind library
Date: Mon, 22 Apr 2019 22:39:52 +0200	[thread overview]
Message-ID: <20190422223952.53412a78@windsurf> (raw)
In-Reply-To: <20190421171039.26556-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun, 21 Apr 2019 19:10:39 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> +#?Always disable zlib in bind library (like all other dependencies, see
> +#?bind/Makefile.in)

This reason looked suspicious to me, so I investigated, and indeed, I
think it's not the right fix.

> +DHCP_BIND_CONF_OPTS = --without-zlib
> +
>  ifeq ($(BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK),y)
>  DHCP_CONF_OPTS += --enable-delayed-ack
>  endif
>  
> -ifeq ($(BR2_PACKAGE_ZLIB),y)

The right fix is:

DHCP_DEPENDENCIES += zlib

> -DHCP_BIND_CONF_OPTS += --with-zlib
> -else
> -DHCP_BIND_CONF_OPTS += --without-zlib
> -endif

Thanks to this, zlib is properly built before dhcp, and everything
works fine.

I committed a fix that does this.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-04-22 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21 17:10 [Buildroot] [PATCH 1/1] package/dhcp: always disable zlib in bind library Fabrice Fontaine
2019-04-22 20:39 ` Thomas Petazzoni [this message]
2019-04-22 21:19   ` Fabrice Fontaine
2019-04-23  7:28     ` Thomas Petazzoni
2019-04-23  7:48       ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190422223952.53412a78@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.