Re: [PATCH] vlc: rework qt PACKAGECONFIG

[Adrian Bunk <bunk@stusta.de>]

On Tue, Apr 23, 2019 at 02:07:02AM +0200, Andreas Müller wrote:
> On Tue, Apr 23, 2019 at 1:55 AM Paul Barker <paul@betafive.co.uk> wrote:
> > On 23/04/2019 00:46, Andreas Müller wrote:
>...
> > > -PACKAGECONFIG ?= " live555 dc1394 dv1394 notify fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
> > > +PACKAGECONFIG ?= " \
> > > +    live555 dc1394 dv1394 notify fontconfig freetype dvdread png \
> > > +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
> > > +    ${@bb.utils.contains('BBFILE_COLLECTIONS', 'qt5-layer', 'qt5', '', d)} \
> >
> > I don't like this change based on BBFILE_COLLECTIONS, it's just a
> > different way of having things change when you add an extra layer. We
> > wouldn't want an unconditional bbappend in meta-qt5 to set this and so
> > we don't want to set it here when that layer is added.
> >
> > Perhaps we should have qt5 as a distro feature instead?
> Isn't that a different naming for the same thing not working properly
> if you don't have meta-qt5 in layers?

Isn't this a reason for moving vlc out of meta-openembedded?
Or alternatively moving qt5 to meta-openembedded.

> Andreas

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed