From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] [v7, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel Date: Tue, 23 Apr 2019 14:06:06 +0200 Message-ID: <20190423120606.GG23448@ulmo> References: <20190326070208.11788-1-hanxu5@huaqin.corp-partner.google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0923871751==" Return-path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E021890E5 for ; Tue, 23 Apr 2019 12:06:12 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h18so18561238wml.1 for ; Tue, 23 Apr 2019 05:06:12 -0700 (PDT) In-Reply-To: <20190326070208.11788-1-hanxu5@huaqin.corp-partner.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jerry Han Cc: Derek Basehore , Jitao Shi , Jerry Han , dri-devel@lists.freedesktop.org, Rock wang List-Id: dri-devel@lists.freedesktop.org --===============0923871751== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c7hkjup166d4FzgN" Content-Disposition: inline --c7hkjup166d4FzgN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 26, 2019 at 03:02:08PM +0800, Jerry Han wrote: > The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and > connected to DSI using four lanes. >=20 > V7: > - Add the information of the reviewer >=20 > V6: > - Add the information of the reviewer >=20 > V5: > - Added changelog >=20 > V4: > - None >=20 > V3: > - None >=20 > V2: > - Add compatible device "boe,himax8279d10p" (Sam) > - Add the necessary property descriptions (Sam) >=20 > Signed-off-by: Jerry Han > Reviewed-by: Sam Ravnborg > Reviewed-by: Derek Basehore > Cc: Jitao Shi > Cc: Rock wang > --- > .../bindings/display/panel/boe,himax8279d.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/boe,h= imax8279d.txt This is a device tree bindings patch, so it needs to be Cc'ed to the device tree maintainers for review. devicetree@vger.kernel.org should be in the Cc list, as should be Rob Herring, who does an excellent job at reviewing device tree bindings. Thierry >=20 > diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax827= 9d.txt b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt > new file mode 100644 > index 000000000000..3caea2172b1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt > @@ -0,0 +1,24 @@ > +Boe Himax8279d 1200x1920 TFT LCD panel > + > +Required properties: > +- compatible: should be "boe,himax8279d8p" and one of: "boe,himax8279d10= p" > +- reg: DSI virtual channel of the peripheral > +- enable-gpios: panel enable gpio > +- pp33-gpios: a GPIO phandle for the 3.3v pin that provides the supply v= oltage > +- pp18-gpios: a GPIO phandle for the 1.8v pin that provides the supply v= oltage > + > +Optional properties: > +- backlight: phandle of the backlight device attached to the panel > + > +Example: > + > + &mipi_dsi { > + panel { > + compatible =3D "boe,himax8279d8p", "boe,himax8279d10p"; > + reg =3D <0>; > + backlight =3D <&backlight>; > + enable-gpios =3D <&gpio 45 GPIO_ACTIVE_HIGH>; > + pp33-gpios =3D <&gpio 35 GPIO_ACTIVE_HIGH>; > + pp18-gpios =3D <&gpio 36 GPIO_ACTIVE_HIGH>; > + }; > + }; > --=20 > 2.17.1 >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --c7hkjup166d4FzgN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAly+/64ACgkQ3SOs138+ s6HTfg/9GjOXiet1YNjrkRn1khxRotjbKZqXfzH2Yu9/+7twZfsUwEbrDtNyZcC4 QGOoUXwy8RXx5zzkKYYtpPKFFmHV63d0szHnIzWTJ6YrZlCh+Z8Y1yGN2V5v9+ko ecS6vYj1eryEZR0AHLuenRgF0TQ7Y4kRJnoacgDJeonc6VPUwO/6ax+vlWVhEAGq LxCeDZ7AR1Z8tEChqI5FCyWEEq/INQ72GJ/uCFpUOL3SJXntrJNYstPDpVLHcrGZ WHWQICRVP7cmqu8mPuyBAkm7ChmT7oxBTXa3Z0QzhlRN4rLkgfiK0WAp+O4q74g7 q9AtJRI3/mTvJta/Yw7IA1V6pqBxCXfV9erdJr+ewficx2A6O3qzzV8OUr/aPe8V PCo9MrL77FL1eIX9WTj2EzaEFfFtZ3xzpgR1Mkd6+c/IBzUWK8gjqQHGWM90KjJ+ ut0WtOVLgiN1WUU7PoO4N4aYNFd3MxIEPzw822x/hQlj33k2tcao68gErQk4dua8 /v1CPahWM/S2lWDA/ky+/51BFba4JTk6zTtrS4w3INr7TcovF2tX/Fw5DwGJfGqN jJzDRiCRJY+4I4eoqmQGf9g7w6KT5lDp41ry8PyNnJjNgJ2jQHGAB0sHWzEqS4xr 11kbPqVd843LY7IU3kRr9FyqGnOfCQjUXzi7DG0Jz/uPUQps7e8= =S+MS -----END PGP SIGNATURE----- --c7hkjup166d4FzgN-- --===============0923871751== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0923871751==--