From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] [v7, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel Date: Tue, 23 Apr 2019 14:08:40 +0200 Message-ID: <20190423120840.GH23448@ulmo> References: <20190326070933.2735-1-hanxu5@huaqin.corp-partner.google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0146312128==" Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CC57890E5 for ; Tue, 23 Apr 2019 12:08:43 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id c5so11033578wrs.11 for ; Tue, 23 Apr 2019 05:08:43 -0700 (PDT) In-Reply-To: <20190326070933.2735-1-hanxu5@huaqin.corp-partner.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jerry Han Cc: Derek Basehore , Jitao Shi , Jerry Han , dri-devel@lists.freedesktop.org, Rock wang List-Id: dri-devel@lists.freedesktop.org --===============0146312128== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+Z7/5fzWRHDJ0o7Q" Content-Disposition: inline --+Z7/5fzWRHDJ0o7Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 26, 2019 at 03:09:33PM +0800, Jerry Han wrote: > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > panel. >=20 > V7: > - Add the information of the reviewer > - Remove unnecessary delays, The udelay_range code gracefully returns > without hitting the scheduler on a delay of 0. (Derek) > - Merge the same data structures, like display_mode and off_cmds (Derek) > - Optimize the processing of results returned by > devm_gpiod_get_optional (Derek) >=20 > V6: > - Add the information of the reviewer (Sam) > - Delete unnecessary header files #include (Sam) > - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sa= m) > - ADD static, set_gpios function is not used outside this module (Sam) >=20 > V5: > - Added changelog >=20 > V4: > - Frefix all function maes with boe_ (Sam) > - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam) > - Sort include lines alphabetically (Sam) > - Fixed entries in the makefile must be sorted alphabetically (Sam) > - Add send_mipi_cmds function to avoid duplicating the code (Sam) > - Add the necessary delay(reset_delay_t5) between reset and sending > the initialization command (Rock wang) >=20 > V3: > - Remove unnecessary delays in sending initialization commands (Jitao Shi) >=20 > V2: > - Use SPDX identifier (Sam) > - Use necessary header files replace drmP.h (Sam) > - Delete unnecessary header files #include (Sam) > - Specifies a GPIOs array to control the reset timing, > instead of reading "dsi-reset-sequence" data from DTS (Sam) > - Delete backlight_disable() function when already disabled (Sam) > - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam) > - Move the necessary data in the DTS to the current file, > like porch, display_mode and Init code etc. (Sam) > - Add compatible device "boe,himax8279d10p" (Sam) >=20 > Signed-off-by: Jerry Han The sign-off identity doesn't match the authorship information in the patch. You may want to fix your git configuration. Thierry --+Z7/5fzWRHDJ0o7Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAly/AEgACgkQ3SOs138+ s6HbZBAArcRE32RZsStqsW1si/7e5mwTqsAuw/GOzJ3l8hNX3JFDiZoOmT6oWI8A PHBXZHwYA88uvFMvkoen9Vz0bOSAtNoDP+2SRqk0DGEPtB2zkFLR8Jxlll9RGXxe lss64jn+Yg9EfxTO28xVRD6ZSJb+Tw30QZwyrE0Sx/2l0Ds7SlikjyS9aW5QR5GS L8TpGgX4RtbFBxFZKGapQEBS42eaDyAazB0qrB2KPW0T1joxNoeWOul6wACd7/1S h89ubE8NoGibeMHJ/6W3ZNFy59Bd+ckPlpkPODkzNNx8I4p+/9zX4N4BACuCHID6 5E9QKimdqYO+d15nle6/ubOn4wPYOIh62fVscdNGOmYg2wmzxKqdVjQwWx4JDRgg YsauNBxrI4GWA/62AW7yJgn2EzQaIEdH/fjIQPM20ULsQykMEe3p4ignJaKymZxd QRY3128reViAvCCozKcz3qfe1MgjuRD6E04NgC7NlvCHa/FObld0153vXlonb1QE Z9QWDEhjDddPreqq6J+RSYjJI3MzcrC7kJjnwteotgKivzd7W9gY2Fcz27m1hyIp /AcmgXaXy/RN5HkOkiI7IeaDVPjGtrhDdR7zzdn0SB9TF702PBYyEzIST1gYDuux 8hyY292u7jMl9eDwjn+UQRlc2s/tx3uoKiSWQ+ALum/kiG+/y6A= =A1K7 -----END PGP SIGNATURE----- --+Z7/5fzWRHDJ0o7Q-- --===============0146312128== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0146312128==--