From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: David.Francis-5C7GfCeVMHo@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [bug report] drm/amd/display: If one stream full updates, full update all planes
Date: Tue, 23 Apr 2019 17:10:56 +0300 [thread overview]
Message-ID: <20190423141056.GA8988@mwanda> (raw)
Hello David Francis,
This is a semi-automatic email about new static checker warnings.
The patch c238bfe0be9e: "drm/amd/display: If one stream full updates,
full update all planes" from Mar 29, 2019, leads to the following
Smatch complaint:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1492 det_surface_update()
warn: variable dereferenced before check 'u->surface' (see line 1467)
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c
1466
1467 if (u->surface->force_full_update) {
^^^^^^^^^^^^
The patch adds a new dereference
1468 update_flags->bits.full_update = 1;
1469 return UPDATE_TYPE_FULL;
1470 }
1471
1472 type = get_plane_info_update_type(u);
1473 elevate_update_type(&overall_type, type);
1474
1475 type = get_scaling_info_update_type(u);
1476 elevate_update_type(&overall_type, type);
1477
1478 if (u->in_transfer_func)
1479 update_flags->bits.in_transfer_func_change = 1;
1480
1481 if (u->input_csc_color_matrix)
1482 update_flags->bits.input_csc_change = 1;
1483
1484 if (u->coeff_reduction_factor)
1485 update_flags->bits.coeff_reduction_change = 1;
1486
1487 if (u->gamma) {
1488 enum surface_pixel_format format = SURFACE_PIXEL_FORMAT_GRPH_BEGIN;
1489
1490 if (u->plane_info)
1491 format = u->plane_info->format;
1492 else if (u->surface)
^^^^^^^^^^
But the old code assumed it could be NULL
1493 format = u->surface->format;
1494
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2019-04-23 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:10 Dan Carpenter [this message]
2019-04-23 14:16 ` [bug report] drm/amd/display: If one stream full updates, full update all planes Kazlauskas, Nicholas
[not found] ` <c5d7c58c-3c38-a2e7-4584-df3ac347de95-5C7GfCeVMHo@public.gmane.org>
2019-04-23 15:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423141056.GA8988@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=David.Francis-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.