From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A650C10F03 for ; Tue, 23 Apr 2019 14:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13FFE217D9 for ; Tue, 23 Apr 2019 14:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728197AbfDWO51 (ORCPT ); Tue, 23 Apr 2019 10:57:27 -0400 Received: from mga01.intel.com ([192.55.52.88]:1409 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727695AbfDWO5Z (ORCPT ); Tue, 23 Apr 2019 10:57:25 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 07:57:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="318257825" Received: from sbwarrax-mobl1.gar.corp.intel.com (HELO localhost) ([10.252.58.123]) by orsmga005.jf.intel.com with ESMTP; 23 Apr 2019 07:57:22 -0700 Date: Tue, 23 Apr 2019 17:57:14 +0300 From: Jarkko Sakkinen To: stable@vger.kernel.org Cc: Yue Haibing , James Morris Subject: Re: [PATCH v2] tpm: Fix the type of the return value in calc_tpm2_event_size() Message-ID: <20190423145714.GA30090@linux.intel.com> References: <20190423125816.17558-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423125816.17558-1-jarkko.sakkinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 23, 2019 at 03:58:16PM +0300, Jarkko Sakkinen wrote: > From: Yue Haibing > > calc_tpm2_event_size() has an invalid signature because > it returns a 'size_t' where as its signature says that > it returns 'int'. > > Cc: > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log") > Suggested-by: Jarkko Sakkinen > Signed-off-by: Yue Haibing > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Jarkko Sakkinen > Signed-off-by: James Morris > --- > backport v5.0.8 > fixed compilation issue > drivers/char/tpm/eventlog/tpm2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/eventlog/tpm2.c b/drivers/char/tpm/eventlog/tpm2.c > index d8b77133a83a..f824563fc28d 100644 > --- a/drivers/char/tpm/eventlog/tpm2.c > +++ b/drivers/char/tpm/eventlog/tpm2.c > @@ -37,8 +37,8 @@ > * > * Returns size of the event. If it is an invalid event, returns 0. > */ > -static int calc_tpm2_event_size(struct tcg_pcr_event2_head *event, > - struct tcg_pcr_event *event_header) > +static size_t calc_tpm2_event_size(struct tcg_pcr_event2_head *event, > + struct tcg_pcr_event *event_header) > { > struct tcg_efi_specid_event_head *efispecid; > struct tcg_event_field *event_field; > -- > 2.20.1 > This was a mistake. Please ignore. Sent another one. /Jarkko