From: Al Viro <viro@zeniv.linux.org.uk>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jannh@google.com, reiserfs-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reiserfs: Force type conversion in xattr_hash
Date: Tue, 23 Apr 2019 16:16:14 +0100 [thread overview]
Message-ID: <20190423151614.GN2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190423145237.GA3609@bharath12345-Inspiron-5559>
On Tue, Apr 23, 2019 at 08:22:37PM +0530, Bharath Vedartham wrote:
> > ISTR some discussions of reiserfs layout endianness problems, but
> > that had been many years ago and I could be wrong; I _think_
> > the conclusion had been "it sucks, but we can't do anything
> > without breaking existing filesystem images". Not sure if that
> > was the same bug or something different, though.
>
> Hi Al,
>
> Thanks for your detailed explanation. I learnt quite a bit from it.
> I agree we should not "supress" this bug.
>
> I have noticed in the reiserfs code that, a checksum mismatch only
> causes a warning? Even if there is a checksum mismatch, data still is
> copied to the buffer?
>
> What is the point of the checksum over here?
reiserfs_warning(inode->i_sb, "jdm-20002",
"Invalid hash for xattr (%s) associated "
"with %k", name, INODE_PKEY(inode));
err = -EIO;
IOW, reiserfs_xattr_get() fails on mismatch, not just whines into log.
prev parent reply other threads:[~2019-04-23 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 11:52 [PATCH] reiserfs: Force type conversion in xattr_hash Bharath Vedartham
2019-04-18 22:50 ` Andrew Morton
2019-04-19 6:08 ` Bharath Vedartham
2019-04-21 17:02 ` Al Viro
2019-04-22 19:27 ` Andrew Morton
2019-04-23 14:55 ` Bharath Vedartham
2019-04-23 14:52 ` Bharath Vedartham
2019-04-23 15:16 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423151614.GN2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.