From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B699C10F03 for ; Tue, 23 Apr 2019 16:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37485218C3 for ; Tue, 23 Apr 2019 16:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mDPUQdrc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbfDWQa3 (ORCPT ); Tue, 23 Apr 2019 12:30:29 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37886 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728609AbfDWQa3 (ORCPT ); Tue, 23 Apr 2019 12:30:29 -0400 Received: by mail-pf1-f193.google.com with SMTP id 8so7764473pfr.4 for ; Tue, 23 Apr 2019 09:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=uvxBqC5z1fQ7HokMwOAkHmie7D4nx4z/tsmnBoAzMY8=; b=mDPUQdrcGprnWmTuK7B2DCtRNejbN3ucXStEFI0mK8dfCIEspNYxtHYStYaHChZeRe M1YS4mqwXdgtvbkPNU6sraaV7N9yX/0OdR/Hj9zbrXEzhvRwsmR64rANQHeBw9V1YqZi kzY/R2RFEVDujLDs8cs3JuHHhJkmk3ID0NXBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=uvxBqC5z1fQ7HokMwOAkHmie7D4nx4z/tsmnBoAzMY8=; b=Rd9OdbyXHDanuPBK96GsgP+HcF9VHmkrNrrWu4+383VEdT168B66GcVCqhmbZGVTaY R7vlC2U0p/XKsRxLEP4vVga8qcgAn2hMePxnWcvZ3wspWVJogJsmoOQjK8g0+e+SGa/M yS0NDsMlOHGkW+Y4+nsWGQahDW2VAv8NJYL+NpQp098GCr4eaQS3j2ydVQp+nogHMtiY uZo8SN7cjJh4W24uoUmyERrN4Hmwub9NCWSrcSacCXZYou+h1J7HCucl1NUVMoy1qcMh meiwE+bNLvv95s81/ola3884sYhehdnwkJ4DMIq36bC3K/EqMpsFhFomxr8MQi/4aRQM 1pbg== X-Gm-Message-State: APjAAAVeoWZpHHD5iAz1uj+gd6GnUGCNME28/VTicDficHVBbc//Xl4O ZCsmua9b4riL99ebNWGvH60zLIJL9OLfEQ== X-Google-Smtp-Source: APXvYqw9oYKfqVRiUaTrnySkyB/IgFzgS9POTOKWWsxwWsimuD4pUxmn0Ij6ymrIq1+IcnhYvYYLGg== X-Received: by 2002:a63:4101:: with SMTP id o1mr26010382pga.17.1556037028200; Tue, 23 Apr 2019 09:30:28 -0700 (PDT) Received: from google.com ([2620:15c:202:201:49ea:b78f:4f04:4d25]) by smtp.googlemail.com with ESMTPSA id l15sm18540547pfi.79.2019.04.23.09.30.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 09:30:27 -0700 (PDT) Date: Tue, 23 Apr 2019 09:30:22 -0700 From: Zubin Mithra To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, groeck@chromium.org, darrick.wong@oracle.com, bo.li.liu@oracle.com, viro@zeniv.linux.org.uk Subject: 5a9d929d6e13 ("iomap: report collisions between directio and buffered writes to userspace") Message-ID: <20190423163021.GA185682@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hello, Syzkaller has triggered a kernel WARNING with the following stacktrace when fuzzing a 4.14 kernel. Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0xb7/0x107 lib/dump_stack.c:53 panic+0x1c9/0x3ae kernel/panic.c:181 __warn+0x160/0x1a8 kernel/panic.c:543 report_bug+0x123/0x18b lib/bug.c:186 fixup_bug+0x3e/0x77 arch/x86/kernel/traps.c:177 do_error_trap+0xdd/0x1e6 arch/x86/kernel/traps.c:295 invalid_op+0x1b/0x40 arch/x86/entry/entry_64.S:944 do_blockdev_direct_IO+0x1b08/0x1b95 fs/direct-io.c:1373 ext4_direct_IO_write fs/ext4/inode.c:3696 [inline] ext4_direct_IO+0x8de/0xdad fs/ext4/inode.c:3826 generic_file_direct_write+0x223/0x36b mm/filemap.c:2927 __generic_file_write_iter+0x12f/0x2f8 mm/filemap.c:3106 ext4_file_write_iter+0x97d/0xade fs/ext4/file.c:264 call_write_iter include/linux/fs.h:1782 [inline] do_iter_readv_writev+0x1e4/0x27c fs/read_write.c:678 do_iter_write+0x136/0x18f fs/read_write.c:957 vfs_iter_write+0x81/0x98 fs/read_write.c:970 iter_file_splice_write+0x4dc/0x7a6 fs/splice.c:749 do_splice_from fs/splice.c:851 [inline] direct_splice_actor+0x11e/0x129 fs/splice.c:1018 splice_direct_to_actor+0x342/0x5b0 fs/splice.c:973 do_splice_direct+0x180/0x1ff fs/splice.c:1061 do_sendfile+0x3e6/0x61c fs/read_write.c:1438 SYSC_sendfile64 fs/read_write.c:1499 [inline] SyS_sendfile64+0xe9/0x128 fs/read_write.c:1485 do_syscall_64+0x203/0x241 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x42/0xb7 Could the following patch be applied in order to v4.14.y(The patch is present in v4.19.y)? 5a9d929d6e13 ("iomap: report collisions between directio and buffered writes to userspace") Tests run: - Chrome OS tryjobs - Syzkaller reproducer Thanks, - Zubin