From: Bjorn Helgaas <helgaas@kernel.org>
To: Alex G <mr.nuke.me@gmail.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
linux-pci@vger.kernel.org, austin_bolen@dell.com,
alex_gagniuc@dellteam.com, keith.busch@intel.com,
Shyam_Iyer@Dell.com, lukas@wunner.de, okaya@kernel.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation
Date: Tue, 23 Apr 2019 12:10:50 -0500 [thread overview]
Message-ID: <20190423171050.GA37199@google.com> (raw)
In-Reply-To: <84300da7-9bbd-4f32-c7fa-23724db60b88@gmail.com>
On Tue, Apr 23, 2019 at 09:33:53AM -0500, Alex G wrote:
> On 4/22/19 7:33 PM, Alex Williamson wrote:
> > There is nothing wrong happening here that needs to fill logs. I
> > thought maybe if I enabled notification of autonomous bandwidth
> > changes that it might categorize these as something we could
> > ignore, but it doesn't. How can we identify only cases where this
> > is an erroneous/noteworthy situation? Thanks,
>
> You don't. Ethernet doesn't. USB doesn't. This logging behavior is
> consistent with every other subsystem that deals with multi-speed links.
Can you point me to the logging in these other subsystems so I can
learn more about how they deal with this?
I agree that emitting log messages for normal and expected events will
lead to user confusion and we need to do something.
e8303bb7a75c ("PCI/LINK: Report degraded links via link bandwidth
notification") was merged in v5.1-rc1, so we still have (a little)
time to figure this out before v5.1.
Bjorn
next prev parent reply other threads:[~2019-04-23 17:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 22:43 [PATCH] PCI/LINK: Account for BW notification in vector calculation Alex Williamson
2019-04-23 0:05 ` Alex G
2019-04-23 0:33 ` Alex Williamson
2019-04-23 14:33 ` Alex G
2019-04-23 15:34 ` Alex Williamson
2019-04-23 15:49 ` Lukas Wunner
2019-04-23 16:03 ` Alex G
2019-04-23 16:22 ` Alex Williamson
2019-04-23 16:27 ` Alex G
2019-04-23 16:37 ` Alex Williamson
2019-04-23 17:10 ` Bjorn Helgaas [this message]
2019-04-23 17:53 ` Alex G
2019-04-23 18:38 ` Alex Williamson
2019-04-23 17:59 ` Alex G
2019-05-01 20:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423171050.GA37199@google.com \
--to=helgaas@kernel.org \
--cc=Shyam_Iyer@Dell.com \
--cc=alex.williamson@redhat.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.