From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 08/10] drm/i915: Merge sbi read/write into a
 single accessor
Date: Tue, 23 Apr 2019 20:21:26 +0300
Message-ID: <20190423172126.GD1747@intel.com>
References: <20190419171402.30596-1-chris@chris-wilson.co.uk>
 <20190419171402.30596-9-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 910D789468
 for <intel-gfx@lists.freedesktop.org>; Tue, 23 Apr 2019 17:26:30 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190419171402.30596-9-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBBcHIgMTksIDIwMTkgYXQgMDY6MTQ6MDBQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFNpbmNlIGludGVsX3NpZGViYW5kX3JlYWQgYW5kIGludGVsX3NpZGViYW5kX3dyaXRl
IGRpZmZlciBieSBvbmx5IGEKPiBjb3VwbGUgb2YgbGluZXMgKGRlcGVuZGluZyBvbiB3aGV0aGVy
IHdlIGZlZWQgdGhlIHZhbHVlIGluIG9yIG91dCksCj4gbWVyZ2UgdGhlIHR3byBpbnRvIGEgc2lu
Z2xlIGNvbW1vbiBhY2Nlc3Nvci4KPiAKPiB2MjogUmVzdG9yZSB2bHZfZmxpc2RzaV9yZWFkKCkg
bG9zdCBkdXJpbmcgcmViYXNpbmcuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj
aHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpMb29rcyBlcXVpdmFsZW50CgpSZXZpZXdlZC1ieTog
VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4g
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NpZGViYW5kLmMgfCA5NCArKysrKysrKysrKy0t
LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDU2IGRl
bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9z
aWRlYmFuZC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYwo+IGluZGV4
IDVjM2FlNTE4NWEwMS4uNzExM2ZiODg1MGQ2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3NpZGViYW5kLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9zaWRlYmFuZC5jCj4gQEAgLTI3Myw4MSArMjczLDYzIEBAIHZvaWQgdmx2X2ZsaXNkc2lfd3Jp
dGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHUzMiByZWcsIHUzMiB2YWwpCj4gIH0K
PiAgCj4gIC8qIFNCSSBhY2Nlc3MgKi8KPiAtdTMyIGludGVsX3NiaV9yZWFkKHN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTE2IHJlZywKPiAtCQkgICBlbnVtIGludGVsX3NiaV9k
ZXN0aW5hdGlvbiBkZXN0aW5hdGlvbikKPiArc3RhdGljIGludCBpbnRlbF9zYmlfcncoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHUxNiByZWcsCj4gKwkJCWVudW0gaW50ZWxfc2JpX2Rl
c3RpbmF0aW9uIGRlc3RpbmF0aW9uLAo+ICsJCQl1MzIgKnZhbCwgYm9vbCBpc19yZWFkKQo+ICB7
Cj4gLQl1MzIgdmFsdWUgPSAwOwo+ICsJc3RydWN0IGludGVsX3VuY29yZSAqdW5jb3JlID0gJmk5
MTUtPnVuY29yZTsKPiArCXUzMiBjbWQ7Cj4gIAo+IC0JbG9ja2RlcF9hc3NlcnRfaGVsZCgmZGV2
X3ByaXYtPnNiX2xvY2spOwo+ICsJbG9ja2RlcF9hc3NlcnRfaGVsZCgmaTkxNS0+c2JfbG9jayk7
Cj4gIAo+IC0JaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKCZkZXZfcHJpdi0+dW5jb3JlLAo+
IC0JCQkJICAgIFNCSV9DVExfU1RBVCwgU0JJX0JVU1ksIDAsCj4gLQkJCQkgICAgMTAwKSkgewo+
ICsJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyX2Z3KHVuY29yZSwKPiArCQkJCSAgICAgICBT
QklfQ1RMX1NUQVQsIFNCSV9CVVNZLCAwLAo+ICsJCQkJICAgICAgIDEwMCkpIHsKPiAgCQlEUk1f
RVJST1IoInRpbWVvdXQgd2FpdGluZyBmb3IgU0JJIHRvIGJlY29tZSByZWFkeVxuIik7Cj4gLQkJ
cmV0dXJuIDA7Cj4gKwkJcmV0dXJuIC1FQlVTWTsKPiAgCX0KPiAgCj4gLQlJOTE1X1dSSVRFKFNC
SV9BRERSLCAocmVnIDw8IDE2KSk7Cj4gLQlJOTE1X1dSSVRFKFNCSV9EQVRBLCAwKTsKPiArCWlu
dGVsX3VuY29yZV93cml0ZV9mdyh1bmNvcmUsIFNCSV9BRERSLCAodTMyKXJlZyA8PCAxNik7Cj4g
KwlpbnRlbF91bmNvcmVfd3JpdGVfZncodW5jb3JlLCBTQklfREFUQSwgaXNfcmVhZCA/IDAgOiAq
dmFsKTsKPiAgCj4gIAlpZiAoZGVzdGluYXRpb24gPT0gU0JJX0lDTEspCj4gLQkJdmFsdWUgPSBT
QklfQ1RMX0RFU1RfSUNMSyB8IFNCSV9DVExfT1BfQ1JSRDsKPiArCQljbWQgPSBTQklfQ1RMX0RF
U1RfSUNMSyB8IFNCSV9DVExfT1BfQ1JSRDsKPiAgCWVsc2UKPiAtCQl2YWx1ZSA9IFNCSV9DVExf
REVTVF9NUEhZIHwgU0JJX0NUTF9PUF9JT1JEOwo+IC0JSTkxNV9XUklURShTQklfQ1RMX1NUQVQs
IHZhbHVlIHwgU0JJX0JVU1kpOwo+IC0KPiAtCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3Rlcigm
ZGV2X3ByaXYtPnVuY29yZSwKPiAtCQkJCSAgICBTQklfQ1RMX1NUQVQsCj4gLQkJCQkgICAgU0JJ
X0JVU1ksCj4gLQkJCQkgICAgMCwKPiAtCQkJCSAgICAxMDApKSB7Cj4gKwkJY21kID0gU0JJX0NU
TF9ERVNUX01QSFkgfCBTQklfQ1RMX09QX0lPUkQ7Cj4gKwlpZiAoIWlzX3JlYWQpCj4gKwkJY21k
IHw9IEJJVCg4KTsKPiArCWludGVsX3VuY29yZV93cml0ZV9mdyh1bmNvcmUsIFNCSV9DVExfU1RB
VCwgY21kIHwgU0JJX0JVU1kpOwo+ICsKPiArCWlmIChfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVy
X2Z3KHVuY29yZSwKPiArCQkJCQkgU0JJX0NUTF9TVEFULCBTQklfQlVTWSwgMCwKPiArCQkJCQkg
MTAwLCAxMDAsICZjbWQpKSB7Cj4gIAkJRFJNX0VSUk9SKCJ0aW1lb3V0IHdhaXRpbmcgZm9yIFNC
SSB0byBjb21wbGV0ZSByZWFkXG4iKTsKPiAtCQlyZXR1cm4gMDsKPiArCQlyZXR1cm4gLUVUSU1F
RE9VVDsKPiAgCX0KPiAgCj4gLQlpZiAoSTkxNV9SRUFEKFNCSV9DVExfU1RBVCkgJiBTQklfUkVT
UE9OU0VfRkFJTCkgewo+ICsJaWYgKGNtZCAmIFNCSV9SRVNQT05TRV9GQUlMKSB7Cj4gIAkJRFJN
X0VSUk9SKCJlcnJvciBkdXJpbmcgU0JJIHJlYWQgb2YgcmVnICV4XG4iLCByZWcpOwo+IC0JCXJl
dHVybiAwOwo+ICsJCXJldHVybiAtRU5YSU87Cj4gIAl9Cj4gIAo+IC0JcmV0dXJuIEk5MTVfUkVB
RChTQklfREFUQSk7Cj4gKwlpZiAoaXNfcmVhZCkKPiArCQkqdmFsID0gaW50ZWxfdW5jb3JlX3Jl
YWRfZncodW5jb3JlLCBTQklfREFUQSk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXZv
aWQgaW50ZWxfc2JpX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTE2
IHJlZywgdTMyIHZhbHVlLAo+IC0JCSAgICAgZW51bSBpbnRlbF9zYmlfZGVzdGluYXRpb24gZGVz
dGluYXRpb24pCj4gK3UzMiBpbnRlbF9zYmlfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
aTkxNSwgdTE2IHJlZywKPiArCQkgICBlbnVtIGludGVsX3NiaV9kZXN0aW5hdGlvbiBkZXN0aW5h
dGlvbikKPiAgewo+IC0JdTMyIHRtcDsKPiArCXUzMiByZXN1bHQgPSAwOwo+ICAKPiAtCWxvY2tk
ZXBfYXNzZXJ0X2hlbGQoJmRldl9wcml2LT5zYl9sb2NrKTsKPiArCWludGVsX3NiaV9ydyhpOTE1
LCByZWcsIGRlc3RpbmF0aW9uLCAmcmVzdWx0LCB0cnVlKTsKPiAgCj4gLQlpZiAoaW50ZWxfd2Fp
dF9mb3JfcmVnaXN0ZXIoJmRldl9wcml2LT51bmNvcmUsCj4gLQkJCQkgICAgU0JJX0NUTF9TVEFU
LCBTQklfQlVTWSwgMCwKPiAtCQkJCSAgICAxMDApKSB7Cj4gLQkJRFJNX0VSUk9SKCJ0aW1lb3V0
IHdhaXRpbmcgZm9yIFNCSSB0byBiZWNvbWUgcmVhZHlcbiIpOwo+IC0JCXJldHVybjsKPiAtCX0K
PiAtCj4gLQlJOTE1X1dSSVRFKFNCSV9BRERSLCAocmVnIDw8IDE2KSk7Cj4gLQlJOTE1X1dSSVRF
KFNCSV9EQVRBLCB2YWx1ZSk7Cj4gLQo+IC0JaWYgKGRlc3RpbmF0aW9uID09IFNCSV9JQ0xLKQo+
IC0JCXRtcCA9IFNCSV9DVExfREVTVF9JQ0xLIHwgU0JJX0NUTF9PUF9DUldSOwo+IC0JZWxzZQo+
IC0JCXRtcCA9IFNCSV9DVExfREVTVF9NUEhZIHwgU0JJX0NUTF9PUF9JT1dSOwo+IC0JSTkxNV9X
UklURShTQklfQ1RMX1NUQVQsIFNCSV9CVVNZIHwgdG1wKTsKPiAtCj4gLQlpZiAoaW50ZWxfd2Fp
dF9mb3JfcmVnaXN0ZXIoJmRldl9wcml2LT51bmNvcmUsCj4gLQkJCQkgICAgU0JJX0NUTF9TVEFU
LAo+IC0JCQkJICAgIFNCSV9CVVNZLAo+IC0JCQkJICAgIDAsCj4gLQkJCQkgICAgMTAwKSkgewo+
IC0JCURSTV9FUlJPUigidGltZW91dCB3YWl0aW5nIGZvciBTQkkgdG8gY29tcGxldGUgd3JpdGVc
biIpOwo+IC0JCXJldHVybjsKPiAtCX0KPiArCXJldHVybiByZXN1bHQ7Cj4gK30KPiAgCj4gLQlp
ZiAoSTkxNV9SRUFEKFNCSV9DVExfU1RBVCkgJiBTQklfUkVTUE9OU0VfRkFJTCkgewo+IC0JCURS
TV9FUlJPUigiZXJyb3IgZHVyaW5nIFNCSSB3cml0ZSBvZiAleCB0byByZWcgJXhcbiIsCj4gLQkJ
CSAgdmFsdWUsIHJlZyk7Cj4gLQkJcmV0dXJuOwo+IC0JfQo+ICt2b2lkIGludGVsX3NiaV93cml0
ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgdTE2IHJlZywgdTMyIHZhbHVlLAo+ICsJ
CSAgICAgZW51bSBpbnRlbF9zYmlfZGVzdGluYXRpb24gZGVzdGluYXRpb24pCj4gK3sKPiArCWlu
dGVsX3NiaV9ydyhpOTE1LCByZWcsIGRlc3RpbmF0aW9uLCAmdmFsdWUsIGZhbHNlKTsKPiAgfQo+
IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVl
ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=