From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=qyTB=SZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BD447C10F03
	for <netdev@archiver.kernel.org>; Tue, 23 Apr 2019 19:18:02 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7F8E8217D9
	for <netdev@archiver.kernel.org>; Tue, 23 Apr 2019 19:18:02 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="dkGyeG3P"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726075AbfDWTSB (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 23 Apr 2019 15:18:01 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:41860 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725956AbfDWTSB (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 23 Apr 2019 15:18:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=n8uvvqmTudUdS817EzPQlVD1D5xvBu9XTmGDOlG+MfI=; b=dkGyeG3PcenMyNj1yBe5FuniCF
        Fuj6y5+g0R7b0D3eZWhuW5hRnL8N0pfbu/f8mTPaPQ4le9vBe70pQoqgiU6ujHEIY2rJZT3wjl/6Q
        PasrbmjkFwiSy0t7GayOZpki98I7u87VwqzK5NhxGKPGXq2qPrbORQbjW+TPevpwtBwU=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hJ0vW-00028h-7B; Tue, 23 Apr 2019 21:17:58 +0200
Date:   Tue, 23 Apr 2019 21:17:58 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Nikita Danilov <Nikita.Danilov@aquantia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>,
        Yana Esina <yana.esina@aquantia.com>
Subject: Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for
 chip temperature
Message-ID: <20190423191758.GL28405@lunn.ch>
References: <cover.1556024424.git.igor.russkikh@aquantia.com>
 <869d56f1adaa7c16f067bfe4b2e8cd780a29beaf.1556024424.git.igor.russkikh@aquantia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <869d56f1adaa7c16f067bfe4b2e8cd780a29beaf.1556024424.git.igor.russkikh@aquantia.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> +static u32 aq_hwmon_temp_config[] = {
> +	HWMON_T_INPUT | HWMON_T_LABEL,
> +	0,

It would be nice to also have

        HWMON_T_MAX | HWMON_T_MIN |
        HWMON_T_CRIT | HWMON_T_LCRIT |

which the PHY probably has.

At gives some degree of context. A temperature on its own of say 65C
is hard to interpret. Is it too hot?  But if we have a critical of 85C
and a max of 95C we know we are O.K.

	 Andrew