From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [drm:drm-legacy-cleanup 17/24] drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended? Date: Wed, 24 Apr 2019 17:10:09 +0300 Message-ID: <20190424141008.GF14820@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kbuild-bounces@lists.01.org Sender: "kbuild" To: kbuild@01.org, Dave Airlie Cc: Daniel Vetter , kbuild-all@01.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org tree: git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup head: ee22f76306a68359c33809f8895eff603e71584b commit: 058ca50ce3f1d40dac4d918a91684b0af4a0c468 [17/24] drm/legacy: move lock cleanup for master into lock file (v2) If you fix the issue, kindly add following tag Reported-by: kbuild test robot Reported-by: Dan Carpenter smatch warnings: drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended? git remote add drm git://people.freedesktop.org/~airlied/linux.git git remote update drm git checkout 058ca50ce3f1d40dac4d918a91684b0af4a0c468 vim +359 drivers/gpu/drm/drm_lock.c 058ca50c Dave Airlie 2019-04-23 350 058ca50c Dave Airlie 2019-04-23 351 void drm_legacy_lock_master_cleanup(struct drm_device *dev, struct drm_master *master) 058ca50c Dave Airlie 2019-04-23 352 { 058ca50c Dave Airlie 2019-04-23 353 if (!drm_core_check_feature(dev, DRIVER_LEGACY)) 058ca50c Dave Airlie 2019-04-23 354 return; 058ca50c Dave Airlie 2019-04-23 355 058ca50c Dave Airlie 2019-04-23 356 /* 058ca50c Dave Airlie 2019-04-23 357 * Since the master is disappearing, so is the 058ca50c Dave Airlie 2019-04-23 358 * possibility to lock. 058ca50c Dave Airlie 2019-04-23 @359 */ mutex_lock(&dev->struct_mutex); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This should be moved to the next line. At first I thought it was part of the comment.