All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oscar Gomez Fuente <oscargomezf@gmail.com>
Cc: devel@driverdev.osuosl.org, tkjos@android.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
	arve@android.com, joel@joelfernandes.org, maco@android.com,
	christian@brauner.io
Subject: Re: [PATCH] staging: ion: solve warning symbol was not declared
Date: Wed, 24 Apr 2019 17:28:17 +0300	[thread overview]
Message-ID: <20190424142817.GD14798@kadam> (raw)
In-Reply-To: <1555958967-29149-1-git-send-email-oscargomezf@gmail.com>

On Mon, Apr 22, 2019 at 08:49:27PM +0200, Oscar Gomez Fuente wrote:
> These changes solve warning symbol was not declared in the functions:
> ion_carveout_heap_create and ion_chunk_heap_create
> 
> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> ---
>  drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
>  drivers/staging/android/ion/ion_chunk_heap.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c
> index bb9d614..3f359ae 100644
> --- a/drivers/staging/android/ion/ion_carveout_heap.c
> +++ b/drivers/staging/android/ion/ion_carveout_heap.c
> @@ -103,7 +103,7 @@ static struct ion_heap_ops carveout_heap_ops = {
>  	.unmap_kernel = ion_heap_unmap_kernel,
>  };
>  
> -struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size)
> +static inline struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size)

Why are you making it inline?  Btw, normally we just leave it for the
compiler to choose which functions to make inline.

regards,
dan carpenter

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oscar Gomez Fuente <oscargomezf@gmail.com>
Cc: devel@driverdev.osuosl.org, tkjos@android.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
	arve@android.com, joel@joelfernandes.org, maco@android.com,
	sumit.semwal@linaro.org, christian@brauner.io
Subject: Re: [PATCH] staging: ion: solve warning symbol was not declared
Date: Wed, 24 Apr 2019 17:28:17 +0300	[thread overview]
Message-ID: <20190424142817.GD14798@kadam> (raw)
In-Reply-To: <1555958967-29149-1-git-send-email-oscargomezf@gmail.com>

On Mon, Apr 22, 2019 at 08:49:27PM +0200, Oscar Gomez Fuente wrote:
> These changes solve warning symbol was not declared in the functions:
> ion_carveout_heap_create and ion_chunk_heap_create
> 
> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> ---
>  drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
>  drivers/staging/android/ion/ion_chunk_heap.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c
> index bb9d614..3f359ae 100644
> --- a/drivers/staging/android/ion/ion_carveout_heap.c
> +++ b/drivers/staging/android/ion/ion_carveout_heap.c
> @@ -103,7 +103,7 @@ static struct ion_heap_ops carveout_heap_ops = {
>  	.unmap_kernel = ion_heap_unmap_kernel,
>  };
>  
> -struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size)
> +static inline struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size)

Why are you making it inline?  Btw, normally we just leave it for the
compiler to choose which functions to make inline.

regards,
dan carpenter


  reply	other threads:[~2019-04-24 14:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 18:49 [PATCH] staging: ion: solve warning symbol was not declared Oscar Gomez Fuente
2019-04-24 14:28 ` Dan Carpenter [this message]
2019-04-24 14:28   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424142817.GD14798@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=arve@android.com \
    --cc=christian@brauner.io \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=oscargomezf@gmail.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.