From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: don't run get_page() on pages from non-bvec iov iter
Date: Wed, 24 Apr 2019 16:33:05 +0200 [thread overview]
Message-ID: <20190424143305.GA21209@lst.de> (raw)
In-Reply-To: <20190424110146.17343-1-ming.lei@redhat.com>
On Wed, Apr 24, 2019 at 07:01:46PM +0800, Ming Lei wrote:
> The refcount has been increased for pages retrieved from non-bvec iov iter
> via __bio_iov_iter_get_pages(), so don't need to do that again.
>
> Otherwise, IO pages are leaked easily.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2019-04-24 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 11:01 [PATCH] block: don't run get_page() on pages from non-bvec iov iter Ming Lei
2019-04-24 12:39 ` Chaitanya Kulkarni
2019-04-24 14:06 ` Jens Axboe
2019-04-24 14:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424143305.GA21209@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.