From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJJkl-00047e-P0 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 11:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJJkk-0004PS-II for qemu-devel@nongnu.org; Wed, 24 Apr 2019 11:24:07 -0400 Date: Wed, 24 Apr 2019 16:23:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190424152352.GL31388@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190424103747.10173-1-thuth@redhat.com> <20190424103747.10173-4-thuth@redhat.com> <167b6b7c-3fef-47e8-d30d-09abfe1e50ba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <167b6b7c-3fef-47e8-d30d-09abfe1e50ba@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Thomas Huth , qemu-devel@nongnu.org, Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Max Reitz , Alex =?utf-8?Q?Benn=C3=A9e?= , Li-Wen Hsu On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote: > On 4/24/19 5:37 AM, Thomas Huth wrote: > > bash is installed in a different directory on non-Linux systems like > > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > > there, too. > > These tests were obviously copy-and-pasted from a fork point prior to > commit 11a82d14. Is this a candidate for a checkpatch addition to reject any use of /bin/bash in scripts ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32329C10F11 for ; Wed, 24 Apr 2019 15:25:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00A3C218FD for ; Wed, 24 Apr 2019 15:25:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00A3C218FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJJm4-0004rl-VW for qemu-devel@archiver.kernel.org; Wed, 24 Apr 2019 11:25:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJJkl-00047e-P0 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 11:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJJkk-0004PS-II for qemu-devel@nongnu.org; Wed, 24 Apr 2019 11:24:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54398) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJJkh-0004LM-OF; Wed, 24 Apr 2019 11:24:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D754AC03D470; Wed, 24 Apr 2019 15:24:02 +0000 (UTC) Received: from redhat.com (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D9BE600C4; Wed, 24 Apr 2019 15:23:56 +0000 (UTC) Date: Wed, 24 Apr 2019 16:23:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eric Blake Message-ID: <20190424152352.GL31388@redhat.com> References: <20190424103747.10173-1-thuth@redhat.com> <20190424103747.10173-4-thuth@redhat.com> <167b6b7c-3fef-47e8-d30d-09abfe1e50ba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <167b6b7c-3fef-47e8-d30d-09abfe1e50ba@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 24 Apr 2019 15:24:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Fam Zheng , Kevin Wolf , Thomas Huth , Ed Maste , qemu-block@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Li-Wen Hsu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190424152352.YdffHi6NrQvIlju_BVQFjOeEAIPCnQ83vaCswiI2dPA@z> On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote: > On 4/24/19 5:37 AM, Thomas Huth wrote: > > bash is installed in a different directory on non-Linux systems like > > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > > there, too. > > These tests were obviously copy-and-pasted from a fork point prior to > commit 11a82d14. Is this a candidate for a checkpatch addition to reject any use of /bin/bash in scripts ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|