From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D876C282CE for ; Wed, 24 Apr 2019 16:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F04E208E4 for ; Wed, 24 Apr 2019 16:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732373AbfDXQQr (ORCPT ); Wed, 24 Apr 2019 12:16:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbfDXQQr (ORCPT ); Wed, 24 Apr 2019 12:16:47 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9F8430894F9; Wed, 24 Apr 2019 16:16:45 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.38]) by smtp.corp.redhat.com (Postfix) with SMTP id A8CD35D9C8; Wed, 24 Apr 2019 16:16:43 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 24 Apr 2019 18:16:45 +0200 (CEST) Date: Wed, 24 Apr 2019 18:16:42 +0200 From: Oleg Nesterov To: weizhenliang Cc: Christian Brauner , "ebiederm@xmission.com" , "colona@arista.com" , "akpm@linux-foundation.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "deepa.kernel@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: Re: [PATCH v4] signal: trace_signal_deliver when signal_group_exit Message-ID: <20190424161641.GI16167@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 24 Apr 2019 16:16:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/24, weizhenliang wrote: > > On 04/24, Oleg wrote: > >On 04/24, Christian Brauner wrote: > >> > >> On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote: > >> > >> > Reviewed-by: Oleg Nesterov > > > >Yes, but ... > > > >> > Reported-by: kbuild test robot > > > >Hmm, really? > > Yes, the kbuild test robot says that if I fix the problem with the third parameter type, > I should add this tag. What is wrong or missing? But this patch does not fix the problem reported by robot, your patch (which introduced that problem) was dropped, the problem has gone. With this "Reported-by: kbuild test robot " tag it looks as if test-robot has found the problem you are trying to fix: the lack of trace_signal_deliver(SIGKILL). Oleg.