From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 02/25] drm: kirin: Remove HISI_KIRIN_DW_DSI config option Date: Wed, 24 Apr 2019 18:56:29 +0200 Message-ID: <20190424165629.GA21067@ravnborg.org> References: <1556061656-1733-1-git-send-email-john.stultz@linaro.org> <1556061656-1733-3-git-send-email-john.stultz@linaro.org> <20190424163908.GB20110@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: John Stultz Cc: David Airlie , Chen Feng , lkml , dri-devel , Xinliang Liu , Xinwei Kong , Rongrong Zou List-Id: dri-devel@lists.freedesktop.org Hi John. > > > > Nice simplification. We are now down to two very small Kconfig files. > > Consider to merge them into one Kconfig file in the top-level dir. > > > > Part of this cleanup is so that we can add another device option in a > later commit (though not in this series), so unless folks are > generally wanting to consolidate Kconfigs into the top level, it may > be premature to do so now only to later undo it when there are more > kirin specific options. I'm fine with whichever, I just want to make > sure that's clear. I am just passing my reflections forward in a mail as I read the patches. Unless there is something that resemble a real bug then always do what you consider best. In this case keep the two Kconfig files. Sam