All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vaibhav Rustagi <vaibhavrustagi@google.com>
Cc: stable@vger.kernel.org, hannes@cmpxchg.org, tj@kernel.org,
	mhocko@suse.com, vdavydov.dev@gmail.com, guro@fb.com,
	riel@surriel.com, sfr@canb.auug.org.au,
	akpm@linux-foundation.org, torvalds@linux-foundation.org,
	Aditya Kali <adityakali@google.com>
Subject: Re: [For Stable] mm: memcontrol: fix excessive complexity in memory.stat reporting
Date: Wed, 24 Apr 2019 20:34:19 +0200	[thread overview]
Message-ID: <20190424183419.GB10495@kroah.com> (raw)
In-Reply-To: <CAMVonLhmPhcTVSAbZzCbmYQxRECWK+6bychxFzg232dtAXeqEA@mail.gmail.com>


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Apr 24, 2019 at 10:35:51AM -0700, Vaibhav Rustagi wrote:
> Apologies for sending a non-plain text e-mail previously.
> 
> This issue is encountered in the actual production environment by our
> customers where they are constantly creating containers
> and tearing them down (using kubernetes for the workload).  Kubernetes
> constantly reads the memory.stat file for accounting memory
> information and over time (around a week) the memcg's got accumulated
> and the response time for reading memory.stat increases and
> customer applications get affected.

Please define "affected".  Their apps still run properly, so all should
be fine, it would be kubernetes that sees the slowdowns, not the
application.  How exactly does this show up to an end-user?

> The repro steps mentioned previously was just used for testing the
> patches locally.
> 
> Yes, we are moving to 4.19 but are also supporting 4.14 till Jan 2020
> (so production environment will still contain 4.14 kernel)

If you are already moving to 4.19, this seems like a good as reason as
any (hint, I can give you more) to move off of 4.14 at this point in
time.  There's no real need to keep 4.14 around, given that you don't
have any out-of-tree code in your kernels, so all should be simple to
just update the next reboot, right?

thanks,

greg k-h

  reply	other threads:[~2019-04-24 18:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  5:35 [For Stable] mm: memcontrol: fix excessive complexity in memory.stat reporting Vaibhav Rustagi
2019-04-24 16:50 ` Greg KH
2019-04-24 17:35   ` Vaibhav Rustagi
2019-04-24 18:34     ` Greg KH [this message]
2019-04-30 20:41       ` Vaibhav Rustagi
2019-05-01  7:08         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2019-04-01 20:34 Vaibhav Rustagi
2019-04-02  5:24 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424183419.GB10495@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adityakali@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=mhocko@suse.com \
    --cc=riel@surriel.com \
    --cc=sfr@canb.auug.org.au \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vaibhavrustagi@google.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.