All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
	"Ewan D . Milne" <emilne@redhat.com>,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 2/2] scsi: core: avoid to pre-allocate big chunk for sg list
Date: Thu, 25 Apr 2019 08:45:21 +0800	[thread overview]
Message-ID: <20190425004520.GA22636@ming.t460p> (raw)
In-Reply-To: <20190424143833.GD21209@lst.de>

On Wed, Apr 24, 2019 at 04:38:33PM +0200, Christoph Hellwig wrote:
> On Wed, Apr 24, 2019 at 04:41:46PM +0800, Ming Lei wrote:
> > > This removes the last use of the first_chunk paramter to
> > > sg_free_table_chained, please remove the paramter in an additional
> > > patch.
> > 
> > NVMe FC/RDMA still uses first_chunk.
> 
> Looks like they need a similar treatment then :)

Yeah, I agree.

But the issue could be less serious for NVMe FC/RDMA because the queue
depth is often much small.

thanks,
Ming

      reply	other threads:[~2019-04-25  0:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23 10:32 [PATCH 0/2] scis: core: avoid big pre-allocation for sg list Ming Lei
2019-04-23 10:32 ` [PATCH 1/2] scsi: core: avoid to pre-allocate big chunk for protection meta data Ming Lei
2019-04-23 15:33   ` Bart Van Assche
2019-04-24  0:46     ` Ming Lei
2019-04-23 10:32 ` [PATCH 2/2] scsi: core: avoid to pre-allocate big chunk for sg list Ming Lei
2019-04-23 15:37   ` Bart Van Assche
2019-04-24  7:52     ` Ming Lei
2019-04-24 15:24       ` James Bottomley
2019-04-24 15:32         ` Bart Van Assche
2019-04-24 15:37           ` Jens Axboe
2019-04-24 15:49           ` James Bottomley
2019-04-24 16:09             ` Bart Van Assche
2019-04-24 16:17               ` James Bottomley
2019-04-24  5:53   ` Christoph Hellwig
2019-04-24  8:41     ` Ming Lei
2019-04-24 14:38       ` Christoph Hellwig
2019-04-25  0:45         ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190425004520.GA22636@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bvanassche@acm.org \
    --cc=emilne@redhat.com \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.