From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 00/21] Add MPEG-2 decoding to Rockchip VPU Date: Thu, 25 Apr 2019 11:36:39 +0200 Message-ID: <20190425113639.3294b6d9@collabora.com> References: <20190425071242.18315-1-boris.brezillon@collabora.com> <20190425100628.6f8e5894@collabora.com> <69d53367-f26a-a3cb-0221-7d9be02ade6e@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <69d53367-f26a-a3cb-0221-7d9be02ade6e-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Hans Verkuil Cc: Nicolas Dufresne , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Heiko Stuebner , Jonas Karlman , Tomasz Figa , Paul Kocialkowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sakari Ailus , Laurent Pinchart , Hans Verkuil , Mauro Carvalho Chehab , Ezequiel Garcia , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org T24gVGh1LCAyNSBBcHIgMjAxOSAxMDoyMToxNiArMDIwMApIYW5zIFZlcmt1aWwgPGh2ZXJrdWls QHhzNGFsbC5ubD4gd3JvdGU6Cgo+IE9uIDQvMjUvMTkgMTA6MDYgQU0sIEJvcmlzIEJyZXppbGxv biB3cm90ZToKPiA+IE9uIFRodSwgMjUgQXByIDIwMTkgMDk6MTI6MjEgKzAyMDAKPiA+IEJvcmlz IEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGNvbGxhYm9yYS5jb20+IHdyb3RlOgo+ID4gICAK PiA+PiBUaGlzIHNlcmllcyBpbnRyb2R1Y2VzIHRoZSBkZWNvZGluZyBpbmZyYXN0cnVjdHVyZSB0 aGF0IHdpbGwgYmUKPiA+PiB1c2VkIHRvIGFkZCBzdXBwb3J0IGZvciBvdGhlciBjb2RlY3Mgc3Vj aCBhcyBWUDgsIFZQOSBhbmQgSC4yNjQuCj4gPj4KPiA+PiBBcyBleHBsYWluZWQgaW4gdGhlIGNv dmVyIGxldHRlciBmb3IgdGhlIHYxIHBhdGNoc2V0LAo+ID4+IHRoZSBkcml2ZXIgaXMgbm93IGV4 cG9zaW5nIHR3byB2aWRlbyBkZXZpY2Ugbm9kZXMuCj4gPj4gVGhlIFZQVSBlbmNvZGVyIGlzIGV4 cG9zZWQgb24gL2Rldi92aWRlbzAsIGFuZCB0aGUgVlBVIGRlY29kZXIKPiA+PiBpcyBleHBvc2Vk IG9uIC9kZXYvdmlkZW8xLiBCb3RoIGRldmljZXMgYXJlIHRpZWQgdG8gdGhlIHNhbWUKPiA+PiBt ZW1vcnktdG8tbWVtb3J5IHF1ZXVlLCBhbmQgc2FtZSBtZWRpYSBkZXZpY2UgL2Rldi9tZWRpYTAu Cj4gPj4KPiA+PiBUaGVyZWZvcmUgdGhlcmUgYXJlIHR3byBtZWRpYSBncmFwaHM6Cj4gPj4KPiA+ PiDilIzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilJAKPiA+PiDilIIg cm9ja2NoaXAscmszMzk5LXZwdS1lbmMtc291cmNlIOKUggo+ID4+IOKUgiAgICAgICAgICAvZGV2 L3ZpZGVvMCAgICAgICAgICAg4pSCCj4gPj4g4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSYCj4gPj4gICDilIMKPiA+PiAgIOKUgwo+ID4+ICAg4pa8Cj4gPj4g4pSM 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSQCj4gPj4g4pSCICByb2Nr Y2hpcCxyazMzOTktdnB1LWVuYy1wcm9jICDilIIKPiA+PiDilJTilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilJgKPiA+PiAgIOKUgwo+ID4+ICAg4pSDCj4gPj4gICDilrwK PiA+PiDilIzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilJAKPiA+PiDi lIIgIHJvY2tjaGlwLHJrMzM5OS12cHUtZW5jLXNpbmsgIOKUggo+ID4+IOKUgiAgICAgICAgICAv ZGV2L3ZpZGVvMCAgICAgICAgICAg4pSCCj4gPj4g4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSYCj4gPj4KPiA+PiDilIzilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilJAKPiA+PiDilIIgcm9ja2NoaXAscmszMzk5LXZwdS1kZWMtc291cmNl IOKUggo+ID4+IOKUgiAgICAgICAgICAvZGV2L3ZpZGVvMSAgICAgICAgICAg4pSCCj4gPj4g4pSU 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSYCj4gPj4gICDilIMKPiA+ PiAgIOKUgwo+ID4+ICAg4pa8Cj4gPj4g4pSM4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSQCj4gPj4g4pSCICByb2NrY2hpcCxyazMzOTktdnB1LWRlYy1wcm9jICDilIIK PiA+PiDilJTilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilJgKPiA+PiAg IOKUgwo+ID4+ICAg4pSDCj4gPj4gICDilrwKPiA+PiDilIzilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilJAKPiA+PiDilIIgIHJvY2tjaGlwLHJrMzM5OS12cHUtZGVjLXNp bmsgIOKUggo+ID4+IOKUgiAgICAgICAgICAvZGV2L3ZpZGVvMSAgICAgICAgICAg4pSCCj4gPj4g 4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSYCj4gPj4KPiA+PiBP ZiBjb3Vyc2UsIHRoaXMgd29yayBoYXMgYmVlbiBwb3NzaWJsZSB0aGFua3MgdG8gSm9uYXMgS2Fy bG1hbiwgd2hvIGRpZAo+ID4+IHRoZSBpbml0aWFsIE1QRUctMiBkZWNvZGluZyB3b3JrIGFuZCBh bHNvIGdvdCBtcHYrZmZtcGVnIHdvcmtpbmcgdXNpbmcKPiA+PiB0aGUgUmVxdWVzdCBBUEkuICAK PiA+IAo+ID4gRm9yZ290IHRvIHByb3ZpZGUgdGhlIHY0bDItY29tcGxpYW5jZSByZXN1bHRzLCBz byBoZXJlIGl0IGlzOgo+ID4gCj4gPiAiCj4gPiB2NGwyLWNvbXBsaWFuY2UgU0hBOiA5NWYzOWFh ZTQ4YzZlOGU1Y2M4MWU2YWU2MjkzZDk5OWY3MGE5MDliLCA2NCBiaXRzCj4gPiAKPiA+IENvbXBs aWFuY2UgdGVzdCBmb3Igcm9ja2NoaXAtdnB1IGRldmljZSAvZGV2L21lZGlhMDoKPiA+IAo+ID4g TWVkaWEgRHJpdmVyIEluZm86Cj4gPiAJRHJpdmVyIG5hbWUgICAgICA6IHJvY2tjaGlwLXZwdQo+ ID4gCU1vZGVsICAgICAgICAgICAgOiByb2NrY2hpcC12cHUKPiA+IAlTZXJpYWwgICAgICAgICAg IDogCj4gPiAJQnVzIGluZm8gICAgICAgICA6IHBsYXRmb3JtOiByb2NrY2hpcC12cHUKPiA+IAlN ZWRpYSB2ZXJzaW9uICAgIDogNS4xLjAKPiA+IAlIYXJkd2FyZSByZXZpc2lvbjogMHgwMDAwMDAw MCAoMCkKPiA+IAlEcml2ZXIgdmVyc2lvbiAgIDogNS4xLjAKPiA+IAo+ID4gUmVxdWlyZWQgaW9j dGxzOgo+ID4gCXRlc3QgTUVESUFfSU9DX0RFVklDRV9JTkZPOiBPSwo+ID4gCj4gPiBBbGxvdyBm b3IgbXVsdGlwbGUgb3BlbnM6Cj4gPiAJdGVzdCBzZWNvbmQgL2Rldi9tZWRpYTAgb3BlbjogT0sK PiA+IAl0ZXN0IE1FRElBX0lPQ19ERVZJQ0VfSU5GTzogT0sKPiA+IAl0ZXN0IGZvciB1bmxpbWl0 ZWQgb3BlbnM6IE9LCj4gPiAKPiA+IE1lZGlhIENvbnRyb2xsZXIgaW9jdGxzOgo+ID4gCXRlc3Qg TUVESUFfSU9DX0dfVE9QT0xPR1k6IE9LCj4gPiAJRW50aXRpZXM6IDYgSW50ZXJmYWNlczogMiBQ YWRzOiA4IExpbmtzOiA4Cj4gPiAJdGVzdCBNRURJQV9JT0NfRU5VTV9FTlRJVElFUy9MSU5LUzog T0sKPiA+IAl0ZXN0IE1FRElBX0lPQ19TRVRVUF9MSU5LOiBPSwo+ID4gCj4gPiBUb3RhbCBmb3Ig cm9ja2NoaXAtdnB1IGRldmljZSAvZGV2L21lZGlhMDogNywgU3VjY2VlZGVkOiA3LCBGYWlsZWQ6 IDAsIFdhcm5pbmdzOiAwCj4gPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gQ29tcGxpYW5j ZSB0ZXN0IGZvciByb2NrY2hpcC12cHUgZGV2aWNlIC9kZXYvdmlkZW8wOgo+ID4gCj4gPiBEcml2 ZXIgSW5mbzoKPiA+IAlEcml2ZXIgbmFtZSAgICAgIDogcm9ja2NoaXAtdnB1Cj4gPiAJQ2FyZCB0 eXBlICAgICAgICA6IHJvY2tjaGlwLHJrMzM5OS12cHUtZW5jCj4gPiAJQnVzIGluZm8gICAgICAg ICA6IHBsYXRmb3JtOiByb2NrY2hpcC12cHUKPiA+IAlEcml2ZXIgdmVyc2lvbiAgIDogNS4xLjAK PiA+IAlDYXBhYmlsaXRpZXMgICAgIDogMHg4NDIwNDAwMAo+ID4gCQlWaWRlbyBNZW1vcnktdG8t TWVtb3J5IE11bHRpcGxhbmFyCj4gPiAJCVN0cmVhbWluZwo+ID4gCQlFeHRlbmRlZCBQaXggRm9y bWF0Cj4gPiAJCURldmljZSBDYXBhYmlsaXRpZXMKPiA+IAlEZXZpY2UgQ2FwcyAgICAgIDogMHgw NDIwNDAwMAo+ID4gCQlWaWRlbyBNZW1vcnktdG8tTWVtb3J5IE11bHRpcGxhbmFyCj4gPiAJCVN0 cmVhbWluZwo+ID4gCQlFeHRlbmRlZCBQaXggRm9ybWF0Cj4gPiAJRGV0ZWN0ZWQgSlBFRyBFbmNv ZGVyCj4gPiBNZWRpYSBEcml2ZXIgSW5mbzoKPiA+IAlEcml2ZXIgbmFtZSAgICAgIDogcm9ja2No aXAtdnB1Cj4gPiAJTW9kZWwgICAgICAgICAgICA6IHJvY2tjaGlwLXZwdQo+ID4gCVNlcmlhbCAg ICAgICAgICAgOiAKPiA+IAlCdXMgaW5mbyAgICAgICAgIDogcGxhdGZvcm06IHJvY2tjaGlwLXZw dQo+ID4gCU1lZGlhIHZlcnNpb24gICAgOiA1LjEuMAo+ID4gCUhhcmR3YXJlIHJldmlzaW9uOiAw eDAwMDAwMDAwICgwKQo+ID4gCURyaXZlciB2ZXJzaW9uICAgOiA1LjEuMAo+ID4gSW50ZXJmYWNl IEluZm86Cj4gPiAJSUQgICAgICAgICAgICAgICA6IDB4MDMwMDAwMGMKPiA+IAlUeXBlICAgICAg ICAgICAgIDogVjRMIFZpZGVvCj4gPiBFbnRpdHkgSW5mbzoKPiA+IAlJRCAgICAgICAgICAgICAg IDogMHgwMDAwMDAwMSAoMSkKPiA+IAlOYW1lICAgICAgICAgICAgIDogcm9ja2NoaXAscmszMzk5 LXZwdS1lbmMtc291cmNlCj4gPiAJRnVuY3Rpb24gICAgICAgICA6IFY0TDIgSS9PCj4gPiAJUGFk IDB4MDEwMDAwMDIgICA6IDA6IFNvdXJjZQo+ID4gCSAgTGluayAweDAyMDAwMDA4OiB0byByZW1v dGUgcGFkIDB4MTAwMDAwNSBvZiBlbnRpdHkgJ3JvY2tjaGlwLHJrMzM5OS12cHUtZW5jLXByb2Mn OiBEYXRhLCBFbmFibGVkLCBJbW11dGFibGUKPiA+IAo+ID4gUmVxdWlyZWQgaW9jdGxzOgo+ID4g CXRlc3QgTUMgaW5mb3JtYXRpb24gKHNlZSAnTWVkaWEgRHJpdmVyIEluZm8nIGFib3ZlKTogT0sK PiA+IAl0ZXN0IFZJRElPQ19RVUVSWUNBUDogT0sKPiA+IAo+ID4gQWxsb3cgZm9yIG11bHRpcGxl IG9wZW5zOgo+ID4gCXRlc3Qgc2Vjb25kIC9kZXYvdmlkZW8wIG9wZW46IE9LCj4gPiAJdGVzdCBW SURJT0NfUVVFUllDQVA6IE9LCj4gPiAJdGVzdCBWSURJT0NfRy9TX1BSSU9SSVRZOiBPSwo+ID4g CXRlc3QgZm9yIHVubGltaXRlZCBvcGVuczogT0sKPiA+IAo+ID4gRGVidWcgaW9jdGxzOgo+ID4g CXRlc3QgVklESU9DX0RCR19HL1NfUkVHSVNURVI6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRl c3QgVklESU9DX0xPR19TVEFUVVM6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCj4gPiBJbnB1dCBp b2N0bHM6Cj4gPiAJdGVzdCBWSURJT0NfRy9TX1RVTkVSL0VOVU1fRlJFUV9CQU5EUzogT0sgKE5v dCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJT0NfRy9TX0ZSRVFVRU5DWTogT0sgKE5vdCBTdXBw b3J0ZWQpCj4gPiAJdGVzdCBWSURJT0NfU19IV19GUkVRX1NFRUs6IE9LIChOb3QgU3VwcG9ydGVk KQo+ID4gCXRlc3QgVklESU9DX0VOVU1BVURJTzogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVz dCBWSURJT0NfRy9TL0VOVU1JTlBVVDogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJ T0NfRy9TX0FVRElPOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAlJbnB1dHM6IDAgQXVkaW8gSW5w dXRzOiAwIFR1bmVyczogMAo+ID4gCj4gPiBPdXRwdXQgaW9jdGxzOgo+ID4gCXRlc3QgVklESU9D X0cvU19NT0RVTEFUT1I6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgVklESU9DX0cvU19G UkVRVUVOQ1k6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgVklESU9DX0VOVU1BVURPVVQ6 IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgVklESU9DX0cvUy9FTlVNT1VUUFVUOiBPSyAo Tm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19HL1NfQVVET1VUOiBPSyAoTm90IFN1cHBv cnRlZCkKPiA+IAlPdXRwdXRzOiAwIEF1ZGlvIE91dHB1dHM6IDAgTW9kdWxhdG9yczogMAo+ID4g Cj4gPiBJbnB1dC9PdXRwdXQgY29uZmlndXJhdGlvbiBpb2N0bHM6Cj4gPiAJdGVzdCBWSURJT0Nf RU5VTS9HL1MvUVVFUllfU1REOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19F TlVNL0cvUy9RVUVSWV9EVl9USU1JTkdTOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJ RElPQ19EVl9USU1JTkdTX0NBUDogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJT0Nf Ry9TX0VESUQ6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCj4gPiBDb250cm9sIGlvY3RsczoKPiA+ IAl0ZXN0IFZJRElPQ19RVUVSWV9FWFRfQ1RSTC9RVUVSWU1FTlU6IE9LCj4gPiAJdGVzdCBWSURJ T0NfUVVFUllDVFJMOiBPSwo+ID4gCXRlc3QgVklESU9DX0cvU19DVFJMOiBPSwo+ID4gCXRlc3Qg VklESU9DX0cvUy9UUllfRVhUX0NUUkxTOiBPSwo+ID4gCXRlc3QgVklESU9DXyhVTilTVUJTQ1JJ QkVfRVZFTlQvRFFFVkVOVDogT0sKPiA+IAl0ZXN0IFZJRElPQ19HL1NfSlBFR0NPTVA6IE9LIChO b3QgU3VwcG9ydGVkKQo+ID4gCVN0YW5kYXJkIENvbnRyb2xzOiAyIFByaXZhdGUgQ29udHJvbHM6 IDAKPiA+IAo+ID4gRm9ybWF0IGlvY3RsczoKPiA+IAl0ZXN0IFZJRElPQ19FTlVNX0ZNVC9GUkFN RVNJWkVTL0ZSQU1FSU5URVJWQUxTOiBPSwo+ID4gCXRlc3QgVklESU9DX0cvU19QQVJNOiBPSyAo Tm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19HX0ZCVUY6IE9LIChOb3QgU3VwcG9ydGVk KQo+ID4gCXRlc3QgVklESU9DX0dfRk1UOiBPSwo+ID4gCXRlc3QgVklESU9DX1RSWV9GTVQ6IE9L Cj4gPiAJdGVzdCBWSURJT0NfU19GTVQ6IE9LCj4gPiAJdGVzdCBWSURJT0NfR19TTElDRURfVkJJ X0NBUDogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBDcm9wcGluZzogT0sgKE5vdCBTdXBw b3J0ZWQpCj4gPiAJdGVzdCBDb21wb3Npbmc6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3Qg U2NhbGluZzogT0sKPiA+IAo+ID4gQ29kZWMgaW9jdGxzOgo+ID4gCXRlc3QgVklESU9DXyhUUllf KUVOQ09ERVJfQ01EOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19HX0VOQ19J TkRFWDogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJT0NfKFRSWV8pREVDT0RFUl9D TUQ6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCj4gPiBCdWZmZXIgaW9jdGxzOgo+ID4gCQlmYWls OiB2NGwyLXRlc3QtYnVmZmVycy5jcHAoNzA5KTogcS5jcmVhdGVfYnVmcyhub2RlLCAxLCAmZm10 KSAhPSBFSU5WQUwKPiA+IAl0ZXN0IFZJRElPQ19SRVFCVUZTL0NSRUFURV9CVUZTL1FVRVJZQlVG OiBGQUlMCj4gPiAJdGVzdCBWSURJT0NfRVhQQlVGOiBPSwo+ID4gdGVzdFJlcXVlc3RzOjE3NjAg cmV0IDAKPiA+IAkJZmFpbDogdjRsMi10ZXN0LWJ1ZmZlcnMuY3BwKDE4MjApOiAhc3VwcG9ydHNf cmVxdWVzdHMKPiA+IAl0ZXN0IFJlcXVlc3RzOiBGQUlMCj4gPiAKPiA+IFRvdGFsIGZvciByb2Nr Y2hpcC12cHUgZGV2aWNlIC9kZXYvdmlkZW8wOiA0NSwgU3VjY2VlZGVkOiA0MywgRmFpbGVkOiAy LCBXYXJuaW5nczogMAo+ID4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+IENvbXBsaWFuY2Ug dGVzdCBmb3Igcm9ja2NoaXAtdnB1IGRldmljZSAvZGV2L3ZpZGVvMToKPiA+IAo+ID4gRHJpdmVy IEluZm86Cj4gPiAJRHJpdmVyIG5hbWUgICAgICA6IHJvY2tjaGlwLXZwdQo+ID4gCUNhcmQgdHlw ZSAgICAgICAgOiByb2NrY2hpcCxyazMzOTktdnB1LWRlYwo+ID4gCUJ1cyBpbmZvICAgICAgICAg OiBwbGF0Zm9ybTogcm9ja2NoaXAtdnB1Cj4gPiAJRHJpdmVyIHZlcnNpb24gICA6IDUuMS4wCj4g PiAJQ2FwYWJpbGl0aWVzICAgICA6IDB4ODQyMDQwMDAKPiA+IAkJVmlkZW8gTWVtb3J5LXRvLU1l bW9yeSBNdWx0aXBsYW5hcgo+ID4gCQlTdHJlYW1pbmcKPiA+IAkJRXh0ZW5kZWQgUGl4IEZvcm1h dAo+ID4gCQlEZXZpY2UgQ2FwYWJpbGl0aWVzCj4gPiAJRGV2aWNlIENhcHMgICAgICA6IDB4MDQy MDQwMDAKPiA+IAkJVmlkZW8gTWVtb3J5LXRvLU1lbW9yeSBNdWx0aXBsYW5hcgo+ID4gCQlTdHJl YW1pbmcKPiA+IAkJRXh0ZW5kZWQgUGl4IEZvcm1hdAo+ID4gCURldGVjdGVkIFN0YXRlbGVzcyBE ZWNvZGVyCj4gPiBNZWRpYSBEcml2ZXIgSW5mbzoKPiA+IAlEcml2ZXIgbmFtZSAgICAgIDogcm9j a2NoaXAtdnB1Cj4gPiAJTW9kZWwgICAgICAgICAgICA6IHJvY2tjaGlwLXZwdQo+ID4gCVNlcmlh bCAgICAgICAgICAgOiAKPiA+IAlCdXMgaW5mbyAgICAgICAgIDogcGxhdGZvcm06IHJvY2tjaGlw LXZwdQo+ID4gCU1lZGlhIHZlcnNpb24gICAgOiA1LjEuMAo+ID4gCUhhcmR3YXJlIHJldmlzaW9u OiAweDAwMDAwMDAwICgwKQo+ID4gCURyaXZlciB2ZXJzaW9uICAgOiA1LjEuMAo+ID4gSW50ZXJm YWNlIEluZm86Cj4gPiAJSUQgICAgICAgICAgICAgICA6IDB4MDMwMDAwMWEKPiA+IAlUeXBlICAg ICAgICAgICAgIDogVjRMIFZpZGVvCj4gPiBFbnRpdHkgSW5mbzoKPiA+IAlJRCAgICAgICAgICAg ICAgIDogMHgwMDAwMDAwZiAoMTUpCj4gPiAJTmFtZSAgICAgICAgICAgICA6IHJvY2tjaGlwLHJr MzM5OS12cHUtZGVjLXNvdXJjZQo+ID4gCUZ1bmN0aW9uICAgICAgICAgOiBWNEwyIEkvTwo+ID4g CVBhZCAweDAxMDAwMDEwICAgOiAwOiBTb3VyY2UKPiA+IAkgIExpbmsgMHgwMjAwMDAxNjogdG8g cmVtb3RlIHBhZCAweDEwMDAwMTMgb2YgZW50aXR5ICdyb2NrY2hpcCxyazMzOTktdnB1LWRlYy1w cm9jJzogRGF0YSwgRW5hYmxlZCwgSW1tdXRhYmxlCj4gPiAKPiA+IFJlcXVpcmVkIGlvY3RsczoK PiA+IAl0ZXN0IE1DIGluZm9ybWF0aW9uIChzZWUgJ01lZGlhIERyaXZlciBJbmZvJyBhYm92ZSk6 IE9LCj4gPiAJdGVzdCBWSURJT0NfUVVFUllDQVA6IE9LCj4gPiAKPiA+IEFsbG93IGZvciBtdWx0 aXBsZSBvcGVuczoKPiA+IAl0ZXN0IHNlY29uZCAvZGV2L3ZpZGVvMSBvcGVuOiBPSwo+ID4gCXRl c3QgVklESU9DX1FVRVJZQ0FQOiBPSwo+ID4gCXRlc3QgVklESU9DX0cvU19QUklPUklUWTogT0sK PiA+IAl0ZXN0IGZvciB1bmxpbWl0ZWQgb3BlbnM6IE9LCj4gPiAKPiA+IERlYnVnIGlvY3RsczoK PiA+IAl0ZXN0IFZJRElPQ19EQkdfRy9TX1JFR0lTVEVSOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+ IAl0ZXN0IFZJRElPQ19MT0dfU1RBVFVTOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAo+ID4gSW5w dXQgaW9jdGxzOgo+ID4gCXRlc3QgVklESU9DX0cvU19UVU5FUi9FTlVNX0ZSRVFfQkFORFM6IE9L IChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgVklESU9DX0cvU19GUkVRVUVOQ1k6IE9LIChOb3Qg U3VwcG9ydGVkKQo+ID4gCXRlc3QgVklESU9DX1NfSFdfRlJFUV9TRUVLOiBPSyAoTm90IFN1cHBv cnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19FTlVNQVVESU86IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4g CXRlc3QgVklESU9DX0cvUy9FTlVNSU5QVVQ6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3Qg VklESU9DX0cvU19BVURJTzogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJSW5wdXRzOiAwIEF1ZGlv IElucHV0czogMCBUdW5lcnM6IDAKPiA+IAo+ID4gT3V0cHV0IGlvY3RsczoKPiA+IAl0ZXN0IFZJ RElPQ19HL1NfTU9EVUxBVE9SOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19H L1NfRlJFUVVFTkNZOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19FTlVNQVVE T1VUOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19HL1MvRU5VTU9VVFBVVDog T0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJT0NfRy9TX0FVRE9VVDogT0sgKE5vdCBT dXBwb3J0ZWQpCj4gPiAJT3V0cHV0czogMCBBdWRpbyBPdXRwdXRzOiAwIE1vZHVsYXRvcnM6IDAK PiA+IAo+ID4gSW5wdXQvT3V0cHV0IGNvbmZpZ3VyYXRpb24gaW9jdGxzOgo+ID4gCXRlc3QgVklE SU9DX0VOVU0vRy9TL1FVRVJZX1NURDogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJ T0NfRU5VTS9HL1MvUVVFUllfRFZfVElNSU5HUzogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVz dCBWSURJT0NfRFZfVElNSU5HU19DQVA6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgVklE SU9DX0cvU19FRElEOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAo+ID4gQ29udHJvbCBpb2N0bHM6 Cj4gPiAJdGVzdCBWSURJT0NfUVVFUllfRVhUX0NUUkwvUVVFUllNRU5VOiBPSwo+ID4gCXRlc3Qg VklESU9DX1FVRVJZQ1RSTDogT0sKPiA+IAl0ZXN0IFZJRElPQ19HL1NfQ1RSTDogT0sKPiA+IAkJ ZmFpbDogdjRsMi10ZXN0LWNvbnRyb2xzLmNwcCg2NzMpOiB0cnlfZXh0X2N0cmxzIHJldHVybmVk IGFuIGVycm9yICgyMikKPiA+IAl0ZXN0IFZJRElPQ19HL1MvVFJZX0VYVF9DVFJMUzogRkFJTAo+ ID4gCXRlc3QgVklESU9DXyhVTilTVUJTQ1JJQkVfRVZFTlQvRFFFVkVOVDogT0sKPiA+IAl0ZXN0 IFZJRElPQ19HL1NfSlBFR0NPTVA6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCVN0YW5kYXJkIENv bnRyb2xzOiAyIFByaXZhdGUgQ29udHJvbHM6IDAKPiA+IAo+ID4gRm9ybWF0IGlvY3RsczoKPiA+ IAl0ZXN0IFZJRElPQ19FTlVNX0ZNVC9GUkFNRVNJWkVTL0ZSQU1FSU5URVJWQUxTOiBPSwo+ID4g CXRlc3QgVklESU9DX0cvU19QQVJNOiBPSyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElP Q19HX0ZCVUY6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgVklESU9DX0dfRk1UOiBPSwo+ ID4gCXRlc3QgVklESU9DX1RSWV9GTVQ6IE9LCj4gPiAJCWZhaWw6IHY0bDItdGVzdC1mb3JtYXRz LmNwcCg4MDYpOiBmbXRfY2FwLmdfY29sb3JzcGFjZSgpICE9IGNvbAo+ID4gCXRlc3QgVklESU9D X1NfRk1UOiBGQUlMCj4gPiAJdGVzdCBWSURJT0NfR19TTElDRURfVkJJX0NBUDogT0sgKE5vdCBT dXBwb3J0ZWQpCj4gPiAJdGVzdCBDcm9wcGluZzogT0sgKE5vdCBTdXBwb3J0ZWQpCj4gPiAJdGVz dCBDb21wb3Npbmc6IE9LIChOb3QgU3VwcG9ydGVkKQo+ID4gCXRlc3QgU2NhbGluZzogT0sKPiA+ IAo+ID4gQ29kZWMgaW9jdGxzOgo+ID4gCXRlc3QgVklESU9DXyhUUllfKUVOQ09ERVJfQ01EOiBP SyAoTm90IFN1cHBvcnRlZCkKPiA+IAl0ZXN0IFZJRElPQ19HX0VOQ19JTkRFWDogT0sgKE5vdCBT dXBwb3J0ZWQpCj4gPiAJdGVzdCBWSURJT0NfKFRSWV8pREVDT0RFUl9DTUQ6IE9LIChOb3QgU3Vw cG9ydGVkKQo+ID4gCj4gPiBCdWZmZXIgaW9jdGxzOgo+ID4gCQlmYWlsOiB2NGwyLXRlc3QtYnVm ZmVycy5jcHAoNzA5KTogcS5jcmVhdGVfYnVmcyhub2RlLCAxLCAmZm10KSAhPSBFSU5WQUwKPiA+ IAl0ZXN0IFZJRElPQ19SRVFCVUZTL0NSRUFURV9CVUZTL1FVRVJZQlVGOiBGQUlMCj4gPiAJdGVz dCBWSURJT0NfRVhQQlVGOiBPSwo+ID4gCXRlc3QgUmVxdWVzdHM6IE9LIChOb3QgU3VwcG9ydGVk KQo+ID4gCj4gPiBUb3RhbCBmb3Igcm9ja2NoaXAtdnB1IGRldmljZSAvZGV2L3ZpZGVvMTogNDUs IFN1Y2NlZWRlZDogNDIsIEZhaWxlZDogMywgV2FybmluZ3M6IDAKPiA+IAo+ID4gR3JhbmQgVG90 YWwgZm9yIHJvY2tjaGlwLXZwdSBkZXZpY2UgL2Rldi9tZWRpYTA6IDk3LCBTdWNjZWVkZWQ6IDky LCBGYWlsZWQ6IDUsIFdhcm5pbmdzOiAwCj4gPiAKPiA+ICIKPiA+IAo+ID4gMiBvZiB0aG9zZSBm YWlsdXJlcyBhcmUgZXhwZWN0ZWQ6IAo+ID4gCj4gPiAqICJmYWlsOiB2NGwyLXRlc3QtZm9ybWF0 cy5jcHAoODA2KTogZm10X2NhcC5nX2NvbG9yc3BhY2UoKSAhPSBjb2wiOiBpcyBjYXVzZWQKPiA+ ICAgYnkgdGhlIHJlc2V0IGRvbmUgYnkgdGhlIGRyaXZlciBvbiB0aGUgbm9uLWNvZGVkIGVuZCB3 aGVuIHRoZSBjb2RlZCBlbmQgb2YKPiA+ICAgdGhlIHBpcGVsaW5lIGlzIG1vZGlmaWVkICh3aGlj aCBmb2xsb3dzIHRoZSBiZWhhdmlvciBkZXNjcmliZWQgaW4gc3RhdGVsZXNzCj4gPiAgIGRlY29k ZXIgc3BlYykgIAo+IAo+IFNvIGlzIHRoaXMgYSBkcml2ZXIgRklYTUUsIG9yIGFuIGlzc3VlIGlu IHRoZSBjb21wbGlhbmNlIHRlc3QgaXRzZWxmPwoKTG9va3MgbGlrZSB0aGUgc3BlYyBtYW5kYXRl cyB0aGUgb3Bwb3NpdGUsIHNvIGl0J3MgYSBkcml2ZXIgYnVnLiBJJ2xsCmZpeCB0aGF0LiBUaGUg bWFpbiBpc3N1ZSBJIHNlZSBpcyB0aGF0IHRoZSBSSyBlbmNvZGVyIGNvZGUgaGFzIHRoaXMKY29t bWVudDoKCiAgICAgICAgLyoKICAgICAgICAgKiBDdXJyZW50IHJhdyBmb3JtYXQgbWlnaHQgaGF2 ZSBiZWNvbWUgaW52YWxpZCB3aXRoIG5ld2x5CiAgICAgICAgICogc2VsZWN0ZWQgY29kZWMsIHNv IHJlc2V0IGl0IHRvIGRlZmF1bHQganVzdCB0byBiZSBzYWZlIGFuZAogICAgICAgICAqIGtlZXAg aW50ZXJuYWwgZHJpdmVyIHN0YXRlIHNhbmUuIFVzZXIgaXMgbWFuZGF0ZWQgdG8gc2V0CiAgICAg ICAgICogdGhlIHJhdyBmb3JtYXQgYWdhaW4gYWZ0ZXIgd2UgcmV0dXJuLCBzbyB3ZSBkb24ndCBu ZWVkCiAgICAgICAgICogYW55dGhpbmcgc21hcnRlci4KICAgICAgICAgKi8KCkRvZXMgdGhhdCBt ZWFuIHdlIGhhdmUgYSBkaWZmZXJlbnQgYmVoYXZpb3IgYmV0d2VlbiBlbmNvZGVycyBhbmQKZGVj b2RlcnM/Cgo+IAo+ID4gCj4gPiAqICJmYWlsOiB2NGwyLXRlc3QtY29udHJvbHMuY3BwKDY3Myk6 IHRyeV9leHRfY3RybHMgcmV0dXJuZWQgYW4gZXJyb3IgKDIyKSI6Cj4gPiAgIGRlZmF1bHQgdmFs dWVzIGZvciBtcGVnMiBjdHJscyBhcmUgbm90IHN1aXRhYmxlLCBzbyBkb2luZwo+ID4gICBnZXRf ZXh0X2N0cmwoKSt0cnlfZXh0X2N0cmwoKSBkb2VzIG5vdCB3b3JrLiAgCj4gCj4gSG1tLCB0aGlz IG1pZ2h0IHJlcXVpcmUgc29tZSBjaGFuZ2VzIHRvIHRoaXMgdGVzdC4gV2hlcmUgZG9lcyBpdCBm YWlsIGluIHRoZQo+IGRyaXZlcj8gSXMgdGhhdCB0aGUgc3RkX3ZhbGlkYXRlKCkgY2hlY2sgaW4g djRsMi1jdHJscy5jPwoKRG9uJ3QgcmVtZW1iZXIgd2hlcmUgaXQgY29tcGxhaW5lZCBleGFjdGx5 LCBidXQgaXQgd2FzIGluIHNvbWUgZ2VuZXJpYwpmdW5jdGlvbiwgeWVzLgoKPiAKPiBJZiBzbywg dGhlbiBJIHRoaW5rIGl0IHdvdWxkIGJlIHdpc2UgdG8gYWRkIGFuIGluaXRpYWxpemVyIGZvciBW NEwyX0NUUkxfVFlQRV9NUEVHMl9TTElDRV9QQVJBTVMKPiB0byBzdGRfaW5pdCgpIHNvIHRoYXQg aXQgY3JlYXRlcyBhIHByb3BlciBkZWZhdWx0LgoKT2theS4KCj4gCj4gSSBhbHNvIG5vdGljZWQg dGhhdCBzdXBwb3J0IGZvciB0aGVzZSBuZXcgY29tcG91bmQgdHlwZXMgaXMgbWlzc2luZyBpbgo+ IHRoZSBzdGRfbG9nKCkgZnVuY3Rpb24gaW4gdjRsMi1jdHJscy5jLiBJdCBzaG91bGQgcHJvYmFi bHkgbG9nIHRoZQo+IHR5cGUuIENoZWNrIHdpdGggdjRsMi1jdGwgLS1sb2ctc3RhdHVzIHRvIHNl ZSBob3cgaXQgbG9va3MgaW4gdGhlCj4ga2VybmVsIGxvZy4KCldpbGwgbG9vayBhdCBpdCB0b28u Cgo+IE9idmlvdXNseSwgdGhpcyBjYW4gYmUgZG9uZSBpbiBhIHNlcGFyYXRlIHBhdGNoIHNpbmNl IGl0J3MKPiBpbmRlcGVuZGVudCBvZiB0aGUgcm9ja2NoaXAgZHJpdmVyLgoKU3VyZS4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlw IG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF70FC10F03 for ; Thu, 25 Apr 2019 09:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CFDE20685 for ; Thu, 25 Apr 2019 09:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727536AbfDYJgr convert rfc822-to-8bit (ORCPT ); Thu, 25 Apr 2019 05:36:47 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33166 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfDYJgq (ORCPT ); Thu, 25 Apr 2019 05:36:46 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 56C1326104F; Thu, 25 Apr 2019 10:36:43 +0100 (BST) Date: Thu, 25 Apr 2019 11:36:39 +0200 From: Boris Brezillon To: Hans Verkuil Cc: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Sakari Ailus , linux-media@vger.kernel.org, Tomasz Figa , Nicolas Dufresne , kernel@collabora.com, Paul Kocialkowski , Ezequiel Garcia , Jonas Karlman , linux-rockchip@lists.infradead.org, Heiko Stuebner Subject: Re: [PATCH v4 00/21] Add MPEG-2 decoding to Rockchip VPU Message-ID: <20190425113639.3294b6d9@collabora.com> In-Reply-To: <69d53367-f26a-a3cb-0221-7d9be02ade6e@xs4all.nl> References: <20190425071242.18315-1-boris.brezillon@collabora.com> <20190425100628.6f8e5894@collabora.com> <69d53367-f26a-a3cb-0221-7d9be02ade6e@xs4all.nl> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 25 Apr 2019 10:21:16 +0200 Hans Verkuil wrote: > On 4/25/19 10:06 AM, Boris Brezillon wrote: > > On Thu, 25 Apr 2019 09:12:21 +0200 > > Boris Brezillon wrote: > > > >> This series introduces the decoding infrastructure that will be > >> used to add support for other codecs such as VP8, VP9 and H.264. > >> > >> As explained in the cover letter for the v1 patchset, > >> the driver is now exposing two video device nodes. > >> The VPU encoder is exposed on /dev/video0, and the VPU decoder > >> is exposed on /dev/video1. Both devices are tied to the same > >> memory-to-memory queue, and same media device /dev/media0. > >> > >> Therefore there are two media graphs: > >> > >> ┌────────────────────────────────┐ > >> │ rockchip,rk3399-vpu-enc-source │ > >> │ /dev/video0 │ > >> └────────────────────────────────┘ > >> ┃ > >> ┃ > >> ▼ > >> ┌────────────────────────────────┐ > >> │ rockchip,rk3399-vpu-enc-proc │ > >> └────────────────────────────────┘ > >> ┃ > >> ┃ > >> ▼ > >> ┌────────────────────────────────┐ > >> │ rockchip,rk3399-vpu-enc-sink │ > >> │ /dev/video0 │ > >> └────────────────────────────────┘ > >> > >> ┌────────────────────────────────┐ > >> │ rockchip,rk3399-vpu-dec-source │ > >> │ /dev/video1 │ > >> └────────────────────────────────┘ > >> ┃ > >> ┃ > >> ▼ > >> ┌────────────────────────────────┐ > >> │ rockchip,rk3399-vpu-dec-proc │ > >> └────────────────────────────────┘ > >> ┃ > >> ┃ > >> ▼ > >> ┌────────────────────────────────┐ > >> │ rockchip,rk3399-vpu-dec-sink │ > >> │ /dev/video1 │ > >> └────────────────────────────────┘ > >> > >> Of course, this work has been possible thanks to Jonas Karlman, who did > >> the initial MPEG-2 decoding work and also got mpv+ffmpeg working using > >> the Request API. > > > > Forgot to provide the v4l2-compliance results, so here it is: > > > > " > > v4l2-compliance SHA: 95f39aae48c6e8e5cc81e6ae6293d999f70a909b, 64 bits > > > > Compliance test for rockchip-vpu device /dev/media0: > > > > Media Driver Info: > > Driver name : rockchip-vpu > > Model : rockchip-vpu > > Serial : > > Bus info : platform: rockchip-vpu > > Media version : 5.1.0 > > Hardware revision: 0x00000000 (0) > > Driver version : 5.1.0 > > > > Required ioctls: > > test MEDIA_IOC_DEVICE_INFO: OK > > > > Allow for multiple opens: > > test second /dev/media0 open: OK > > test MEDIA_IOC_DEVICE_INFO: OK > > test for unlimited opens: OK > > > > Media Controller ioctls: > > test MEDIA_IOC_G_TOPOLOGY: OK > > Entities: 6 Interfaces: 2 Pads: 8 Links: 8 > > test MEDIA_IOC_ENUM_ENTITIES/LINKS: OK > > test MEDIA_IOC_SETUP_LINK: OK > > > > Total for rockchip-vpu device /dev/media0: 7, Succeeded: 7, Failed: 0, Warnings: 0 > > -------------------------------------------------------------------------------- > > Compliance test for rockchip-vpu device /dev/video0: > > > > Driver Info: > > Driver name : rockchip-vpu > > Card type : rockchip,rk3399-vpu-enc > > Bus info : platform: rockchip-vpu > > Driver version : 5.1.0 > > Capabilities : 0x84204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > > Device Capabilities > > Device Caps : 0x04204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > > Detected JPEG Encoder > > Media Driver Info: > > Driver name : rockchip-vpu > > Model : rockchip-vpu > > Serial : > > Bus info : platform: rockchip-vpu > > Media version : 5.1.0 > > Hardware revision: 0x00000000 (0) > > Driver version : 5.1.0 > > Interface Info: > > ID : 0x0300000c > > Type : V4L Video > > Entity Info: > > ID : 0x00000001 (1) > > Name : rockchip,rk3399-vpu-enc-source > > Function : V4L2 I/O > > Pad 0x01000002 : 0: Source > > Link 0x02000008: to remote pad 0x1000005 of entity 'rockchip,rk3399-vpu-enc-proc': Data, Enabled, Immutable > > > > Required ioctls: > > test MC information (see 'Media Driver Info' above): OK > > test VIDIOC_QUERYCAP: OK > > > > Allow for multiple opens: > > test second /dev/video0 open: OK > > test VIDIOC_QUERYCAP: OK > > test VIDIOC_G/S_PRIORITY: OK > > test for unlimited opens: OK > > > > Debug ioctls: > > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > > test VIDIOC_LOG_STATUS: OK (Not Supported) > > > > Input ioctls: > > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > > test VIDIOC_ENUMAUDIO: OK (Not Supported) > > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > > test VIDIOC_G/S_AUDIO: OK (Not Supported) > > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > > > Output ioctls: > > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > > > Input/Output configuration ioctls: > > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > > test VIDIOC_G/S_EDID: OK (Not Supported) > > > > Control ioctls: > > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK > > test VIDIOC_QUERYCTRL: OK > > test VIDIOC_G/S_CTRL: OK > > test VIDIOC_G/S/TRY_EXT_CTRLS: OK > > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK > > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > > Standard Controls: 2 Private Controls: 0 > > > > Format ioctls: > > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > > test VIDIOC_G/S_PARM: OK (Not Supported) > > test VIDIOC_G_FBUF: OK (Not Supported) > > test VIDIOC_G_FMT: OK > > test VIDIOC_TRY_FMT: OK > > test VIDIOC_S_FMT: OK > > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > > test Cropping: OK (Not Supported) > > test Composing: OK (Not Supported) > > test Scaling: OK > > > > Codec ioctls: > > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > > > Buffer ioctls: > > fail: v4l2-test-buffers.cpp(709): q.create_bufs(node, 1, &fmt) != EINVAL > > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL > > test VIDIOC_EXPBUF: OK > > testRequests:1760 ret 0 > > fail: v4l2-test-buffers.cpp(1820): !supports_requests > > test Requests: FAIL > > > > Total for rockchip-vpu device /dev/video0: 45, Succeeded: 43, Failed: 2, Warnings: 0 > > -------------------------------------------------------------------------------- > > Compliance test for rockchip-vpu device /dev/video1: > > > > Driver Info: > > Driver name : rockchip-vpu > > Card type : rockchip,rk3399-vpu-dec > > Bus info : platform: rockchip-vpu > > Driver version : 5.1.0 > > Capabilities : 0x84204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > > Device Capabilities > > Device Caps : 0x04204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > > Detected Stateless Decoder > > Media Driver Info: > > Driver name : rockchip-vpu > > Model : rockchip-vpu > > Serial : > > Bus info : platform: rockchip-vpu > > Media version : 5.1.0 > > Hardware revision: 0x00000000 (0) > > Driver version : 5.1.0 > > Interface Info: > > ID : 0x0300001a > > Type : V4L Video > > Entity Info: > > ID : 0x0000000f (15) > > Name : rockchip,rk3399-vpu-dec-source > > Function : V4L2 I/O > > Pad 0x01000010 : 0: Source > > Link 0x02000016: to remote pad 0x1000013 of entity 'rockchip,rk3399-vpu-dec-proc': Data, Enabled, Immutable > > > > Required ioctls: > > test MC information (see 'Media Driver Info' above): OK > > test VIDIOC_QUERYCAP: OK > > > > Allow for multiple opens: > > test second /dev/video1 open: OK > > test VIDIOC_QUERYCAP: OK > > test VIDIOC_G/S_PRIORITY: OK > > test for unlimited opens: OK > > > > Debug ioctls: > > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > > test VIDIOC_LOG_STATUS: OK (Not Supported) > > > > Input ioctls: > > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > > test VIDIOC_ENUMAUDIO: OK (Not Supported) > > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > > test VIDIOC_G/S_AUDIO: OK (Not Supported) > > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > > > Output ioctls: > > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > > > Input/Output configuration ioctls: > > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > > test VIDIOC_G/S_EDID: OK (Not Supported) > > > > Control ioctls: > > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK > > test VIDIOC_QUERYCTRL: OK > > test VIDIOC_G/S_CTRL: OK > > fail: v4l2-test-controls.cpp(673): try_ext_ctrls returned an error (22) > > test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL > > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK > > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > > Standard Controls: 2 Private Controls: 0 > > > > Format ioctls: > > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > > test VIDIOC_G/S_PARM: OK (Not Supported) > > test VIDIOC_G_FBUF: OK (Not Supported) > > test VIDIOC_G_FMT: OK > > test VIDIOC_TRY_FMT: OK > > fail: v4l2-test-formats.cpp(806): fmt_cap.g_colorspace() != col > > test VIDIOC_S_FMT: FAIL > > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > > test Cropping: OK (Not Supported) > > test Composing: OK (Not Supported) > > test Scaling: OK > > > > Codec ioctls: > > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > > > Buffer ioctls: > > fail: v4l2-test-buffers.cpp(709): q.create_bufs(node, 1, &fmt) != EINVAL > > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL > > test VIDIOC_EXPBUF: OK > > test Requests: OK (Not Supported) > > > > Total for rockchip-vpu device /dev/video1: 45, Succeeded: 42, Failed: 3, Warnings: 0 > > > > Grand Total for rockchip-vpu device /dev/media0: 97, Succeeded: 92, Failed: 5, Warnings: 0 > > > > " > > > > 2 of those failures are expected: > > > > * "fail: v4l2-test-formats.cpp(806): fmt_cap.g_colorspace() != col": is caused > > by the reset done by the driver on the non-coded end when the coded end of > > the pipeline is modified (which follows the behavior described in stateless > > decoder spec) > > So is this a driver FIXME, or an issue in the compliance test itself? Looks like the spec mandates the opposite, so it's a driver bug. I'll fix that. The main issue I see is that the RK encoder code has this comment: /* * Current raw format might have become invalid with newly * selected codec, so reset it to default just to be safe and * keep internal driver state sane. User is mandated to set * the raw format again after we return, so we don't need * anything smarter. */ Does that mean we have a different behavior between encoders and decoders? > > > > > * "fail: v4l2-test-controls.cpp(673): try_ext_ctrls returned an error (22)": > > default values for mpeg2 ctrls are not suitable, so doing > > get_ext_ctrl()+try_ext_ctrl() does not work. > > Hmm, this might require some changes to this test. Where does it fail in the > driver? Is that the std_validate() check in v4l2-ctrls.c? Don't remember where it complained exactly, but it was in some generic function, yes. > > If so, then I think it would be wise to add an initializer for V4L2_CTRL_TYPE_MPEG2_SLICE_PARAMS > to std_init() so that it creates a proper default. Okay. > > I also noticed that support for these new compound types is missing in > the std_log() function in v4l2-ctrls.c. It should probably log the > type. Check with v4l2-ctl --log-status to see how it looks in the > kernel log. Will look at it too. > Obviously, this can be done in a separate patch since it's > independent of the rockchip driver. Sure.