From: Jon Doron <arilou@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jon Doron <arilou@gmail.com>
Subject: [Qemu-devel] [PATCH v6 21/21] gdbstub: Clear unused variables in gdb_handle_packet
Date: Thu, 25 Apr 2019 16:26:36 +0300 [thread overview]
Message-ID: <20190425132636.31636-22-arilou@gmail.com> (raw)
In-Reply-To: <20190425132636.31636-1-arilou@gmail.com>
Signed-off-by: Jon Doron <arilou@gmail.com>
---
gdbstub.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 8838241209..32aeefbbe6 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2268,17 +2268,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void *user_ctx)
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
- const char *p;
- int ch;
- uint8_t mem_buf[MAX_PACKET_LENGTH];
- char buf[sizeof(mem_buf) + 1 /* trailing NUL */];
const GdbCmdParseEntry *cmd_parser = NULL;
trace_gdbstub_io_command(line_buf);
- p = line_buf;
- ch = *p++;
- switch(ch) {
+ switch(line_buf[0]) {
case '!':
put_packet(s, "OK");
break;
@@ -2495,8 +2489,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
break;
default:
/* put empty packet */
- buf[0] = '\0';
- put_packet(s, buf);
+ put_packet(s, "");
break;
}
--
2.20.1
next prev parent reply other threads:[~2019-04-25 13:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 13:26 [Qemu-devel] [PATCH v6 00/21] gdbstub: Refactor command packets handler Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 01/21] gdbstub: Add infrastructure to parse cmd packets Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 02/21] gdbstub: Implement deatch (D pkt) with new infra Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 03/21] gdbstub: Implement thread_alive (T " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 04/21] gdbstub: Implement continue (c " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 05/21] gdbstub: Implement continue with signal (C " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 06/21] gdbstub: Implement set_thread (H " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 07/21] gdbstub: Implement insert breakpoint (Z " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 08/21] gdbstub: Implement remove breakpoint (z " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 09/21] gdbstub: Implement set register (P " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 10/21] gdbstub: Implement get register (p " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 11/21] gdbstub: Implement write memory (M " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 12/21] gdbstub: Implement read memory (m " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 13/21] gdbstub: Implement write all registers (G " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 14/21] gdbstub: Implement read all registers (g " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 15/21] gdbstub: Implement file io (F " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 16/21] gdbstub: Implement step (s " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 17/21] gdbstub: Implement v commands " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 18/21] gdbstub: Implement generic query (q pkt) " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 19/21] gdbstub: Implement generic set (Q " Jon Doron
2019-04-25 13:26 ` [Qemu-devel] [PATCH v6 20/21] gdbstub: Implement target halted (? " Jon Doron
2019-04-25 13:26 ` Jon Doron [this message]
2019-04-25 14:10 ` [Qemu-devel] [PATCH v6 00/21] gdbstub: Refactor command packets handler no-reply
2019-04-25 14:10 ` no-reply
2019-04-25 15:08 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425132636.31636-22-arilou@gmail.com \
--to=arilou@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.