From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Date: Thu, 25 Apr 2019 15:03:01 +0100 Message-ID: <20190425140301.GD23796@fuggles.cambridge.arm.com> References: <20190408012719.16158-1-leo.yan@linaro.org> <20190424142127.GC8948@leoy-ThinkPad-X240s> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D4E424A36C for ; Thu, 25 Apr 2019 10:03:07 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XD5-hUGdkQ86 for ; Thu, 25 Apr 2019 10:03:06 -0400 (EDT) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6F6FC4A321 for ; Thu, 25 Apr 2019 10:03:06 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20190424142127.GC8948@leoy-ThinkPad-X240s> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Leo Yan Cc: "kvm@vger.kernel.org" , Marc Zyngier , Robin Murphy , "kvmarm@lists.cs.columbia.edu" List-Id: kvmarm@lists.cs.columbia.edu On Wed, Apr 24, 2019 at 10:21:27PM +0800, Leo Yan wrote: > On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote: > > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > > failed to forward properly from host to guest, finally root caused this > > issue is related with kvmtool cannot re-enable INTx mode properly. > > > > So the basic working flow to reproduce this issue is as below: > > > > Host Guest > > ------------- -------------------- > > INTx mode > > MSI enable failed in NIC driver > > MSI disable in NIC driver > > Switch back to INTx mode --> kvmtool doesn't support > > > > So this patch is to support INTx mode re-enabling; patch 0001 is one > > minor fixing up for eventfd releasing; patch 0002 introduces a new > > function vfio_pci_init_intx() which is used to finish INTx one-time > > initialisation; patch 0003 is the core patch for support INTx mode > > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx > > mode. > > > > This patch set has been tested on Juno-r2 board. > > > > == Changes for V4 == > > * Removed the unnecessary comments in patch 0003 (Jean-Philippe). > > * Added Jean-Philippe's review tags. > > Could you pick up these 3 patches and merge into kvmtool? All of them > has been received reviewing tag from Jean-Philippe. Thanks. Sorry, I've fallen behind on kvmtool patches recently. I'll make a note to queue this lot up tomorrow. Cheers, Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A42C43218 for ; Thu, 25 Apr 2019 14:03:11 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3649C206BA for ; Thu, 25 Apr 2019 14:03:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3649C206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8D6C64A36C; Thu, 25 Apr 2019 10:03:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rSXfTNiNG9KY; Thu, 25 Apr 2019 10:03:09 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4D6FF4A452; Thu, 25 Apr 2019 10:03:09 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D4E424A36C for ; Thu, 25 Apr 2019 10:03:07 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XD5-hUGdkQ86 for ; Thu, 25 Apr 2019 10:03:06 -0400 (EDT) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6F6FC4A321 for ; Thu, 25 Apr 2019 10:03:06 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA709A78; Thu, 25 Apr 2019 07:03:05 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 55B513F246; Thu, 25 Apr 2019 07:03:04 -0700 (PDT) Date: Thu, 25 Apr 2019 15:03:01 +0100 From: Will Deacon To: Leo Yan Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Message-ID: <20190425140301.GD23796@fuggles.cambridge.arm.com> References: <20190408012719.16158-1-leo.yan@linaro.org> <20190424142127.GC8948@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190424142127.GC8948@leoy-ThinkPad-X240s> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Cc: "kvm@vger.kernel.org" , Marc Zyngier , Robin Murphy , "kvmarm@lists.cs.columbia.edu" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Message-ID: <20190425140301.qqHGd5XDHii2JruXKh70JNakfZ3E5Y6o6fymYcurHyU@z> On Wed, Apr 24, 2019 at 10:21:27PM +0800, Leo Yan wrote: > On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote: > > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > > failed to forward properly from host to guest, finally root caused this > > issue is related with kvmtool cannot re-enable INTx mode properly. > > > > So the basic working flow to reproduce this issue is as below: > > > > Host Guest > > ------------- -------------------- > > INTx mode > > MSI enable failed in NIC driver > > MSI disable in NIC driver > > Switch back to INTx mode --> kvmtool doesn't support > > > > So this patch is to support INTx mode re-enabling; patch 0001 is one > > minor fixing up for eventfd releasing; patch 0002 introduces a new > > function vfio_pci_init_intx() which is used to finish INTx one-time > > initialisation; patch 0003 is the core patch for support INTx mode > > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx > > mode. > > > > This patch set has been tested on Juno-r2 board. > > > > == Changes for V4 == > > * Removed the unnecessary comments in patch 0003 (Jean-Philippe). > > * Added Jean-Philippe's review tags. > > Could you pick up these 3 patches and merge into kvmtool? All of them > has been received reviewing tag from Jean-Philippe. Thanks. Sorry, I've fallen behind on kvmtool patches recently. I'll make a note to queue this lot up tomorrow. Cheers, Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9335C43218 for ; Thu, 25 Apr 2019 14:03:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A14CC206BA for ; Thu, 25 Apr 2019 14:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbfDYODG (ORCPT ); Thu, 25 Apr 2019 10:03:06 -0400 Received: from foss.arm.com ([217.140.101.70]:44952 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfDYODG (ORCPT ); Thu, 25 Apr 2019 10:03:06 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA709A78; Thu, 25 Apr 2019 07:03:05 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 55B513F246; Thu, 25 Apr 2019 07:03:04 -0700 (PDT) Date: Thu, 25 Apr 2019 15:03:01 +0100 From: Will Deacon To: Leo Yan Cc: "kvm@vger.kernel.org" , "kvmarm@lists.cs.columbia.edu" , Jean-Philippe Brucker , Marc Zyngier , Eric Auger , Robin Murphy Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Message-ID: <20190425140301.GD23796@fuggles.cambridge.arm.com> References: <20190408012719.16158-1-leo.yan@linaro.org> <20190424142127.GC8948@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424142127.GC8948@leoy-ThinkPad-X240s> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Apr 24, 2019 at 10:21:27PM +0800, Leo Yan wrote: > On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote: > > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > > failed to forward properly from host to guest, finally root caused this > > issue is related with kvmtool cannot re-enable INTx mode properly. > > > > So the basic working flow to reproduce this issue is as below: > > > > Host Guest > > ------------- -------------------- > > INTx mode > > MSI enable failed in NIC driver > > MSI disable in NIC driver > > Switch back to INTx mode --> kvmtool doesn't support > > > > So this patch is to support INTx mode re-enabling; patch 0001 is one > > minor fixing up for eventfd releasing; patch 0002 introduces a new > > function vfio_pci_init_intx() which is used to finish INTx one-time > > initialisation; patch 0003 is the core patch for support INTx mode > > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx > > mode. > > > > This patch set has been tested on Juno-r2 board. > > > > == Changes for V4 == > > * Removed the unnecessary comments in patch 0003 (Jean-Philippe). > > * Added Jean-Philippe's review tags. > > Could you pick up these 3 patches and merge into kvmtool? All of them > has been received reviewing tag from Jean-Philippe. Thanks. Sorry, I've fallen behind on kvmtool patches recently. I'll make a note to queue this lot up tomorrow. Cheers, Will