From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] dma-mapping: remove an unnecessary NULL check Date: Thu, 25 Apr 2019 16:18:32 +0200 Message-ID: <20190425141832.GA16643@lst.de> References: <20190424142437.GA29490@mwanda> <20190424142743.GC20974@lst.de> <3142dc82-1d4c-5f01-678e-628038d86bd6@mev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3142dc82-1d4c-5f01-678e-628038d86bd6@mev.co.uk> Sender: linux-kernel-owner@vger.kernel.org To: Ian Abbott Cc: Christoph Hellwig , Dan Carpenter , Jiri Slaby , Marek Szyprowski , Robin Murphy , iommu@lists.linux-foundation.org, "kernel-janitors@vger.kernel.org H Hartley Sweeten" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Thu, Apr 25, 2019 at 03:13:49PM +0100, Ian Abbott wrote: > So for comedi_isadma, we can just replace the NULL with a pointer to a > static dummy device with a 24-bit coherent mask? It should be converted to a proper isa_driver, so that it gets a real struct device. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE188C43218 for ; Thu, 25 Apr 2019 14:19:26 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFD7C206BF for ; Thu, 25 Apr 2019 14:19:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFD7C206BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 980D71EA8; Thu, 25 Apr 2019 14:19:26 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B6C5E1BCC for ; Thu, 25 Apr 2019 14:18:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 37DAF82A for ; Thu, 25 Apr 2019 14:18:49 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id C43A268B20; Thu, 25 Apr 2019 16:18:32 +0200 (CEST) Date: Thu, 25 Apr 2019 16:18:32 +0200 From: Christoph Hellwig To: Ian Abbott Subject: Re: [PATCH] dma-mapping: remove an unnecessary NULL check Message-ID: <20190425141832.GA16643@lst.de> References: <20190424142437.GA29490@mwanda> <20190424142743.GC20974@lst.de> <3142dc82-1d4c-5f01-678e-628038d86bd6@mev.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3142dc82-1d4c-5f01-678e-628038d86bd6@mev.co.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, "kernel-janitors@vger.kernel.org H Hartley Sweeten" , iommu@lists.linux-foundation.org, Jiri Slaby , Robin Murphy , Christoph Hellwig , Dan Carpenter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190425141832.6DPkoLPMTaGzAzPp-BU7LYoikNnfgyJpNElvoEUS2E8@z> On Thu, Apr 25, 2019 at 03:13:49PM +0100, Ian Abbott wrote: > So for comedi_isadma, we can just replace the NULL with a pointer to a > static dummy device with a 24-bit coherent mask? It should be converted to a proper isa_driver, so that it gets a real struct device. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu