From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D678C43219 for ; Thu, 25 Apr 2019 16:51:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE45A206BF for ; Thu, 25 Apr 2019 16:51:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726991AbfDYQvV (ORCPT ); Thu, 25 Apr 2019 12:51:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38540 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfDYQvU (ORCPT ); Thu, 25 Apr 2019 12:51:20 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3PGnmsQ120028 for ; Thu, 25 Apr 2019 12:51:20 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s3gherht7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Apr 2019 12:51:19 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Apr 2019 17:51:19 +0100 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 25 Apr 2019 17:51:17 +0100 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3PGpGg160096608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2019 16:51:16 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7876EBE053; Thu, 25 Apr 2019 16:51:16 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B2EDEBE051; Thu, 25 Apr 2019 16:51:15 +0000 (GMT) Received: from kashyyyk (unknown [9.18.239.165]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 25 Apr 2019 16:51:15 +0000 (GMT) Date: Thu, 25 Apr 2019 13:51:09 -0300 From: Mauro Rodrigues To: Murilo Fossa Vicentini Cc: netdev@vger.kernel.org, tlfalcon@linux.ibm.com Subject: Re: [PATCH net-next] ibmvnic: Add device identification to requested IRQs References: <20190425140233.99658-1-muvic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190425140233.99658-1-muvic@linux.ibm.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-TM-AS-GCONF: 00 x-cbid: 19042516-0016-0000-0000-000009A6F066 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010994; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000285; SDB=6.01194251; UDB=6.00626120; IPR=6.00975080; MB=3.00026594; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-25 16:51:19 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19042516-0017-0000-0000-000042F4FA0E Message-Id: <20190425165109.GA12859@kashyyyk> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-25_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904250103 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 25, 2019 at 11:02:33AM -0300, Murilo Fossa Vicentini wrote: > The ibmvnic driver currently uses the same fixed name when using > request_irq, this makes it hard to parse when multiple VNIC devices are > available at the same time. This patch adds the unit_address as the device > identification along with an id for each queue. > > The original idea was to use the interface name as an identifier, but it > is not feasible given these requests happen at adapter probe, and at this > point netdev is not yet registered so it doesn't have the proper name > assigned to it. > > Signed-off-by: Murilo Fossa Vicentini Reviewed-by: Mauro S. M. Rodrigues This is very useful, thanks!