From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 1/2] drm/prime: split drm_gem_prime_fd_to_handle() Date: Thu, 25 Apr 2019 19:07:51 +0200 Message-ID: <20190425170751.GA7051@ravnborg.org> References: <20190425155114.533-1-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4229E891E7 for ; Thu, 25 Apr 2019 17:07:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190425155114.533-1-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgRW1pbC4KClRoYW5rcyBmb3IgdGhlIHBhdGNoIC0gaXQgbG9va3MgbGlrZSBhIGdvb2Qgc2lt cGxpZmljYXRpb24uCgpUaGUgY2hhbmdlcyBpbnRyb2R1Y2VkIGluIGltcG9ydF9idWZfdG9faGFu ZGxlKCkgY2hhbmdlcyB0aGUgbG9naWMKYSBsaXR0bGUgdG8gYXZvaWQgZ290byAtIHRoaXMgaHVy dHMgcmVhZGFiaWxpdHkuCkl0IHdvdWxkIGJlIGJldHRlciB0byBrZWVwIHRoZSBjdXJyZW50IHN0 cnVjdHVyZSBhbmQgdXNlIGdvdG8gbGFiZWwKdG8gaGFubGRlIHRoZSBlcnJvciBzaXR1YXRpb25z LgpUaGVuIGVycm9yIGhhbmRsaW5kIGlzIG1vcmUgY29uc2lzdGVudCBhbmQgaXQgaXMgZWFzaWVy IHdoZW4gd2UKbmVlZCB0byBleHRlbmQgdGhpcyBpbiB0aGUgZnV0dXJlLgoKCVNhbQoKCiBUaHUs IEFwciAyNSwgMjAxOSBhdCAwNDo1MToxM1BNICswMTAwLCBFbWlsIFZlbGlrb3Ygd3JvdGU6Cj4g RnJvbTogRW1pbCBWZWxpa292IDxlbWlsLnZlbGlrb3ZAY29sbGFib3JhLmNvbT4KPiAKPiBDdXJy ZW50bHkgZHJtX2dlbV9wcmltZV9mZF90b19oYW5kbGUoKSBjb25zaXN0cyBvZiBpbGxlZ2libGUg YW1vdW50IG9mCj4gZ290byBsYWJlbHMsIGZvciBubyBvYnZpb3VzIHJlYXNvbi4KPiAKPiBTcGxp dCBpdCBpbiB0d28gKGFzIGJlbG93KSBtYWtpbmcgdGhlIGNvZGUgZmFyIHNpbXBsZXIgYW5kIG9i dmlvdXMuCj4gCj4gZHJtX2dlbV9wcmltZV9mZF90b19oYW5kbGUoKQo+IC0gcHJpbWUgbXR4IGhh bmRsaW5nCj4gLSBmZC9kbWFidWYgcmVmY291bnRpbmcKPiAtIGhhc2ggdGFibGUgbG9va3VwCj4g Cj4gaW1wb3J0X2J1Zl90b19oYW5kbGUoKQo+ICAtIGRybV9nZW1fb2JqZWN0IGltcG9ydCBhbmQg bG9ja2luZwo+ICAtIGNyZWF0aW5nIGEgaGFuZGxlIGZvciB0aGUgZ2VtIG9iamVjdAo+ICAtIGFk ZGluZyB0aGUgaGFuZGxlL2ZkIHRvIHRoZSBoYXNoIHRhYmxlCj4gCj4gQ2M6IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBFbWlsIFZlbGlrb3YgPGVtaWwu dmVsaWtvdkBjb2xsYWJvcmEuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1l LmMgfCA4NiArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspLCA0NSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmlt ZS5jCj4gaW5kZXggZGMwNzllZmIzYjBmLi4wZDgzYjliYmY3OTMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcmlt ZS5jCj4gQEAgLTc3NywzNyArNzc3LDE0IEBAIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqZHJtX2dl bV9wcmltZV9pbXBvcnQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgfQo+ICBFWFBPUlRfU1lN Qk9MKGRybV9nZW1fcHJpbWVfaW1wb3J0KTsKPiAgCj4gLS8qKgo+IC0gKiBkcm1fZ2VtX3ByaW1l X2ZkX3RvX2hhbmRsZSAtIFBSSU1FIGltcG9ydCBmdW5jdGlvbiBmb3IgR0VNIGRyaXZlcnMKPiAt ICogQGRldjogZGV2IHRvIGV4cG9ydCB0aGUgYnVmZmVyIGZyb20KPiAtICogQGZpbGVfcHJpdjog ZHJtIGZpbGUtcHJpdmF0ZSBzdHJ1Y3R1cmUKPiAtICogQHByaW1lX2ZkOiBmZCBpZCBvZiB0aGUg ZG1hLWJ1ZiB3aGljaCBzaG91bGQgYmUgaW1wb3J0ZWQKPiAtICogQGhhbmRsZTogcG9pbnRlciB0 byBzdG9yYWdlIGZvciB0aGUgaGFuZGxlIG9mIHRoZSBpbXBvcnRlZCBidWZmZXIgb2JqZWN0Cj4g LSAqCj4gLSAqIFRoaXMgaXMgdGhlIFBSSU1FIGltcG9ydCBmdW5jdGlvbiB3aGljaCBtdXN0IGJl IHVzZWQgbWFuZGF0b3JpbHkgYnkgR0VNCj4gLSAqIGRyaXZlcnMgdG8gZW5zdXJlIGNvcnJlY3Qg bGlmZXRpbWUgbWFuYWdlbWVudCBvZiB0aGUgdW5kZXJseWluZyBHRU0gb2JqZWN0Lgo+IC0gKiBU aGUgYWN0dWFsIGltcG9ydGluZyBvZiBHRU0gb2JqZWN0IGZyb20gdGhlIGRtYS1idWYgaXMgZG9u ZSB0aHJvdWdoIHRoZQo+IC0gKiBnZW1faW1wb3J0X2V4cG9ydCBkcml2ZXIgY2FsbGJhY2suCj4g LSAqLwo+IC1pbnQgZHJtX2dlbV9wcmltZV9mZF90b19oYW5kbGUoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiAtCQkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LCBpbnQgcHJpbWVf ZmQsCj4gLQkJCSAgICAgICB1aW50MzJfdCAqaGFuZGxlKQo+ICtzdGF0aWMgaW50IGltcG9ydF9i dWZfdG9faGFuZGxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCSAgICAgICAgc3RydWN0 IGRybV9maWxlICpmaWxlX3ByaXYsCj4gKwkJCSAgICAgICAgc3RydWN0IGRtYV9idWYgKmRtYV9i dWYsCj4gKwkJCSAgICAgICAgdWludDMyX3QgKmhhbmRsZSkKPiAgewo+IC0Jc3RydWN0IGRtYV9i dWYgKmRtYV9idWY7Cj4gIAlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iajsKPiAgCWludCByZXQ7 Cj4gIAo+IC0JZG1hX2J1ZiA9IGRtYV9idWZfZ2V0KHByaW1lX2ZkKTsKPiAtCWlmIChJU19FUlIo ZG1hX2J1ZikpCj4gLQkJcmV0dXJuIFBUUl9FUlIoZG1hX2J1Zik7Cj4gLQo+IC0JbXV0ZXhfbG9j aygmZmlsZV9wcml2LT5wcmltZS5sb2NrKTsKPiAtCj4gLQlyZXQgPSBkcm1fcHJpbWVfbG9va3Vw X2J1Zl9oYW5kbGUoJmZpbGVfcHJpdi0+cHJpbWUsCj4gLQkJCWRtYV9idWYsIGhhbmRsZSk7Cj4g LQlpZiAocmV0ID09IDApCj4gLQkJZ290byBvdXRfcHV0Owo+IC0KPiAgCS8qIG5ldmVyIHNlZW4g dGhpcyBvbmUsIG5lZWQgdG8gaW1wb3J0ICovCj4gIAltdXRleF9sb2NrKCZkZXYtPm9iamVjdF9u YW1lX2xvY2spOwo+ICAJaWYgKGRldi0+ZHJpdmVyLT5nZW1fcHJpbWVfaW1wb3J0KQo+IEBAIC04 MTYsNyArNzkzLDggQEAgaW50IGRybV9nZW1fcHJpbWVfZmRfdG9faGFuZGxlKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gIAkJb2JqID0gZHJtX2dlbV9wcmltZV9pbXBvcnQoZGV2LCBkbWFfYnVm KTsKPiAgCWlmIChJU19FUlIob2JqKSkgewo+ICAJCXJldCA9IFBUUl9FUlIob2JqKTsKPiAtCQln b3RvIG91dF91bmxvY2s7Cj4gKwkJbXV0ZXhfdW5sb2NrKCZkZXYtPm9iamVjdF9uYW1lX2xvY2sp Owo+ICsJCXJldHVybiByZXQ7Cj4gIAl9Cj4gIAo+ICAJaWYgKG9iai0+ZG1hX2J1Zikgewo+IEBA IC04MzAsMjkgKzgwOCw0NyBAQCBpbnQgZHJtX2dlbV9wcmltZV9mZF90b19oYW5kbGUoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgCXJldCA9IGRybV9nZW1faGFuZGxlX2NyZWF0ZV90YWlsKGZp bGVfcHJpdiwgb2JqLCBoYW5kbGUpOwo+ICAJZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKG9i aik7Cj4gIAlpZiAocmV0KQo+IC0JCWdvdG8gb3V0X3B1dDsKPiArCQlyZXR1cm4gcmV0Owo+ICAK PiAtCXJldCA9IGRybV9wcmltZV9hZGRfYnVmX2hhbmRsZSgmZmlsZV9wcml2LT5wcmltZSwKPiAt CQkJZG1hX2J1ZiwgKmhhbmRsZSk7Cj4gLQltdXRleF91bmxvY2soJmZpbGVfcHJpdi0+cHJpbWUu bG9jayk7Cj4gKwlyZXQgPSBkcm1fcHJpbWVfYWRkX2J1Zl9oYW5kbGUoJmZpbGVfcHJpdi0+cHJp bWUsIGRtYV9idWYsICpoYW5kbGUpOwo+ICAJaWYgKHJldCkKPiAtCQlnb3RvIGZhaWw7Cj4gKwkJ LyogaG1tLCBpZiBkcml2ZXIgYXR0YWNoZWQsIHdlIGFyZSByZWx5aW5nIG9uIHRoZSBmcmVlLW9i amVjdAo+ICsJCSAqIHBhdGggdG8gZGV0YWNoLi4gd2hpY2ggc2VlbXMgb2suLgo+ICsJCSAqLwo+ ICsJCWRybV9nZW1faGFuZGxlX2RlbGV0ZShmaWxlX3ByaXYsICpoYW5kbGUpOwo+ICAKPiAtCWRt YV9idWZfcHV0KGRtYV9idWYpOwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICAKPiAtCXJldHVybiAw Owo+ICsvKioKPiArICogZHJtX2dlbV9wcmltZV9mZF90b19oYW5kbGUgLSBQUklNRSBpbXBvcnQg ZnVuY3Rpb24gZm9yIEdFTSBkcml2ZXJzCj4gKyAqIEBkZXY6IGRldiB0byBleHBvcnQgdGhlIGJ1 ZmZlciBmcm9tCj4gKyAqIEBmaWxlX3ByaXY6IGRybSBmaWxlLXByaXZhdGUgc3RydWN0dXJlCj4g KyAqIEBwcmltZV9mZDogZmQgaWQgb2YgdGhlIGRtYS1idWYgd2hpY2ggc2hvdWxkIGJlIGltcG9y dGVkCj4gKyAqIEBoYW5kbGU6IHBvaW50ZXIgdG8gc3RvcmFnZSBmb3IgdGhlIGhhbmRsZSBvZiB0 aGUgaW1wb3J0ZWQgYnVmZmVyIG9iamVjdAo+ICsgKgo+ICsgKiBUaGlzIGlzIHRoZSBQUklNRSBp bXBvcnQgZnVuY3Rpb24gd2hpY2ggbXVzdCBiZSB1c2VkIG1hbmRhdG9yaWx5IGJ5IEdFTQo+ICsg KiBkcml2ZXJzIHRvIGVuc3VyZSBjb3JyZWN0IGxpZmV0aW1lIG1hbmFnZW1lbnQgb2YgdGhlIHVu ZGVybHlpbmcgR0VNIG9iamVjdC4KPiArICogVGhlIGFjdHVhbCBpbXBvcnRpbmcgb2YgR0VNIG9i amVjdCBmcm9tIHRoZSBkbWEtYnVmIGlzIGRvbmUgdGhyb3VnaCB0aGUKPiArICogZ2VtX2ltcG9y dF9leHBvcnQgZHJpdmVyIGNhbGxiYWNrLgo+ICsgKi8KPiAraW50IGRybV9nZW1fcHJpbWVfZmRf dG9faGFuZGxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCSAgICAgICBzdHJ1Y3QgZHJt X2ZpbGUgKmZpbGVfcHJpdiwgaW50IHByaW1lX2ZkLAo+ICsJCQkgICAgICAgdWludDMyX3QgKmhh bmRsZSkKPiArewo+ICsJc3RydWN0IGRtYV9idWYgKmRtYV9idWY7Cj4gKwlpbnQgcmV0Owo+ICAK PiAtZmFpbDoKPiAtCS8qIGhtbSwgaWYgZHJpdmVyIGF0dGFjaGVkLCB3ZSBhcmUgcmVseWluZyBv biB0aGUgZnJlZS1vYmplY3QgcGF0aAo+IC0JICogdG8gZGV0YWNoLi4gd2hpY2ggc2VlbXMgb2su Lgo+IC0JICovCj4gLQlkcm1fZ2VtX2hhbmRsZV9kZWxldGUoZmlsZV9wcml2LCAqaGFuZGxlKTsK PiAtCWRtYV9idWZfcHV0KGRtYV9idWYpOwo+IC0JcmV0dXJuIHJldDsKPiArCWRtYV9idWYgPSBk bWFfYnVmX2dldChwcmltZV9mZCk7Cj4gKwlpZiAoSVNfRVJSKGRtYV9idWYpKQo+ICsJCXJldHVy biBQVFJfRVJSKGRtYV9idWYpOwo+ICsKPiArCW11dGV4X2xvY2soJmZpbGVfcHJpdi0+cHJpbWUu bG9jayk7Cj4gKwo+ICsJcmV0ID0gZHJtX3ByaW1lX2xvb2t1cF9idWZfaGFuZGxlKCZmaWxlX3By aXYtPnByaW1lLCBkbWFfYnVmLCBoYW5kbGUpOwo+ICsJaWYgKHJldCkKPiArCQlyZXQgPSBpbXBv cnRfYnVmX3RvX2hhbmRsZShkZXYsIGZpbGVfcHJpdiwgZG1hX2J1ZiwgaGFuZGxlKTsKPiAgCj4g LW91dF91bmxvY2s6Cj4gLQltdXRleF91bmxvY2soJmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4g LW91dF9wdXQ6Cj4gIAltdXRleF91bmxvY2soJmZpbGVfcHJpdi0+cHJpbWUubG9jayk7Cj4gIAlk bWFfYnVmX3B1dChkbWFfYnVmKTsKPiAgCXJldHVybiByZXQ7Cj4gLS0gCj4gMi4yMS4wCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==