From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs
Date: Thu, 25 Apr 2019 19:46:15 +0200 [thread overview]
Message-ID: <20190425174615.GA8544@kroah.com> (raw)
In-Reply-To: <CAHmME9rycs66KYXhxa5t5=7B9JkrotU1MMxXDFXrxqCM27ysBw@mail.gmail.com>
On Tue, Apr 16, 2019 at 06:03:58PM +0900, Jason A. Donenfeld wrote:
> On Tue, Apr 16, 2019 at 4:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > This patch aims to suppress up to 18 missing-break-in-switch false
> > positives on some architectures.
> >
> > Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> > Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > Cc: Kees Cook <keescook@chromium.org>
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Looks good to me, thanks for this.
>
> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Perhaps Greg can take it through his tree?
Me? Ok, fine, I'll go queue it up...
next prev parent reply other threads:[~2019-04-25 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 7:27 [PATCH] lib/siphash.c: mark expected switch fall-throughs Stephen Rothwell
2019-04-16 9:03 ` Jason A. Donenfeld
2019-04-25 17:46 ` Greg Kroah-Hartman [this message]
2019-04-25 18:03 ` Gustavo A. R. Silva
2019-04-25 20:28 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425174615.GA8544@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.