From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ilya Dryomov <idryomov@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
ceph-devel@vger.kernel.org,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Ceph fixes for 5.1-rc7
Date: Thu, 25 Apr 2019 19:21:00 +0100 [thread overview]
Message-ID: <20190425182100.GU2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=wgPBx9xPWY7obK60=RTnOF3Ln0j9XkhYbekML=Fi3bFXg@mail.gmail.com>
On Thu, Apr 25, 2019 at 11:02:54AM -0700, Linus Torvalds wrote:
> I've pulled this, but maybe Jeff wants to look at whether that
> snapshotting model could have helped.
I really wonder if 76a495d666e5 (ceph: ensure d_name stability in
ceph_dentry_hash()) makes any sense; OK, you have ->d_lock held
over that, but what does it protect against? Sure, you'll get
something that was valid while you held ->d_lock, but what good
does it do to the callers? If they really have to care about
races with d_move(), which value do they want?
next prev parent reply other threads:[~2019-04-25 18:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 17:47 [GIT PULL] Ceph fixes for 5.1-rc7 Ilya Dryomov
2019-04-25 18:02 ` Linus Torvalds
2019-04-25 18:21 ` Al Viro [this message]
2019-04-25 18:24 ` Linus Torvalds
2019-04-25 18:31 ` Al Viro
2019-04-25 18:36 ` Jeff Layton
2019-04-25 18:23 ` Jeff Layton
2019-04-25 20:09 ` Al Viro
2019-04-26 16:25 ` Jeff Layton
2019-04-26 16:36 ` Linus Torvalds
2019-04-26 16:43 ` Linus Torvalds
2019-04-26 17:01 ` Al Viro
2019-04-26 17:08 ` Linus Torvalds
2019-04-26 17:11 ` Al Viro
2019-04-26 20:49 ` Jeff Layton
2019-04-26 21:28 ` Al Viro
2019-04-26 16:50 ` Al Viro
2019-04-26 17:30 ` Jeff Layton
2019-04-28 4:38 ` Al Viro
2019-04-28 13:27 ` Jeff Layton
2019-04-28 14:48 ` Al Viro
2019-04-28 15:47 ` Jeff Layton
2019-04-28 15:52 ` Al Viro
2019-04-28 16:18 ` Jeff Layton
2019-04-28 16:40 ` Al Viro
2019-04-25 18:35 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425182100.GU2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.