From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v6,03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform From: Rob Herring Message-Id: <20190425213658.GB32028@bogus> Date: Thu, 25 Apr 2019 16:36:58 -0500 To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Felipe Balbi , Greg Kroah-Hartman List-ID: T24gU2F0LCBBcHIgMjAsIDIwMTkgYXQgMDI6NDA6MDlQTSArMDgwMCwgWXUgQ2hlbiB3cm90ZToK PiBUaGlzIHBhdGNoIGFkZHMgc3VwcG9ydCBmb3IgdGhlIHBvd2Vyb24gYW5kIHNodXRkb3duIG9m IGR3YzMgY29yZQo+IG9uIEhpc2lsaWNvbiBTb2MgUGxhdGZvcm0uCj4gCj4gQ2M6IEZlbGlwZSBC YWxiaSA8YmFsYmlAa2VybmVsLm9yZz4KPiBDYzogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hA bGludXhmb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFy by5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogWXUgQ2hlbiA8Y2hlbnl1NTZAaHVhd2VpLmNvbT4KPiAt LS0KPiAgZHJpdmVycy91c2IvZHdjMy9kd2MzLW9mLXNpbXBsZS5jIHwgNCArKystCj4gIDEgZmls ZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy91c2IvZHdjMy9kd2MzLW9mLXNpbXBsZS5jIGIvZHJpdmVycy91c2IvZHdjMy9k d2MzLW9mLXNpbXBsZS5jCj4gaW5kZXggNGMyNzcxYzVlNzI3Li4wZWQwOWQ4NzY1NDIgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy91c2IvZHdjMy9kd2MzLW9mLXNpbXBsZS5jCj4gKysrIGIvZHJpdmVy cy91c2IvZHdjMy9kd2MzLW9mLXNpbXBsZS5jCj4gQEAgLTk4LDcgKzk4LDggQEAgc3RhdGljIGlu dCBkd2MzX29mX3NpbXBsZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJ ICogU29tZSBjb250cm9sbGVycyBuZWVkIHRvIHRvZ2dsZSB0aGUgdXNiMy1vdGcgcmVzZXQgYmVm b3JlIHRyeWluZyB0bwo+ICAJICogaW5pdGlhbGl6ZSB0aGUgUEhZLCBvdGhlcndpc2UgdGhlIFBI WSB0aW1lcyBvdXQuCj4gIAkgKi8KPiAtCWlmIChvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShucCwg InJvY2tjaGlwLHJrMzM5OS1kd2MzIikpCj4gKwlpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUo bnAsICJyb2NrY2hpcCxyazMzOTktZHdjMyIpIHx8Cj4gKwkJCW9mX2RldmljZV9pc19jb21wYXRp YmxlKG5wLCAiaGlzaWxpY29uLGhpMzY2MC1kd2MzIikpCj4gIAkJc2ltcGxlLT5uZWVkX3Jlc2V0 ID0gdHJ1ZTsKCkZpbmUsIEkgZ3Vlc3MsIGJ1dCByZWFsbHkgdGhpcyBmbGFnIHNob3VsZCBiZSBt b3ZlZCB0byB0aGUgbWF0Y2ggdGFibGUgCnNvIHdlIGFyZW4ndCBkb2luZyBjb21wYXRpYmxlIG1h dGNoaW5nIHR3aWNlLgoKPiAgCj4gIAlpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUobnAsICJh bWxvZ2ljLG1lc29uLWF4Zy1kd2MzIikgfHwKPiBAQCAtMjQzLDYgKzI0NCw3IEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIG9mX2R3YzNfc2ltcGxlX21hdGNoW10gPSB7Cj4gIAl7 IC5jb21wYXRpYmxlID0gImFtbG9naWMsbWVzb24tYXhnLWR3YzMiIH0sCj4gIAl7IC5jb21wYXRp YmxlID0gImFtbG9naWMsbWVzb24tZ3hsLWR3YzMiIH0sCj4gIAl7IC5jb21wYXRpYmxlID0gImFs bHdpbm5lcixzdW41MGktaDYtZHdjMyIgfSwKPiArCXsgLmNvbXBhdGlibGUgPSAiaGlzaWxpY29u LGhpMzY2MC1kd2MzIiB9LAo+ICAJeyAvKiBTZW50aW5lbCAqLyB9Cj4gIH07Cj4gIE1PRFVMRV9E RVZJQ0VfVEFCTEUob2YsIG9mX2R3YzNfc2ltcGxlX21hdGNoKTsKPiAtLSAKPiAyLjE1LjAtcmMy Cj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74901C43218 for ; Thu, 25 Apr 2019 21:37:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85EB620675 for ; Thu, 25 Apr 2019 21:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556228227; bh=HuV9UvpUxbLXeeTQfjRUNm8essZEcNP96aHEFmqA35Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NaL/3pE//Y7jEYA+7knOD6MB7mZxjly9UKut2d20UpBW4ApSZ0C3H178dJt6c3e4e aXdJWOzUEA6fqBJYTHaac7oIt9Kzz0yB4JTPSAzaW88sHxfQIW/iQgP2SIAOPEcTqd 4oRjv2K0RO8pVX3IUEgthvAX4vPcHfuIdv1poqKU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbfDYVhB (ORCPT ); Thu, 25 Apr 2019 17:37:01 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:35504 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbfDYVhB (ORCPT ); Thu, 25 Apr 2019 17:37:01 -0400 Received: by mail-ot1-f65.google.com with SMTP id m10so897746otp.2; Thu, 25 Apr 2019 14:37:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Hk1r+IVwxSo0Cb3NtR3Z2pyp3YJEoBDs1OgkjX9P97Y=; b=NfQTtb0pxahR9YnzcbrB4+YXrOVhA5p71qAti3dihytuOn/s+oSvlAiFZAQR0uvFqz VfT4OM8vlJoic6aKcfMCgXHQQWFuApli8bmrk/z+mjizwC0/EckawKof0J5cnlXnsYBR Zh4DDTXfoJAfmAY+vCMiZYVUVBTT+fnI3SejuJRU+Ot7qFolp84UCFc/a3GwthK+JSWv BUNsbk+YCc02h8eh39fzOh5fB+qYolMOjqFK+savxlVtLq+P7vm+C21DSVajSppQVb16 3J3HnWp801M/TS2Jkz/nf35FLrI2EJ7uR/6GHhuDWgflUSyBRZVbDipza2zV1woCbubJ yLgA== X-Gm-Message-State: APjAAAWHUnYjU5XZakoSdxMlSo/rrL+kibBgqe+x/WPXSkHalsPMaRXq yw68TXjlVlVv+8lnk/ue/g== X-Google-Smtp-Source: APXvYqzCwz0AiXDeuE1MlYVSxG7LifGiAIwd4Y1Q0OYEZsOL/BJDGXz4/4hSKyIGxQXq5GYRvBWb8A== X-Received: by 2002:a9d:6318:: with SMTP id q24mr12996657otk.95.1556228219180; Thu, 25 Apr 2019 14:36:59 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l23sm1431441otr.81.2019.04.25.14.36.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 14:36:58 -0700 (PDT) Date: Thu, 25 Apr 2019 16:36:58 -0500 From: Rob Herring To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Felipe Balbi , Greg Kroah-Hartman Subject: Re: [PATCH v6 03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Message-ID: <20190425213658.GB32028@bogus> References: <20190420064019.57522-1-chenyu56@huawei.com> <20190420064019.57522-4-chenyu56@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190420064019.57522-4-chenyu56@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190425213658.ewur_ZgksV0SUhSwteSrgKCmZajxGmojfZ7OaE72yRA@z> On Sat, Apr 20, 2019 at 02:40:09PM +0800, Yu Chen wrote: > This patch adds support for the poweron and shutdown of dwc3 core > on Hisilicon Soc Platform. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: John Stultz > Signed-off-by: Yu Chen > --- > drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c > index 4c2771c5e727..0ed09d876542 100644 > --- a/drivers/usb/dwc3/dwc3-of-simple.c > +++ b/drivers/usb/dwc3/dwc3-of-simple.c > @@ -98,7 +98,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) > * Some controllers need to toggle the usb3-otg reset before trying to > * initialize the PHY, otherwise the PHY times out. > */ > - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3")) > + if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") || > + of_device_is_compatible(np, "hisilicon,hi3660-dwc3")) > simple->need_reset = true; Fine, I guess, but really this flag should be moved to the match table so we aren't doing compatible matching twice. > > if (of_device_is_compatible(np, "amlogic,meson-axg-dwc3") || > @@ -243,6 +244,7 @@ static const struct of_device_id of_dwc3_simple_match[] = { > { .compatible = "amlogic,meson-axg-dwc3" }, > { .compatible = "amlogic,meson-gxl-dwc3" }, > { .compatible = "allwinner,sun50i-h6-dwc3" }, > + { .compatible = "hisilicon,hi3660-dwc3" }, > { /* Sentinel */ } > }; > MODULE_DEVICE_TABLE(of, of_dwc3_simple_match); > -- > 2.15.0-rc2 >