From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] usb: usb251xb: Lock i2c-bus segment the hub resides From: Serge Semin Message-Id: <20190426104650.30240-1-fancer.lancer@gmail.com> Date: Fri, 26 Apr 2019 13:46:50 +0300 To: Richard Leitner , Greg Kroah-Hartman Cc: Serge Semin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: U01CdXMgc2xhdmUgY29uZmlndXJhdGlvbiBpcyBhY3RpdmF0ZWQgYnkgQ0ZHX1NFTFsxOjBdPTB4 MSBwaW5zCnN0YXRlLiBUaGlzIGlzIHRoZSBtb2RlIHRoZSBodWIgaXMgc3VwcG9zZWQgdG8gYmUg dG8gbGV0IHRoaXMgZHJpdmVyCndvcmsgY29ycmVjdGx5LiBCdXQgYSByYWNlIGNvbmRpdGlvbiBt aWdodCBoYXBwZW4gcmlnaHQgYWZ0ZXIgcmVzZXQKaXMgY2xlYXJlZCBkdWUgdG8gQ0ZHX1NFTFsw XSBwaW4gYmVpbmcgbXVsdGlwbGV4ZWQgd2l0aCBTTUJ1cyBTQ0wKZnVuY3Rpb24uIEluIGNhc2Ug aWYgdGhlIHJlc2V0IHBpbiBpcyBoYW5kbGVkIGJ5IGEgaTJjIEdQSU8gZXhwYW5kZXIsCndoaWNo IGlzIGFsc28gcGxhY2VkIGF0IHRoZSBzYW1lIGkyYy1idXMgc2VnbWVudCBhcyB0aGUgdXNiMjUx eApTTUItaW50ZXJmYWNlIGNvbm5lY3RlZCB0bywgdGhlbiB0aGUgaHViIHJlc2V0IGNsZWFyYW5j ZSBtaWdodApjYXVzZSB0aGUgQ0ZHX1NFTFswXSBiZWluZyBsYXRjaGVkIGluIHVucHJlZGljdGFi bGUgc3RhdGUuIFNvCnNvbWV0aW1lcyB0aGUgaHViIGNvbmZpZ3VyYXRpb24gbW9kZSBtaWdodCBi ZSAweDEgKGFzIGV4cGVjdGVkKSwKYnV0IHNvbWV0aW1lcyBiZWluZyAweDAsIHdoaWNoIGRvZXNu J3QgaW1wbHkgdG8gaGF2ZSB0aGUgaHViIFNNQnVzLXNsYXZlCmludGVyZmFjZSBhY3RpdmF0ZWQg YW5kIGNvbnNlcXVlbnRseSBjYXVzZXMgdGhpcyBkcml2ZXIgZmFpbHVyZS4KCkluIG9yZGVyIHRv IGZpeCB0aGUgcHJvYmxlbSB3ZSBtdXN0IG1ha2Ugc3VyZSB0aGUgR1BJTy1yZXNldCBjaGlwIGRv ZXNuJ3QKcmVzaWRlIHRoZSBzYW1lIGkyYy1idXMgc2VnbWVudCBhcyB0aGUgU01CdXMtaW50ZXJm YWNlIG9mIHRoZSBodWIuIElmCml0IGRvZXNuJ3QsIHdlIGNhbiBzYWZlbHkgYmxvY2sgdGhlIHNl Z21lbnQgZm9yIHRoZSB0aW1lIHRoZSByZXNldCBpcwpjbGVhcmVkIHRvIHByZXZlbnQgYW55b25l IGdlbmVyYXRpbmcgYSB0cmFmZmljIGF0IHRoZSBpMmMtYnVzIFNDTCBsYW5lCmNvbm5lY3RlZCB0 byB0aGUgQ0ZHX1NFTFswXSBwaW4uIEJ1dCBpZiBpdCBkb2VzLCBub3RoaW5nIHdlIGNhbiBkbywg c28KanVzdCByZXR1cm4gYW4gZXJyb3IuIElmIHdlIGxvY2tlZCB0aGUgaTJjLWJ1cyBzZWdtZW50 IGFuZCB0cmllZCB0bwpjb21tdW5pY2F0ZSB3aXRoIHRoZSBHUElPLWV4cGFuZGVyLCBpdCB3b3Vs ZCBjYXVzZSBhIGRlYWRsb2NrLiBJZiB3ZSBkaWRuJ3QKbG9jayB0aGUgaTJjLWJ1cyBzZWdtZW50 LCBpdCB3b3VsZCByYW5kb21seSBjYXVzZSB0aGUgQ0ZHX1NFTFswXSBiaXQgZmxpcC4KClNpZ25l ZC1vZmYtYnk6IFNlcmdlIFNlbWluIDxmYW5jZXIubGFuY2VyQGdtYWlsLmNvbT4KU2lnbmVkLW9m Zi1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KLS0t CkNoYW5nZWxvZyB2MgotIEV4ZWN1dGUgdGhlIGNoZWNrIGNvZGUgb25seSBpZiBHUElPTElCIGlz IGVuYWJsZWQgKHJlcG9ydGVkIGJ5CiAgYSBidWlsZCByb2JvdCkuCi0tLQogZHJpdmVycy91c2Iv bWlzYy91c2IyNTF4Yi5jIHwgNjIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KwogMSBmaWxlIGNoYW5nZWQsIDYyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kcml2ZXJz L3VzYi9taXNjL3VzYjI1MXhiLmMgYi9kcml2ZXJzL3VzYi9taXNjL3VzYjI1MXhiLmMKaW5kZXgg MDQ2ODQ4NDlkNjgzLi5jZGM4MGU4YzJkOGEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL21pc2Mv dXNiMjUxeGIuYworKysgYi9kcml2ZXJzL3VzYi9taXNjL3VzYjI1MXhiLmMKQEAgLTEyLDYgKzEy LDcgQEAKIAogI2luY2x1ZGUgPGxpbnV4L2RlbGF5Lmg+CiAjaW5jbHVkZSA8bGludXgvZ3Bpby9j b25zdW1lci5oPgorI2luY2x1ZGUgPGxpbnV4L2dwaW8vZHJpdmVyLmg+CiAjaW5jbHVkZSA8bGlu dXgvaTJjLmg+CiAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+CiAjaW5jbHVkZSA8bGludXgvbmxz Lmg+CkBAIC0yMjIsMTEgKzIyMyw1MSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHVzYjI1MXhiX2Rh dGEgdXNiMjUxN2lfZGF0YSA9IHsKIAkucHJvZHVjdF9zdHIgPSAiVVNCMjUxN2kiLAogfTsKIAor I2lmZGVmIENPTkZJR19HUElPTElCCitzdGF0aWMgaW50IHVzYjI1MXhiX2NoZWNrX2Rldl9jaGls ZHJlbihzdHJ1Y3QgZGV2aWNlICpkZXYsIHZvaWQgKmNoaWxkKQoreworCWlmIChkZXYtPnR5cGUg PT0gJmkyY19hZGFwdGVyX3R5cGUpIHsKKwkJcmV0dXJuIGRldmljZV9mb3JfZWFjaF9jaGlsZChk ZXYsIGNoaWxkLAorCQkJCQkgICAgIHVzYjI1MXhiX2NoZWNrX2Rldl9jaGlsZHJlbik7CisJfQor CisJcmV0dXJuIChkZXYgPT0gY2hpbGQpOworfQorCitzdGF0aWMgaW50IHVzYjI1MXhfY2hlY2tf Z3Bpb19jaGlwKHN0cnVjdCB1c2IyNTF4YiAqaHViKQoreworCXN0cnVjdCBncGlvX2NoaXAgKmdj ID0gZ3Bpb2RfdG9fY2hpcChodWItPmdwaW9fcmVzZXQpOworCXN0cnVjdCBpMmNfYWRhcHRlciAq YWRhcCA9IGh1Yi0+aTJjLT5hZGFwdGVyOworCWludCByZXQ7CisKKwlpZiAoIWh1Yi0+Z3Bpb19y ZXNldCkKKwkJcmV0dXJuIDA7CisKKwlpZiAoIWdjKQorCQlyZXR1cm4gLUVJTlZBTDsKKworCXJl dCA9IHVzYjI1MXhiX2NoZWNrX2Rldl9jaGlsZHJlbigmYWRhcC0+ZGV2LCBnYy0+cGFyZW50KTsK KwlpZiAocmV0KSB7CisJCWRldl9lcnIoaHViLT5kZXYsICJSZXNldCBHUElPIGNoaXAgaXMgYXQg dGhlIHNhbWUgaTJjLWJ1c1xuIik7CisJCXJldHVybiAtRUlOVkFMOworCX0KKworCXJldHVybiAw OworfQorI2Vsc2UKK3N0YXRpYyBpbnQgdXNiMjUxeF9jaGVja19ncGlvX2NoaXAoc3RydWN0IHVz YjI1MXhiICpodWIpCit7CisJcmV0dXJuIDA7Cit9CisjZW5kaWYKKwogc3RhdGljIHZvaWQgdXNi MjUxeGJfcmVzZXQoc3RydWN0IHVzYjI1MXhiICpodWIsIGludCBzdGF0ZSkKIHsKIAlpZiAoIWh1 Yi0+Z3Bpb19yZXNldCkKIAkJcmV0dXJuOwogCisJaTJjX2xvY2tfYnVzKGh1Yi0+aTJjLT5hZGFw dGVyLCBJMkNfTE9DS19TRUdNRU5UKTsKKwogCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChodWIt PmdwaW9fcmVzZXQsIHN0YXRlKTsKIAogCS8qIHdhaXQgZm9yIGh1YiByZWNvdmVyeS9zdGFiaWxp emF0aW9uICovCkBAIC0yMzQsNiArMjc1LDggQEAgc3RhdGljIHZvaWQgdXNiMjUxeGJfcmVzZXQo c3RydWN0IHVzYjI1MXhiICpodWIsIGludCBzdGF0ZSkKIAkJdXNsZWVwX3JhbmdlKDUwMCwgNzUw KTsJLyogPj01MDB1cyBhdCBwb3dlciBvbiAqLwogCWVsc2UKIAkJdXNsZWVwX3JhbmdlKDEsIDEw KTsJLyogPj0xdXMgYXQgcG93ZXIgZG93biAqLworCisJaTJjX3VubG9ja19idXMoaHViLT5pMmMt PmFkYXB0ZXIsIEkyQ19MT0NLX1NFR01FTlQpOwogfQogCiBzdGF0aWMgaW50IHVzYjI1MXhiX2Nv bm5lY3Qoc3RydWN0IHVzYjI1MXhiICpodWIpCkBAIC02MjEsNiArNjY0LDI1IEBAIHN0YXRpYyBp bnQgdXNiMjUxeGJfcHJvYmUoc3RydWN0IHVzYjI1MXhiICpodWIpCiAJCX0KIAl9CiAKKwkvKgor CSAqIHVzYjI1MXggU01CdXMtc2xhdmUgU0NMIGxhbmUgaXMgbXV4ZWQgd2l0aCBDRkdfU0VMMCBw aW4uIFNvIGlmIGFueW9uZQorCSAqIHRyaWVzIHRvIHdvcmsgd2l0aCB0aGUgYnVzIGF0IHRoZSBt b21lbnQgdGhlIGh1YiByZXNldCBpcyByZWxlYXNlZCwKKwkgKiBpdCBtYXkgY2F1c2UgYW4gaW52 YWxpZCBjb25maWcgYmVpbmcgbGF0Y2hlZCBieSB1c2IyNTF4LiBQYXJ0aWN1bGFybHkKKwkgKiBv bmUgb2YgdGhlIGNvbmZpZyBtb2RlcyBtYWtlcyB0aGUgaHViIGxvYWRpbmcgYSBkZWZhdWx0IHJl Z2lzdGVycworCSAqIHZhbHVlIHdpdGhvdXQgU01CdXMtc2xhdmUgaW50ZXJmYWNlIGFjdGl2YXRp b24uIElmIHRoZSBodWIKKwkgKiBhY2NpZGVudGFsbHkgZ2V0cyB0aGlzIG1vZGUsIHRoaXMgd2ls bCBjYXVzZSB0aGUgZHJpdmVyIFNNQnVzLQorCSAqIGZ1bmN0aW9ucyBmYWlsdXJlLiBOb3JtYWxs eSB3ZSBjb3VsZCBqdXN0IGxvY2sgdGhlIFNNQnVzLXNlZ21lbnQgdGhlCisJICogaHViIGkyYy1p bnRlcmZhY2UgcmVzaWRlcyBmb3IgdGhlIGRldmljZS1zcGVjaWZpYyByZXNldCB0aW1pbmcuIEJ1 dAorCSAqIHRoZSBHUElPIGNvbnRyb2xsZXIsIHdoaWNoIGlzIHVzZWQgdG8gaGFuZGxlIHRoZSBo dWIgcmVzZXQsIG1pZ2h0IGJlCisJICogcGxhY2VkIGF0IHRoZSBzYW1lIGkyYy1idXMgc2VnbWVu dC4gSW4gdGhpcyBjYXNlIGFuIGVycm9yIHNob3VsZCBiZQorCSAqIHJldHVybmVkIHNpbmNlIHdl IGNhbid0IHNhZmVseSB1c2UgdGhlIEdQSU8gY29udHJvbGxlciB0byBjbGVhciB0aGUKKwkgKiBy ZXNldCBzdGF0ZSAoaXQgbWF5IGFmZmVjdCB0aGUgaHViIGNvbmZpZ3VyYXRpb24pIGFuZCB3ZSBj YW4ndCBsb2NrCisJICogdGhlIGkyYy1idXMgc2VnbWVudCAoaXQgd2lsbCBjYXVzZSBhIGRlYWRs b2NrKS4KKwkgKi8KKwllcnIgPSB1c2IyNTF4X2NoZWNrX2dwaW9fY2hpcChodWIpOworCWlmIChl cnIpCisJCXJldHVybiBlcnI7CisKIAllcnIgPSB1c2IyNTF4Yl9jb25uZWN0KGh1Yik7CiAJaWYg KGVycikgewogCQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBjb25uZWN0IGh1YiAoJWQpXG4iLCBl cnIpOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8CBC43219 for ; Fri, 26 Apr 2019 10:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CEA5206A3 for ; Fri, 26 Apr 2019 10:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mYQUEDun" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725971AbfDZKrS (ORCPT ); Fri, 26 Apr 2019 06:47:18 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33613 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfDZKrR (ORCPT ); Fri, 26 Apr 2019 06:47:17 -0400 Received: by mail-lf1-f67.google.com with SMTP id j11so2160491lfm.0; Fri, 26 Apr 2019 03:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S9WmBj7lYS3B9JO11dPKodyj6vLzXViJHTZDgC2h0T8=; b=mYQUEDun/9QyUHJmOREcbNmw3b5fNI2u65bIzrZMlPq22QmuL24jsLtzZ7k46L+Eh9 A0Ei+jiYHd3jgBWuURFXtl9rJYGmxRbFkr5ABF+CZ2NKHI+X4H2ZlzoPHQIuj0BgaDNK e8jdpaVP5lBNHivdvX5U13BChJzvZHn5v8sxixBM/86fU2nScwKIski5Cg98VBiEUYaT FoxqjH3sHixBrpWJSFG8ZsQSVFBoj+bkZ+C8/bi7a56KtWW7kGQ2eDUpX0tvbI47JFxg p0imXFOU2wQyWUdgwHJSsxyYMib5GsKoq4bd8U6X9k+NkksE+NHCol2InZH/nVtQo7fS yIMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S9WmBj7lYS3B9JO11dPKodyj6vLzXViJHTZDgC2h0T8=; b=Wced/0FIc5zfvR4g2WqdStLo63uhfDRYD8TeDLeULNcxt9ToFclBzcntkA3aaHq4DQ EmaZyCClBr11XSM29GXz8Fiu7gyVDias0GSAAgtKdlbSIHiet2oCr3WimP777bbf0oPh OPZcEl6Z+GX/vM/BbXlCUFNY//qJBbuWdTQjqB89ocj1EqW803jXwEgtR7qTJWLDodSu A+8RLc+QWXCmkGz1ti1KmwuxXL2xkdBeX5U/hkpJ4ORvKjPB4rqmhsvMxpEvAXOBxqH6 O04piLzBX5QGbOc99yptySWHUcSKQpyieSvU/QIIk+r+aLmh/9OQAJmLMoyBQHJfQS1e vCXw== X-Gm-Message-State: APjAAAXVYhqtk/w2Pyj47knrXHPYHu9T4QJvfx60i3gkDzDCoZtBAxvu MEdn6jv9bsyuiqhk+ZXgF9k= X-Google-Smtp-Source: APXvYqwkbpmvQPjj5HIpaDDvrc5bAqcingJoTDlqH73duzuzxHQKS+3BtgTR5BD+WM94vYTL6KRj6w== X-Received: by 2002:a19:7d04:: with SMTP id y4mr6435872lfc.153.1556275634600; Fri, 26 Apr 2019 03:47:14 -0700 (PDT) Received: from localhost.localdomain ([5.164.240.123]) by smtp.gmail.com with ESMTPSA id 10sm1801799ljc.48.2019.04.26.03.47.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 03:47:13 -0700 (PDT) From: Serge Semin To: Richard Leitner , Greg Kroah-Hartman Cc: Serge Semin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] usb: usb251xb: Lock i2c-bus segment the hub resides Date: Fri, 26 Apr 2019 13:46:50 +0300 Message-Id: <20190426104650.30240-1-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424144914.10580-1-fancer.lancer@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID: <20190426104650.3a4csFLAVgIRwllY1DmQcfiW3ZgIXthBtvOEsZum3d0@z> SMBus slave configuration is activated by CFG_SEL[1:0]=0x1 pins state. This is the mode the hub is supposed to be to let this driver work correctly. But a race condition might happen right after reset is cleared due to CFG_SEL[0] pin being multiplexed with SMBus SCL function. In case if the reset pin is handled by a i2c GPIO expander, which is also placed at the same i2c-bus segment as the usb251x SMB-interface connected to, then the hub reset clearance might cause the CFG_SEL[0] being latched in unpredictable state. So sometimes the hub configuration mode might be 0x1 (as expected), but sometimes being 0x0, which doesn't imply to have the hub SMBus-slave interface activated and consequently causes this driver failure. In order to fix the problem we must make sure the GPIO-reset chip doesn't reside the same i2c-bus segment as the SMBus-interface of the hub. If it doesn't, we can safely block the segment for the time the reset is cleared to prevent anyone generating a traffic at the i2c-bus SCL lane connected to the CFG_SEL[0] pin. But if it does, nothing we can do, so just return an error. If we locked the i2c-bus segment and tried to communicate with the GPIO-expander, it would cause a deadlock. If we didn't lock the i2c-bus segment, it would randomly cause the CFG_SEL[0] bit flip. Signed-off-by: Serge Semin Signed-off-by: Greg Kroah-Hartman --- Changelog v2 - Execute the check code only if GPIOLIB is enabled (reported by a build robot). --- drivers/usb/misc/usb251xb.c | 62 +++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index 04684849d683..cdc80e8c2d8a 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -12,6 +12,7 @@ #include #include +#include #include #include #include @@ -222,11 +223,51 @@ static const struct usb251xb_data usb2517i_data = { .product_str = "USB2517i", }; +#ifdef CONFIG_GPIOLIB +static int usb251xb_check_dev_children(struct device *dev, void *child) +{ + if (dev->type == &i2c_adapter_type) { + return device_for_each_child(dev, child, + usb251xb_check_dev_children); + } + + return (dev == child); +} + +static int usb251x_check_gpio_chip(struct usb251xb *hub) +{ + struct gpio_chip *gc = gpiod_to_chip(hub->gpio_reset); + struct i2c_adapter *adap = hub->i2c->adapter; + int ret; + + if (!hub->gpio_reset) + return 0; + + if (!gc) + return -EINVAL; + + ret = usb251xb_check_dev_children(&adap->dev, gc->parent); + if (ret) { + dev_err(hub->dev, "Reset GPIO chip is at the same i2c-bus\n"); + return -EINVAL; + } + + return 0; +} +#else +static int usb251x_check_gpio_chip(struct usb251xb *hub) +{ + return 0; +} +#endif + static void usb251xb_reset(struct usb251xb *hub, int state) { if (!hub->gpio_reset) return; + i2c_lock_bus(hub->i2c->adapter, I2C_LOCK_SEGMENT); + gpiod_set_value_cansleep(hub->gpio_reset, state); /* wait for hub recovery/stabilization */ @@ -234,6 +275,8 @@ static void usb251xb_reset(struct usb251xb *hub, int state) usleep_range(500, 750); /* >=500us at power on */ else usleep_range(1, 10); /* >=1us at power down */ + + i2c_unlock_bus(hub->i2c->adapter, I2C_LOCK_SEGMENT); } static int usb251xb_connect(struct usb251xb *hub) @@ -621,6 +664,25 @@ static int usb251xb_probe(struct usb251xb *hub) } } + /* + * usb251x SMBus-slave SCL lane is muxed with CFG_SEL0 pin. So if anyone + * tries to work with the bus at the moment the hub reset is released, + * it may cause an invalid config being latched by usb251x. Particularly + * one of the config modes makes the hub loading a default registers + * value without SMBus-slave interface activation. If the hub + * accidentally gets this mode, this will cause the driver SMBus- + * functions failure. Normally we could just lock the SMBus-segment the + * hub i2c-interface resides for the device-specific reset timing. But + * the GPIO controller, which is used to handle the hub reset, might be + * placed at the same i2c-bus segment. In this case an error should be + * returned since we can't safely use the GPIO controller to clear the + * reset state (it may affect the hub configuration) and we can't lock + * the i2c-bus segment (it will cause a deadlock). + */ + err = usb251x_check_gpio_chip(hub); + if (err) + return err; + err = usb251xb_connect(hub); if (err) { dev_err(dev, "Failed to connect hub (%d)\n", err); -- 2.21.0