From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJyTe-0003d3-L7 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 06:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJyTd-0003Tv-Ej for qemu-devel@nongnu.org; Fri, 26 Apr 2019 06:53:10 -0400 Date: Fri, 26 Apr 2019 12:53:01 +0200 From: Kevin Wolf Message-ID: <20190426105301.GA20769@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Failing qemu-iotest 005 with raw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Qemu-block , QEMU Developers , Max Reitz , hch@lst.de Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben: > > When running iotest 005 with raw, the test currently fails for me: > > 005 - output mismatch (see 005.out.bad) > --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out 2019-04-23 > 16:43:11.000000000 +0200 > +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad 2019-04-26 > 11:34:11.000000000 +0200 > @@ -1,13 +1,12 @@ > QA output created by 005 > > creating large image > +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file > format 'IMGFMT' > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000 > [...] > > Could this be fixed somehow, or should the test rather be skipped for > IMGFMT=raw? The test passes for me on XFS. Looks like the raw driver can handle large image files, but your host filesystem can't. We would have to check whether the host filesystem can support large files and skip the test if it can't. I'm not sure how to do that. But actually, this isn't testing anything interesting for raw, so just unconditionally disabling the test for raw could be reasonable enough. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB13C43219 for ; Fri, 26 Apr 2019 10:54:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F2582077B for ; Fri, 26 Apr 2019 10:54:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F2582077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:44704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJyUS-0003yV-8v for qemu-devel@archiver.kernel.org; Fri, 26 Apr 2019 06:54:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJyTe-0003d3-L7 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 06:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJyTd-0003Tv-Ej for qemu-devel@nongnu.org; Fri, 26 Apr 2019 06:53:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55606) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJyTa-0003KL-Go; Fri, 26 Apr 2019 06:53:06 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33A98309D049; Fri, 26 Apr 2019 10:53:04 +0000 (UTC) Received: from localhost.localdomain (ovpn-117-86.ams2.redhat.com [10.36.117.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C282160FBD; Fri, 26 Apr 2019 10:53:02 +0000 (UTC) Date: Fri, 26 Apr 2019 12:53:01 +0200 From: Kevin Wolf To: Thomas Huth Message-ID: <20190426105301.GA20769@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 26 Apr 2019 10:53:04 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Failing qemu-iotest 005 with raw X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@lst.de, QEMU Developers , Qemu-block , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190426105301.bpFaT8GwBiKMmXww-99wW1f_382wcX5e7Ty5z7Djq-o@z> Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben: > > When running iotest 005 with raw, the test currently fails for me: > > 005 - output mismatch (see 005.out.bad) > --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out 2019-04-23 > 16:43:11.000000000 +0200 > +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad 2019-04-26 > 11:34:11.000000000 +0200 > @@ -1,13 +1,12 @@ > QA output created by 005 > > creating large image > +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file > format 'IMGFMT' > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000 > [...] > > Could this be fixed somehow, or should the test rather be skipped for > IMGFMT=raw? The test passes for me on XFS. Looks like the raw driver can handle large image files, but your host filesystem can't. We would have to check whether the host filesystem can support large files and skip the test if it can't. I'm not sure how to do that. But actually, this isn't testing anything interesting for raw, so just unconditionally disabling the test for raw could be reasonable enough. Kevin